"SitePerProcessTextInputManagerTest.LookUpStringForRangeRoutesToFocusedWidget" is flaky |
|||
Issue description"SitePerProcessTextInputManagerTest.LookUpStringForRangeRoutesToFocusedWidget" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyVwsSBUZsYWtlIkxTaXRlUGVyUHJvY2Vzc1RleHRJbnB1dE1hbmFnZXJUZXN0Lkxvb2tVcFN0cmluZ0ZvclJhbmdlUm91dGVzVG9Gb2N1c2VkV2lkZ2V0DA. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Apr 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e6ecce297581a5384f30f6eabad53586447f3184 commit e6ecce297581a5384f30f6eabad53586447f3184 Author: jdoerrie <jdoerrie@chromium.org> Date: Wed Apr 12 14:42:21 2017 Disable flaky LookUpStringForRangeRoutesToFocusedWidget TBR=creis@chromium.org BUG=710842 Review-Url: https://codereview.chromium.org/2812283002 Cr-Commit-Position: refs/heads/master@{#464020} [modify] https://crrev.com/e6ecce297581a5384f30f6eabad53586447f3184/chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc
,
Apr 12 2017
ekaramad@, can you take a look?
,
Apr 12 2017
I will. Thanks!
,
Nov 17 2017
Dropping to P2 since the test is disabled, but it would still be great to get this enabled again.
,
May 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6b389690cd36d0d8043dc952344ba66df6a8cf0b commit 6b389690cd36d0d8043dc952344ba66df6a8cf0b Author: Ehsan Karamad <ekaramad@chromium.org> Date: Wed May 09 22:42:06 2018 Reworking the test "LookUpStringForRangeRoutesToFocusedWidget" This CL reworks the test to make the logic more tractable. The new version relies on swizzling the method [NSView showDefinitionForAttributedString] which is the method for showing the MacOS dictionary. The previous version relied on counting the number of windows which seems incorrect. Bug: 710842 Change-Id: I483f849882ced00bc603f1b2417c69dfebd0f315 Reviewed-on: https://chromium-review.googlesource.com/1050886 Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Ehsan Karamad <ekaramad@chromium.org> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#557352} [modify] https://crrev.com/6b389690cd36d0d8043dc952344ba66df6a8cf0b/chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc [modify] https://crrev.com/6b389690cd36d0d8043dc952344ba66df6a8cf0b/content/public/test/content_browser_test_utils.h [modify] https://crrev.com/6b389690cd36d0d8043dc952344ba66df6a8cf0b/content/public/test/content_browser_test_utils_mac.mm |
|||
►
Sign in to add a comment |
|||
Comment 1 by jdoerrie@chromium.org
, Apr 12 2017Owner: creis@chromium.org
Status: Assigned (was: Untriaged)