New issue
Advanced search Search tips
Starred by 3 users

Issue metadata

Status: Fixed
Closed: Jul 2017
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Feature

Blocked on:
issue 627945
issue 717525

issue 567358

Sign in to add a comment

Implement WorkletOptions for Worklet.addModule()

Project Member Reported by, Apr 12 2017 Back to list

Issue description

Optional "WorkletOptions" was introduced for Worklet.import().

Spec change:

interface Worklet {
    [NewObject] Promise<void> import(USVString moduleURL, optional WorkletOptions options);

dictionary WorkletOptions {
    RequestCredentials credentials = "omit";
Summary: Implement WorkletOptions for Worklet.addModule() (was: Implement WorkletOptions for Worklet.import())
Hi Nhiroki,

I was checking the spec for it , so we need to add new parameter "WorkletOptions" to the Worklet.addModule() but then I am not getting once we get the Request Credentials  { "omit", "same-origin", "include" } what  we need to do with that or at present the requirement is only to add extra parameter as per the spec.

Request you to clarify or guide on this. 
Blockedon: 627945
I think now is not a good time to start this issue because addModule() is now actively being implemented (see  issue 627945 ). I'll update this once the blocker is fixed.
Blockedon: 717525
Status: Started (was: Available)
Let me take this issue...
Project Member

Comment 7 by, May 12 2017

The following revision refers to this bug:

commit a3385c2e0f06b3331338de800b014f9ce0086718
Author: nhiroki <>
Date: Fri May 12 13:36:36 2017

Worklet: Introduce WorkletOptions for addModule()

This CL introduces WorkletOptions dictionary for addModule(). This provides
"RequestCredentials" option, but it's not actually used yet because module
loading part is still under development. Once the module loading is enabled,
we'll add layout tests for this option.


BUG= 710837

Cr-Commit-Position: refs/heads/master@{#471296}


Blocking: 567358
Labels: M-60
Status: Fixed (was: Started)
Filed a separate issue to add layout/wpt tests for WorkletOptions ( issue 738769 )

Sign in to add a comment