New issue
Advanced search Search tips

Issue 710837 link

Starred by 3 users
Status: Fixed
Owner:
nhiroki@chromium.org
Closed: Jul 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Feature

Blocked on:
issue 627945
issue 717525
Blocking:
issue 567358



Sign in to add a comment

Implement WorkletOptions for Worklet.addModule()

Project Member Reported by nhiroki@chromium.org, Apr 12 2017 
Optional "WorkletOptions" was introduced for Worklet.import().

Spec: https://drafts.css-houdini.org/worklets/#worklet-section
Spec change: https://github.com/w3c/css-houdini-drafts/pull/382


interface Worklet {
    [NewObject] Promise<void> import(USVString moduleURL, optional WorkletOptions options);
};

dictionary WorkletOptions {
    RequestCredentials credentials = "omit";
};

Comment 1 by nhiroki@chromium.org, Apr 19 2017

Summary: Implement WorkletOptions for Worklet.addModule() (was: Implement WorkletOptions for Worklet.import())

Comment 2 by nikhil.s...@samsung.com, Apr 21 2017 

Hi Nhiroki,

I was checking the spec for it , so we need to add new parameter "WorkletOptions" to the Worklet.addModule() but then I am not getting once we get the Request Credentials  { "omit", "same-origin", "include" } what  we need to do with that or at present the requirement is only to add extra parameter as per the spec.

Request you to clarify or guide on this.

Comment 3 by nhiroki@chromium.org, Apr 21 2017

Blockedon: 627945
I think now is not a good time to start this issue because addModule() is now actively being implemented (see  issue 627945 ). I'll update this once the blocker is fixed.

Comment 4 by nhiroki@chromium.org, May 11 2017

Blockedon: 717525

Comment 5 by nhiroki@chromium.org, May 12 2017

Owner: nhiroki@chromium.org
Status: Started (was: Available)
Let me take this issue...
Project Member

Comment 7 by bugdroid1@chromium.org, May 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a3385c2e0f06b3331338de800b014f9ce0086718

commit a3385c2e0f06b3331338de800b014f9ce0086718
Author: nhiroki <nhiroki@chromium.org>
Date: Fri May 12 13:36:36 2017

Worklet: Introduce WorkletOptions for addModule()

This CL introduces WorkletOptions dictionary for addModule(). This provides
"RequestCredentials" option, but it's not actually used yet because module
loading part is still under development. Once the module loading is enabled,
we'll add layout tests for this option.

Spec: https://drafts.css-houdini.org/worklets/#dictdef-workletoptions

BUG= 710837 
TBR=ikilpatrick@chromium.org

Review-Url: https://codereview.chromium.org/2868413005
Cr-Commit-Position: refs/heads/master@{#471296}

[modify] https://crrev.com/a3385c2e0f06b3331338de800b014f9ce0086718/third_party/WebKit/Source/bindings/core/v8/BUILD.gn
[modify] https://crrev.com/a3385c2e0f06b3331338de800b014f9ce0086718/third_party/WebKit/Source/core/core_idl_files.gni
[modify] https://crrev.com/a3385c2e0f06b3331338de800b014f9ce0086718/third_party/WebKit/Source/core/workers/MainThreadWorklet.cpp
[modify] https://crrev.com/a3385c2e0f06b3331338de800b014f9ce0086718/third_party/WebKit/Source/core/workers/MainThreadWorklet.h
[modify] https://crrev.com/a3385c2e0f06b3331338de800b014f9ce0086718/third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.cpp
[modify] https://crrev.com/a3385c2e0f06b3331338de800b014f9ce0086718/third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.h
[modify] https://crrev.com/a3385c2e0f06b3331338de800b014f9ce0086718/third_party/WebKit/Source/core/workers/ThreadedWorklet.cpp
[modify] https://crrev.com/a3385c2e0f06b3331338de800b014f9ce0086718/third_party/WebKit/Source/core/workers/ThreadedWorklet.h
[modify] https://crrev.com/a3385c2e0f06b3331338de800b014f9ce0086718/third_party/WebKit/Source/core/workers/Worklet.cpp
[modify] https://crrev.com/a3385c2e0f06b3331338de800b014f9ce0086718/third_party/WebKit/Source/core/workers/Worklet.h
[modify] https://crrev.com/a3385c2e0f06b3331338de800b014f9ce0086718/third_party/WebKit/Source/core/workers/Worklet.idl
[modify] https://crrev.com/a3385c2e0f06b3331338de800b014f9ce0086718/third_party/WebKit/Source/core/workers/WorkletGlobalScopeProxy.h
[add] https://crrev.com/a3385c2e0f06b3331338de800b014f9ce0086718/third_party/WebKit/Source/core/workers/WorkletOptions.idl
[modify] https://crrev.com/a3385c2e0f06b3331338de800b014f9ce0086718/third_party/WebKit/Source/modules/csspaint/PaintWorkletGlobalScopeProxy.cpp
[modify] https://crrev.com/a3385c2e0f06b3331338de800b014f9ce0086718/third_party/WebKit/Source/modules/csspaint/PaintWorkletGlobalScopeProxy.h

Comment 8 by nhiroki@chromium.org, May 26 2017

Blocking: 567358

Comment 9 by nhiroki@chromium.org, Jul 3 2017

Labels: M-60
Status: Fixed (was: Started)
Filed a separate issue to add layout/wpt tests for WorkletOptions ( issue 738769 )
►

Sign in to add a comment