New issue
Advanced search Search tips

Issue 710818 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

The WebRTC echo canceller 3 has poor transparency when the analog microphone gain is changed

Project Member Reported by peah@chromium.org, Apr 12 2017

Issue description

The WebRTC echo canceller 3 has poor transparency when the analog microphone gain is changed. This is expected, but the transparency reduction is a bit too high.
 
Labels: OS-All
Status: Assigned (was: Untriaged)
[Triage] Setting as assigned since it has an owner.
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/103ac7e7d9c3548bf43ffa3a24b5e89689695c02

commit 103ac7e7d9c3548bf43ffa3a24b5e89689695c02
Author: peah <peah@webrtc.org>
Date: Wed Apr 12 12:40:55 2017

AEC3 Tuning changes.

This CL adds tuning to AEC3 for the purpose of reducing the impact of
gain changes in the analog microphone gain.

BUG= chromium:710818 ,  webrtc:6018 

Review-Url: https://codereview.webrtc.org/2811283003
Cr-Commit-Position: refs/heads/master@{#17673}

[modify] https://crrev.com/103ac7e7d9c3548bf43ffa3a24b5e89689695c02/webrtc/modules/audio_processing/aec3/aec_state.cc
[modify] https://crrev.com/103ac7e7d9c3548bf43ffa3a24b5e89689695c02/webrtc/modules/audio_processing/audio_processing_impl.cc

Comment 3 by peah@chromium.org, Apr 19 2017

Labels: -Pri-3 Pri-1

Comment 4 by peah@chromium.org, Apr 19 2017

Labels: Merge-Request-59
Project Member

Comment 5 by sheriffbot@chromium.org, Apr 19 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved Merge-Approved-59
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 6 by gov...@chromium.org, Apr 21 2017

Please merge your change to M59 branch #3071 latest before 4:00 PM PT, Monday (04/24) so we can take it for next week last M59 dev release. Thank you.
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 24 2017

Labels: merge-merged-59
The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/262cbaa88d1e3cbed55087fdf9d168fcf0312b17

commit 262cbaa88d1e3cbed55087fdf9d168fcf0312b17
Author: peah <peah@webrtc.org>
Date: Mon Apr 24 07:42:31 2017

Merge of the AEC3 Tuning changes.

This CL is a merge of 103ac7e7d9c3548bf43ffa3a24b5e89689695c02 into
M59.

This CL adds tuning to AEC3 for the purpose of reducing the impact of
gain changes in the analog microphone gain.
NOTRY=true
NOPRESUBMIT=true
BUG= chromium:710818 ,  webrtc:6018 

Review-Url: https://codereview.webrtc.org/2811283003
Cr-Commit-Position: refs/heads/master@{#17673}
(cherry picked from commit 103ac7e7d9c3548bf43ffa3a24b5e89689695c02)

Review-Url: https://codereview.webrtc.org/2833643003
Cr-Commit-Position: refs/branch-heads/59@{#3}
Cr-Branched-From: 10d095d4f743bc16f8e486e156c48a6d023b32c5-refs/heads/master@{#17657}

[modify] https://crrev.com/262cbaa88d1e3cbed55087fdf9d168fcf0312b17/webrtc/modules/audio_processing/aec3/aec_state.cc
[modify] https://crrev.com/262cbaa88d1e3cbed55087fdf9d168fcf0312b17/webrtc/modules/audio_processing/audio_processing_impl.cc

Project Member

Comment 8 by sheriffbot@chromium.org, Apr 24 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 9 by peah@chromium.org, Apr 24 2017

Status: Fixed (was: Assigned)
Project Member

Comment 10 by sheriffbot@chromium.org, Apr 27 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 11 by peah@chromium.org, May 3 2017

Labels: -Hotlist-Merge-Approved -Merge-Approved-59

Sign in to add a comment