New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 710817 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----

Blocked on:
issue 710577


Participants' hotlists:
Chromium-Packagers


Sign in to add a comment

publish_tarball: error: pathspec 'refs/tags/58.0.3029.51' did not match any file(s) known to git

Project Member Reported by phajdan.jr@chromium.org, Apr 12 2017

Issue description

I'm seeing strange errors on publish_tarball builder, related to not recognizing tags of recent releases:

https://build.chromium.org/p/chromium.infra.cron/builders/publish_tarball/builds/7007

error: pathspec 'refs/tags/58.0.3029.51' did not match any file(s) known to git

It works fine locally. In case you wonder, bot_update does get passed --with_branch_heads option.

Several other versions seem to be affected, and I also can't repro the errors locally:

59.0.3067.6
59.0.3067.0
58.0.3029.54
58.0.3029.40
58.0.3029.33
 
Blockedon: 710577
Issue 710577 may be a contributing factor. Please note the issue was present in some way for about a week already. An outage in last day or two wouldn't fully explain it then.

Comment 3 by dimu@google.com, Apr 12 2017

https://chromium.googlesource.com/chromium/src/+/refs/tags/58.0.3029.51/DEPS is there..

I used a sequence of:
git checkout -b auto_release_branch aba3eb683b30adce02c5be41e84c431dac599c59(commit that updated chrome/VERSION to 58.0.3029.51 on branch 3029)
git commit -a -m Publish DEPS for Chromium 58.0.3029.51
git tag 58.0.3029.51 HEAD -f
git push origin refs/tags/58.0.3029.51

Should I push tags in some other ways?

Logs:
for 'git push origin refs/tags/58.0.3029.51'
https://luci-logdog.appspot.com/v/?s=infra-internal%2Fbb%2Fofficial.infra.cron%2Fchrome-release%2F136%2F%2B%2Frecipes%2Fsteps%2Fpublish_public_buildspec%2F0%2Fsteps%2Fgit_push%2F0%2Fstdout

from Step 10 on https://uberchromegw.corp.google.com/i/official.infra.cron/builders/chrome-release/builds/136

Comment 4 by mmoss@chromium.org, Apr 12 2017

All those tags exist on the master. Note that --with_branch_heads and --with_tags are different things. You might need to add the latter.
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/7ac2c9a29242f68a56d8765d377128e1ebeb0b1f

commit 7ac2c9a29242f68a56d8765d377128e1ebeb0b1f
Author: Paweł Hajdan, Jr <phajdan.jr@chromium.org>
Date: Wed Apr 12 16:00:01 2017

bot_update: add --with_tags switch

Bug:  710817 
Change-Id: Ice7cefaf5c5a5cac431a95d3adfa44f323eafb2f
Reviewed-on: https://chromium-review.googlesource.com/475230
Reviewed-by: Michael Moss <mmoss@chromium.org>
Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>

[modify] https://crrev.com/7ac2c9a29242f68a56d8765d377128e1ebeb0b1f/recipes/recipe_modules/bot_update/resources/bot_update.py

Project Member

Comment 6 by bugdroid1@chromium.org, Apr 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/7ac2c9a29242f68a56d8765d377128e1ebeb0b1f

commit 7ac2c9a29242f68a56d8765d377128e1ebeb0b1f
Author: Paweł Hajdan, Jr <phajdan.jr@chromium.org>
Date: Wed Apr 12 16:00:01 2017

bot_update: add --with_tags switch

Bug:  710817 
Change-Id: Ice7cefaf5c5a5cac431a95d3adfa44f323eafb2f
Reviewed-on: https://chromium-review.googlesource.com/475230
Reviewed-by: Michael Moss <mmoss@chromium.org>
Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>

[modify] https://crrev.com/7ac2c9a29242f68a56d8765d377128e1ebeb0b1f/recipes/recipe_modules/bot_update/resources/bot_update.py

Project Member

Comment 8 by bugdroid1@chromium.org, Apr 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/d59382fad6c93fb031b63a215515d8a600c491bf

commit d59382fad6c93fb031b63a215515d8a600c491bf
Author: Paweł Hajdan, Jr <phajdan.jr@chromium.org>
Date: Wed Apr 12 17:03:25 2017

publish_tarball: pass --with_tags to bot_update

Bug:  710817 
Change-Id: I4cf38dc579a803322600b35c676f541db558b163
Reviewed-on: https://chromium-review.googlesource.com/475654
Reviewed-by: Michael Moss <mmoss@chromium.org>
Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>

[modify] https://crrev.com/d59382fad6c93fb031b63a215515d8a600c491bf/recipes/recipes/publish_tarball.py
[modify] https://crrev.com/d59382fad6c93fb031b63a215515d8a600c491bf/recipes/recipes/publish_tarball.expected/basic.json

Comment 9 by d...@chromium.org, Apr 12 2017

Owner: phajdan.jr@chromium.org
Status: Assigned (was: Untriaged)
Since phajdan.jr@ has been working on this, I'm going to go ahead and assign it. Please unassign or move back to trooper queue if you're done!
Status: Fixed (was: Assigned)

Sign in to add a comment