New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 710812 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

CHECK failure: win_up_Q14 == 1 << 14 in normal.cc

Project Member Reported by ClusterFuzz, Apr 12 2017

Issue description

Cc: msrchandra@chromium.org so...@wire.com
Components: Blink>WebRTC
Labels: Test-Predator-Correct-CLs M-59
Assigning to the concern owner from Predator results --
The result is a list of CLs that change the crashed files. 

Author: soren
Project: chromium-webrtc
Changelist: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+/03f9aed645a992711dc4f4b56daf855718d55dd9
Time: Mon Apr 10 09:22:46 2017
Lines 148-151 of file normal.cc which potentially caused crash are changed in this cl (frame #8, "webrtc::Normal::Process").
Minimum distance from crash line to modified line: 0. (file: normal.cc, crashed on: 148, modified: 148).

@soren -- Could you please look into the issue, kindly re-assign if this is not related to your changes.
Thank You.

Comment 2 by guidou@chromium.org, Apr 13 2017

Components: -Blink>WebRTC Internals>WebRTC
Owner: hlundin@chromium.org
Status: Assigned (was: Untriaged)
hlundin@: can you take a look or reassign to a better owner?

Comment 3 by so...@wire.com, Apr 19 2017

I have made a correction in a new patch https://codereview.webrtc.org/2814363002/
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/0f109beb3830e1dd690dcf13fcfbcd5327af24f6

commit 0f109beb3830e1dd690dcf13fcfbcd5327af24f6
Author: soren <soren@wire.com>
Date: Mon Apr 24 07:22:05 2017

Fixing check for when overlap-add is not 1 ms

BUG= chromium:710812 

Review-Url: https://codereview.webrtc.org/2814363002
Cr-Commit-Position: refs/heads/master@{#17835}

[modify] https://crrev.com/0f109beb3830e1dd690dcf13fcfbcd5327af24f6/webrtc/modules/audio_coding/neteq/normal.cc

Project Member

Comment 5 by ClusterFuzz, Apr 25 2017

ClusterFuzz has detected this issue as fixed in range 465929:466779.

Detailed report: https://clusterfuzz.com/testcase?key=5750308270768128

Fuzzer: libfuzzer_neteq_rtp_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  win_up_Q14 == 1 << 14 in normal.cc
  rtc::FatalMessage::~FatalMessage
  webrtc::Normal::Process
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=463568:463590
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=465929:466779

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5750308270768128


See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 6 by ClusterFuzz, Apr 25 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5750308270768128 is verified as fixed, so closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Components: Blink>WebRTC>Audio
Labels: -M-59 M-60
The bug was introduced in M59, but the fix is in M60. Changing milestone label to reflect this.
Labels: Merge-Request-59
Project Member

Comment 9 by sheriffbot@chromium.org, Apr 25 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved Merge-Approved-59
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 10 by bugdroid1@chromium.org, Apr 25 2017

Labels: merge-merged-59
The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/02ba69db6e2cc96b4c677425a2c0e070261207b7

commit 02ba69db6e2cc96b4c677425a2c0e070261207b7
Author: Henrik Lundin <henrik.lundin@webrtc.org>
Date: Tue Apr 25 08:20:32 2017

[MERGE TO M59] Fixing check for when overlap-add is not 1 ms

BUG= chromium:710812 

Review-Url: https://codereview.webrtc.org/2814363002
Cr-Commit-Position: refs/heads/master@{#17835}
(cherry picked from commit 0f109beb3830e1dd690dcf13fcfbcd5327af24f6)

Review-Url: https://codereview.webrtc.org/2835423002 .
Cr-Commit-Position: refs/branch-heads/59@{#6}
Cr-Branched-From: 10d095d4f743bc16f8e486e156c48a6d023b32c5-refs/heads/master@{#17657}

[modify] https://crrev.com/02ba69db6e2cc96b4c677425a2c0e070261207b7/webrtc/modules/audio_coding/neteq/normal.cc

Project Member

Comment 11 by sheriffbot@chromium.org, Apr 28 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 12 by sheriffbot@chromium.org, May 1 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Approved-59

Sign in to add a comment