New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 710807 link

Starred by 1 user
Status: WontFix
Owner:
█ tsergeant@chromium.org
Not on Chrome
Closed: Sep 2017
Cc:
nyerramilli@chromium.org
dbeam@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug-Regression



Sign in to add a comment

Polymer buttons cannot be pressed with Alt-Space on Mac

Reported by vku...@etouch.net, Apr 12 2017 
Chrome Version:58.0.3029.68 (Official Build)Revision 045e9746301b648a9456f493e68e863059107f88-refs/branch-heads/3029@{#673} (64-bit)
OS:Mac OS X(10.11.6,10.12.1),Linux (14.04 LTS),


What steps will reproduce the problem?
(1)Launch chrome open 2-3 webpages and navigate to chrome://history
(2)Press tab key till focus reached visited url,hit spacebar key to select checkbox.
(3)Hit shift+tab till focus reaches cancel button,now press spacebar key + Alt and observe.
(4)Click on 'X' close button and again select checkbox,observe

Actual: Focus remains on cancel button after hitting Spacebar+Alt key from keyboard in chrome://history

Expected: Focus should not be seen on cancel button after hitting Spacebar+Alt key from keyboard in chrome://history

This is a regression issue broken in 'M51' and below is the manual regression range
Good Build: 51.0.2693.2 
Bad Build:  51.0.2695.0 

Note: Issue not seen on Win OS.
Actual.mov
2.1 MB Download

Comment 1 by vku...@etouch.net, Apr 12 2017

Labels: hasbisect
Owner: rdevlin....@chromium.org
Status: Assigned (was: Unconfirmed)
Narrow bisect:
https://chromium.googlesource.com/chromium/src/+log/fe1e90eeacdc473325519df9c556d1cffa5db3a0..d88171b10e74122f7ac1410370dd056314ffc25f?pretty=fuller&n=30

Suspecting: 384091 ?
Kindly help to reassign the issue if it's not related to your change.

Comment 2 by rdevlin....@chromium.org, Apr 12 2017

Owner: tsergeant@chromium.org
This wouldn't be my patch (which was updating a blink test).

Over to tsergeant@ for history triage.

Comment 3 by tsergeant@chromium.org, Apr 13 2017

Cc: dbeam@chromium.org
Labels: -OS-Linux -Pri-1 Pri-3
Summary: Polymer buttons cannot be pressed with Alt-Space on Mac (was: Regression:Focus remains on cancel button after hitting Spacebar+Alt key from keyboard in chrome://history)
Aha, this is a pretty silly bug, but it's hard to trigger, has a minor affect, and is Mac only.

The gist of it is that on Mac, pressing Alt-Spacebar emits a non-breaking space character instead of a regular space character. The browser emits a KeyboardEvent with e.key set to '\u00A0', and e.code set to 'space'. iron-a11y-keys-behavior prefers to match against e.key, and therefore doesn't pick up Alt-Spacebar as a valid press of spacebar (https://github.com/PolymerElements/iron-a11y-keys-behavior/blob/master/iron-a11y-keys-behavior.html#L106).

This affects basically every clickable thing across MD WebUI: They can't be pressed with Alt-Space on Mac, but can be pressed that way on ChromeOS/Linux (and presumably Windows, but I haven't checked).

I'm inclined to mark this as WontFix, but +dbeam in case MD Settings wants to fix this (in iron-a11y-keys)

Comment 4 by tsergeant@chromium.org, Apr 13 2017 

I should also mention that the 'stuck' ripple is the same problem, but it happens when you time your keypresses right so that the keydown is a valid space press, but your keyup is not.

Comment 5 by tsergeant@chromium.org, Sep 8 2017

Status: WontFix (was: Assigned)
As above, I think this is WontFix from Chrome's perspective.

If we wanted to fix it, it would need to be changed in iron-a11y-keys. But from their perspective, this could almost be WAI, since technically, you're not pressing 'space' when you press Alt-Space on a Mac.
►

Sign in to add a comment