Issue metadata
Sign in to add a comment
|
depot_tools presubmit input_api does not recognize BUG: |
||||||||||||||||||||||
Issue descriptionThe api has a field: input_api.change.BUG If a commit message has a line "BUG=" it contains the entry. If it uses "BUG:", the field is None. This breaks V8's bug entry checker: https://cs.chromium.org/chromium/src/v8/PRESUBMIT.py?q=v8/PRE+package:%5Echromium$&l=301 And lets wrongly formatted entries slip in like: https://chromium-review.googlesource.com/c/475651/
,
Apr 15 2017
,
Apr 25 2017
,
May 15 2017
https://chromium-review.googlesource.com/c/506450 and https://chromium-review.googlesource.com/c/506551/
,
May 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools/+/fc03e67e9ae41efc4be498ae91f6d6eddc96f1c6 commit fc03e67e9ae41efc4be498ae91f6d6eddc96f1c6 Author: Aaron Gable <agable@chromium.org> Date: Thu May 18 19:02:54 2017 Refactor PRESUBMIT support for tags We want PRESUBMIT to be able to equally support BUG= tags (old style) and Git-Footer: footers (new style). This change refactors the way that the presubmit api gives access to those properties so that it is easier to add support for equivalent footers. It also limits the scope of tags/footers that it exposes, as code search shows no PRESUBMIT files that take advantage of any of the more esoteric ones. Bug: 710327 , 710803 Change-Id: I86f1d6cb2e1f0aff9653ef3fb455e0a6f47acf5d Reviewed-on: https://chromium-review.googlesource.com/506450 Commit-Queue: Aaron Gable <agable@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> [modify] https://crrev.com/fc03e67e9ae41efc4be498ae91f6d6eddc96f1c6/presubmit_canned_checks.py [modify] https://crrev.com/fc03e67e9ae41efc4be498ae91f6d6eddc96f1c6/presubmit_support.py [modify] https://crrev.com/fc03e67e9ae41efc4be498ae91f6d6eddc96f1c6/tests/presubmit_unittest.py
,
May 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools/+/12ef501b02a9ff66323ba2da0432dc6717d5bc89 commit 12ef501b02a9ff66323ba2da0432dc6717d5bc89 Author: Aaron Gable <agable@chromium.org> Date: Fri May 19 16:56:29 2017 Parse Bug, R, and Tbr git-footers in PRESUBMIT This gives PRESUBMIT equal support for all the gerrit-style footers that we're migrating to. R=iannucci@chromium.org, tandrii@chromium.org Bug: 710327 , 710803 Change-Id: I64b8f39ef923d90ebda7dd191b83d1a7cc87c776 Reviewed-on: https://chromium-review.googlesource.com/506551 Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org> [modify] https://crrev.com/12ef501b02a9ff66323ba2da0432dc6717d5bc89/presubmit_support.py [modify] https://crrev.com/12ef501b02a9ff66323ba2da0432dc6717d5bc89/tests/presubmit_unittest.py
,
May 19 2017
It now recognizes Bug:!
,
May 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/af7b55c7766d31028160623cf9e1886ba8c5018e commit af7b55c7766d31028160623cf9e1886ba8c5018e Author: catapult-deps-roller@chromium.org <catapult-deps-roller@chromium.org> Date: Tue May 23 22:42:46 2017 Roll src/third_party/catapult/ 2d3f5e75d..51b31788b (5 commits) https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/2d3f5e75de7c..51b31788b65c $ git log 2d3f5e75d..51b31788b --date=short --no-merges --format='%ad %ae %s' 2017-05-23 rnephew [Telemetry] Enforce story existence for StoryExpectations 2017-05-22 eakuefner [Dashboard] Get or create ancestors in add_histograms_queue 2017-05-22 martiniss Add android-webview apk 2017-05-22 agable Update catapult PRESUBMIT to use newer Bug API 2017-05-19 kainino Telemetry/Windows: add numpy and cv2 binary dependencies Created with: roll-dep src/third_party/catapult BUG= 723783 , 710803 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ifbf4ce69c70f6ecea981ef8b7a5a43497f888cdf Reviewed-on: https://chromium-review.googlesource.com/513010 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#474089} [modify] https://crrev.com/af7b55c7766d31028160623cf9e1886ba8c5018e/DEPS |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by tandrii@chromium.org
, Apr 13 2017