Regression : Chopped numbers are seen in expiration date for Auto-fill settings |
||||||||||||||
Issue descriptionUserAgent: 59.0.3069.0 Dev OS:Windows Steps to reproduce the problem: 1. Launch chrome and navigate to chrome://md-settings 2. Change the font size to Very Large and navigate to Auto-fill Settings. 3. Click on Add Button beside credit cards and Observe near expiration date(kindly refer screen shots). What is the expected behavior? Numbers in Date dropdown should not be chopped. What went wrong? Numbers in Date dropdown is seen chopped. Did this work before? Yes Chrome version: 59.0.3069.0 Channel: dev OS Version: Flash Version: This is a regression issue broken in M-59. Manual Bisect info: =================== Good Build:59.0.3068.1 Bad Build:59.0.3069.0 will soon update linux behaviour.
,
Apr 12 2017
,
Apr 12 2017
Able to reproduce the issue on the latest canary(59.0.3069.0) on Mac OS 10.12.3 as well. Marking this as Stable blocker as this is recent regression.
,
Apr 12 2017
Using the per-revision bisect providing the bisect results, Good build:59.0.3068.1 (Revision:463474). Bad build:59.0.3069.0 (Revision:463921). You are probably looking for a change made after 463882 (known good), but no later than 463883 (first known bad). CHANGE-LOG URL: --------------- https://chromium.googlesource.com/chromium/src/+log/9393d3ecae1347c86f34274aba874adc864845f2..32ea48de49d9ad146142956362b8b2d4a6234d75 From the CL above, assigning the issue to the concern owner @dpapad: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner. Review-Url:https://codereview.chromium.org/2814813002 Note :Able to reproduce the issue in Win 10.0,Ubuntu 14.04(59.0.3069.4) & Mac 10.12.3 and Able to reproduce in latest Canary #59.0.3069.0
,
Apr 12 2017
,
Apr 12 2017
,
Apr 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0d4361cef2ed487f1a627ccd5a4047c8cbd899e8 commit 0d4361cef2ed487f1a627ccd5a4047c8cbd899e8 Author: dpapad <dpapad@chromium.org> Date: Wed Apr 12 20:49:45 2017 MD Settings: Fix alignment issues after adding left/right padding to md-select. Also restoring "visual" default width of 200px. BUG= 710785 , 710802 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2815113002 Cr-Commit-Position: refs/heads/master@{#464144} [modify] https://crrev.com/0d4361cef2ed487f1a627ccd5a4047c8cbd899e8/ui/webui/resources/html/md_select_css.html
,
Apr 12 2017
,
Apr 18 2017
Able to repro the issue in latest M-59(59.0.3071.9) and M-60(60.0.3074.0). Attached screen cast for reference and re-assigning the issue. @dpapad: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.
,
Apr 19 2017
Confirmed that I can still repro this with Very Large fonts on a CrOS device (pixel).
,
Apr 19 2017
Note: This issue goes away if we forgo the custom arrow image. FWIW I think that a blank background with the default arrow image would be fine and much easier to support / maintain.
,
Apr 19 2017
,
Apr 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/25e4011a30bc7e0cbb2912ea1fe47defefa606f8 commit 25e4011a30bc7e0cbb2912ea1fe47defefa606f8 Author: dpapad <dpapad@chromium.org> Date: Wed Apr 19 23:04:02 2017 WebUI: Fix calculation of md-select text and arrow spacing. Previous calculation was not properly taking into account the position of the arrow. New calculation ensures that there is always some white space between the arrow and the text. BUG= 693698 , 710802 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2825403003 Cr-Commit-Position: refs/heads/master@{#465800} [modify] https://crrev.com/25e4011a30bc7e0cbb2912ea1fe47defefa606f8/ui/webui/resources/html/md_select_css.html
,
Apr 19 2017
,
Apr 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6eb1222c5a221fc570b5a2cee9e418c496a3b55a commit 6eb1222c5a221fc570b5a2cee9e418c496a3b55a Author: Lei Zhang <thestig@chromium.org> Date: Fri Apr 21 23:57:08 2017 M59: WebUI: Fix calculation of md-select text and arrow spacing. Previous calculation was not properly taking into account the position of the arrow. New calculation ensures that there is always some white space between the arrow and the text. BUG= 693698 , 710802 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2825403003 Cr-Commit-Position: refs/heads/master@{#465800} (cherry picked from commit 25e4011a30bc7e0cbb2912ea1fe47defefa606f8) Review-Url: https://codereview.chromium.org/2836763002 . Cr-Commit-Position: refs/branch-heads/3071@{#138} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} [modify] https://crrev.com/6eb1222c5a221fc570b5a2cee9e418c496a3b55a/ui/webui/resources/html/md_select_css.html
,
Apr 25 2017
Verified this issue on Windows-10, Mac 10.12.4 and Ubuntu 14.04 using chrome latest Dev #59.0.3071.25 by following steps mentioned in the original comment Numbers in Date dropdown is looking good now. Please find the screen cast
,
May 9 2017
Verified on ChromeOS 9460.30.0, 59.0.3071.41 |
||||||||||||||
►
Sign in to add a comment |
||||||||||||||
Comment 1 by sahitya....@techmahindra.com
, Apr 12 2017