New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 710781 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Not on Chrome
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Remove obsolete function chrome.bookmarkManagerPrivate.canOpenNewWindows

Project Member Reported by tsergeant@chromium.org, Apr 12 2017

Issue description

This function is obsolete following the removal of Windows 8 Metro mode, and can be safely removed.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f9e10d18a42268051f35d98c4ed5eb19597fa0c

commit 5f9e10d18a42268051f35d98c4ed5eb19597fa0c
Author: tsergeant <tsergeant@chromium.org>
Date: Tue Apr 18 04:43:35 2017

Remove obsolete bookmarkManagerPrivate.canOpenNewWindows API function

The extension API function
chrome.bookmarkManagerPrivate.canOpenNewWindows was previously used to
disable opening new windows in Windows 8 Metro Mode. Now that mode is
removed, the function is  essentially a no-op, as it always returns
true. Additionally, it is only used by one place in the bookmark
manager. This CL removes this obsolete function.

BUG= 710781 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2815813002
Cr-Commit-Position: refs/heads/master@{#465140}

[modify] https://crrev.com/5f9e10d18a42268051f35d98c4ed5eb19597fa0c/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc
[modify] https://crrev.com/5f9e10d18a42268051f35d98c4ed5eb19597fa0c/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.h
[modify] https://crrev.com/5f9e10d18a42268051f35d98c4ed5eb19597fa0c/chrome/browser/resources/bookmark_manager/js/main.js
[modify] https://crrev.com/5f9e10d18a42268051f35d98c4ed5eb19597fa0c/chrome/common/extensions/api/bookmark_manager_private.json
[modify] https://crrev.com/5f9e10d18a42268051f35d98c4ed5eb19597fa0c/extensions/browser/extension_function_histogram_value.h
[modify] https://crrev.com/5f9e10d18a42268051f35d98c4ed5eb19597fa0c/third_party/closure_compiler/externs/bookmark_manager_private.js
[modify] https://crrev.com/5f9e10d18a42268051f35d98c4ed5eb19597fa0c/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Started)

Sign in to add a comment