Issue 710778 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	shend@chromium.org
Closed:	Apr 2017
Cc:	█ meade@chromium.org █ bugsnash@chromium.org style-bugs@google.com
Components:	Blink>CSS
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	2
Type:	----

Compilation broke due to 'core/CSSValueIDMappingsGenerated.h' file not found

Project Member Reported by jdoerrie@chromium.org, Apr 12 2017

Issue description

compile failing on 2 builders

Builders failed on: 
- Google Chrome ChromeOS: 
  https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20ChromeOS
- Google Chrome Mac: 
  https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Mac

Compilation broke due to 'core/CSSValueIDMappingsGenerated.h' file not found

Multiple bots were failing to compile with the following error:

In file included from ../../third_party/WebKit/Source/core/animation/CSSFontWeightInterpolationType.cpp:9:
In file included from ../../third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h:36:
In file included from ../../third_party/WebKit/Source/core/css/CSSIdentifierValue.h:10:
../../third_party/WebKit/Source/core/css/CSSValueIDMappings.h:8:10: fatal error: 'core/CSSValueIDMappingsGenerated.h' file not found
#include "core/CSSValueIDMappingsGenerated.h"

Please see the attached logs for more details.

I reverted r463955 in the meantime, thinking this is a likely culprit. shend@, do you mind taking another look?


Builders failed on: 
- Google Chrome ChromeOS: 
  https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20ChromeOS
- Google Chrome Mac: 
  https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Mac

ChromeOS.log
2.2 MB View Download

Chrome_Mac.log
1.8 MB View Download

Project Member

Comment 1 by bugdroid1@chromium.org, Apr 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b7de53bdbe24c3d8088d23862abdd35de67f711

commit 2b7de53bdbe24c3d8088d23862abdd35de67f711
Author: jdoerrie <jdoerrie@chromium.org>
Date: Wed Apr 12 08:40:29 2017

Revert of Separate CSSValueID mappings generator from ComputedStyleBase generator. (patchset #3 id:40001 of https://codereview.chromium.org/2794853002/ )

Reason for revert:
Broke compilation on Google Chrome Mac bot

BUG= 710778 

Original issue's description:
> Separate CSSValueID mappings generator from ComputedStyleBase generator.
>
> We currently generate mappings between CSSValueID and platform enums
> inside the ComputedStyleBase generator. However, because such mappings
> do not exist for nonproperty fields, it no longer makes sense for us
> to generate these mappings inside make_computed_style_base.py.
>
> This patch moves the generator for CSSValueIDMappingsGenerated to
> its own file, so that it is not affected by nonproperty fields.
>
> BUG= 628043 
>
> Review-Url: https://codereview.chromium.org/2794853002
> Cr-Commit-Position: refs/heads/master@{#463955}
> Committed: https://chromium.googlesource.com/chromium/src/+/dea75f9603af994dd10370ddd25a0dc6af7b93cd

TBR=bugsnash@chromium.org,meade@chromium.org,shend@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 628043 

Review-Url: https://codereview.chromium.org/2812823004
Cr-Commit-Position: refs/heads/master@{#463966}

[modify] https://crrev.com/2b7de53bdbe24c3d8088d23862abdd35de67f711/third_party/WebKit/Source/build/scripts/make_computed_style_base.py
[delete] https://crrev.com/2122b4d005c760e6acef72c241c3d91821140dbf/third_party/WebKit/Source/build/scripts/make_css_value_id_mappings.py
[modify] https://crrev.com/2b7de53bdbe24c3d8088d23862abdd35de67f711/third_party/WebKit/Source/core/BUILD.gn