views_unittests failing on chromium.memory/Linux Chromium OS ASan LSan Tests |
||
Issue descriptionviews_unittests failing on chromium.memory/Linux Chromium OS ASan LSan Tests http://crrev.com/2796303006 introduced ui/views/controls/resize_area_unittest.cc which causes LSan bots to fail due to leaking memory. Relevant Log Snippet: ==25158==ERROR: LeakSanitizer: detected memory leaks Direct leak of 16 byte(s) in 1 object(s) allocated from: #0 0x5a8dd2 in operator new(unsigned long) (/b/s/w/ir/out/Release/views_unittests+0x5a8dd2) #1 0x91d1c2 in views::ResizeAreaTest::SetUp() ui/views/controls/resize_area_unittest.cc:118:15 Builders failed on: - Linux Chromium OS ASan LSan Tests (1): https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29
,
Apr 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2208246074066280fc34229503599484b8ebdb7e commit 2208246074066280fc34229503599484b8ebdb7e Author: jdoerrie <jdoerrie@chromium.org> Date: Wed Apr 12 11:33:09 2017 Revert of Add gesture support in views::ResizeArea (patchset #5 id:60001 of https://codereview.chromium.org/2796303006/ ) Reason for revert: Reverting due to consistent failure on Linux Chromium OS ASan LSan Tests: https://luci-milo.appspot.com/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/ delegate_ = new TestResizeAreaDelegate; in ui/views/controls/resize_area_unittest.cc:118 is the likely culprit. BUG= 710771 Original issue's description: > Add gesture support in views::ResizeArea > > Add gesture (touch) support in views::ResizeArea, which > is used for resizing the location bar. This area is located > directly to the right of the location bar. > > BUG= 320544 > TEST=manual > > Review-Url: https://codereview.chromium.org/2796303006 > Cr-Commit-Position: refs/heads/master@{#463733} > Committed: https://chromium.googlesource.com/chromium/src/+/6db93d5b7ac95549bea2a1ec2d82cf6c1e8ed58d TBR=sadrul@chromium.org,tdanderson@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 320544 Review-Url: https://codereview.chromium.org/2811143004 Cr-Commit-Position: refs/heads/master@{#463993} [modify] https://crrev.com/2208246074066280fc34229503599484b8ebdb7e/ui/views/BUILD.gn [modify] https://crrev.com/2208246074066280fc34229503599484b8ebdb7e/ui/views/controls/resize_area.cc [modify] https://crrev.com/2208246074066280fc34229503599484b8ebdb7e/ui/views/controls/resize_area.h [modify] https://crrev.com/2208246074066280fc34229503599484b8ebdb7e/ui/views/controls/resize_area_delegate.h [delete] https://crrev.com/ffc655c99fef91f49ad7906344d51678c3853b74/ui/views/controls/resize_area_unittest.cc
,
Jun 21 2017
Addressed by the re-land of the issue cited in #2. |
||
►
Sign in to add a comment |
||
Comment 1 by jdoerrie@chromium.org
, Apr 12 2017