Google Chrome ChromeOS compilation flakes with //net:features dependency |
|||||
Issue descriptionThe bot: https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20ChromeOS Sample failing build: https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20ChromeOS/builds/32184 (stdout attached) The relevant part is: In file included from ../../extensions/browser/api/networking_private/networking_private_event_router_chromeos.cc:16: In file included from ../../chromeos/network/portal_detector/network_portal_detector.h:11: In file included from ../../net/url_request/url_fetcher.h:19: In file included from ../../net/url_request/url_request.h:26: In file included from ../../net/base/net_error_details.h:9: In file included from ../../net/http/http_response_info.h:14: In file included from ../../net/ssl/ssl_info.h:20: In file included from ../../net/ssl/ssl_config.h:12: ../../net/cert/x509_certificate.h:22:10: fatal error: 'net/net_features.h' file not found #include "net/net_features.h" ^~~~~~~~~~~~~~~~~~~~ All the instances I saw were in extensions/browser/api/networking_private, where some .cc file included stuff through //chromeos:chromeos without depending on it in BUILD.gn. This is fairly urgent, because it closes the tree repeatedly.
,
Apr 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9728f347af4ee2c9d1778ef3813193fa02790d8d commit 9728f347af4ee2c9d1778ef3813193fa02790d8d Author: vabr <vabr@chromium.org> Date: Wed Apr 12 07:27:27 2017 Add //chromeos dependency in //extensions/browser/api/networking_private A couple of *chromeos* files in networking_private include headers from //chromeos/network, but do not declare their target as dependency. This might be causing compile flakes described on the bug. BUG= 710757 TBR=finnur@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2810913008 Cr-Commit-Position: refs/heads/master@{#463940} [modify] https://crrev.com/9728f347af4ee2c9d1778ef3813193fa02790d8d/extensions/browser/api/networking_private/BUILD.gn
,
Apr 12 2017
The bot (https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20ChromeOS) so far has no compilation errors after r463940 ended, so I'm closing as fixed. I will observe to bot for some time. If the compile issues return, please feel free to reopen this.
,
Apr 12 2017
About 10 builds passed on the bot since r463940 and neither of them failed because of the compile error described here (there was another compile failure, but unrelated and with clear culprit which was reverted). So I'm observing no more. Still, if issues resurface, please feel free to reopen.
,
May 30 2017
,
Aug 1 2017
,
Jan 22 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by vabr@chromium.org
, Apr 12 2017