New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 710756 link

Starred by 1 user
Status: Fixed
Owner:
█ ortuno@chromium.org
Last visit > 30 days ago
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Bug

Blocking:
issue 580406



Sign in to add a comment

bluetooth: Distinguish between LowEnergy not supported and LowEnergy available.

Project Member Reported by ortuno@chromium.org, Apr 12 2017 
Context:
IsBluetoothAdapterAvailable is a misnomer as it doesn't actually indicate if there is a
Bluetooth radio present in the device. Rather it returns whether or not the platform supports Bluetooth.

Similarly IsLowEnergyAvailable just indicates if the platform supports Bluetooth and not if there is a Bluetooth LE radio present on the device.

We should rename these two functions to better reflect their functionality.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/57ed4544b704badc3e547fc87b06b4ddcabe2869

commit 57ed4544b704badc3e547fc87b06b4ddcabe2869
Author: ortuno <ortuno@chromium.org>
Date: Thu Apr 20 01:16:28 2017

bluetooth: Rename Is*Available to Is*Supported

IsBluetoothAdapterAvailable is a misnomer. It actually returns whether
or not the platform supports Bluetooth regardless of the presence
of an actual Bluetooth radio or adapter.

Similarly IsLowEnergyAvaiable returns whether the platform supports
Low Energy.

Renames IsBluetoothAdapterAvailable and IsLowEnergyAvailable to
IsBluetoothSupported and IsLowEnergySupported

BUG= 710756 

Review-Url: https://codereview.chromium.org/2808353004
Cr-Commit-Position: refs/heads/master@{#465844}

[modify] https://crrev.com/57ed4544b704badc3e547fc87b06b4ddcabe2869/chrome/browser/chromeos/arc/intent_helper/arc_settings_service.cc
[modify] https://crrev.com/57ed4544b704badc3e547fc87b06b4ddcabe2869/chrome/browser/signin/easy_unlock_service.cc
[modify] https://crrev.com/57ed4544b704badc3e547fc87b06b4ddcabe2869/chromeos/components/tether/initializer.cc
[modify] https://crrev.com/57ed4544b704badc3e547fc87b06b4ddcabe2869/components/arc/bluetooth/arc_bluetooth_bridge.cc
[modify] https://crrev.com/57ed4544b704badc3e547fc87b06b4ddcabe2869/components/pairing/bluetooth_controller_pairing_controller.cc
[modify] https://crrev.com/57ed4544b704badc3e547fc87b06b4ddcabe2869/components/pairing/bluetooth_host_pairing_controller.cc
[modify] https://crrev.com/57ed4544b704badc3e547fc87b06b4ddcabe2869/components/proximity_auth/ble/bluetooth_low_energy_connection_finder.cc
[modify] https://crrev.com/57ed4544b704badc3e547fc87b06b4ddcabe2869/components/proximity_auth/bluetooth_connection.cc
[modify] https://crrev.com/57ed4544b704badc3e547fc87b06b4ddcabe2869/components/proximity_auth/bluetooth_connection_finder.cc
[modify] https://crrev.com/57ed4544b704badc3e547fc87b06b4ddcabe2869/components/proximity_auth/bluetooth_connection_finder_unittest.cc
[modify] https://crrev.com/57ed4544b704badc3e547fc87b06b4ddcabe2869/components/proximity_auth/bluetooth_connection_unittest.cc
[modify] https://crrev.com/57ed4544b704badc3e547fc87b06b4ddcabe2869/components/proximity_auth/proximity_monitor_impl.cc
[modify] https://crrev.com/57ed4544b704badc3e547fc87b06b4ddcabe2869/components/proximity_auth/unlock_manager_impl.cc
[modify] https://crrev.com/57ed4544b704badc3e547fc87b06b4ddcabe2869/content/browser/bluetooth/web_bluetooth_service_impl.cc
[modify] https://crrev.com/57ed4544b704badc3e547fc87b06b4ddcabe2869/device/bluetooth/adapter_factory.cc
[modify] https://crrev.com/57ed4544b704badc3e547fc87b06b4ddcabe2869/device/bluetooth/bluetooth_adapter_factory.cc
[modify] https://crrev.com/57ed4544b704badc3e547fc87b06b4ddcabe2869/device/bluetooth/bluetooth_adapter_factory.h
[modify] https://crrev.com/57ed4544b704badc3e547fc87b06b4ddcabe2869/device/bluetooth/bluetooth_adapter_factory_wrapper.cc
[modify] https://crrev.com/57ed4544b704badc3e547fc87b06b4ddcabe2869/device/bluetooth/bluetooth_adapter_factory_wrapper.h
[modify] https://crrev.com/57ed4544b704badc3e547fc87b06b4ddcabe2869/extensions/browser/api/bluetooth/bluetooth_event_router.cc
[modify] https://crrev.com/57ed4544b704badc3e547fc87b06b4ddcabe2869/extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy_event_router.cc

Comment 2 by ortuno@chromium.org, Apr 20 2017

Status: Fixed (was: Started)
►

Sign in to add a comment