Issue 710738 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	horo@chromium.org
Closed:	Apr 2017
Components:	Blink>ServiceWorker Platform>DevTools>Network
EstimatedDays:	----
NextAction:	----
OS:	Linux , Android , Chrome , Mac
Pri:	3
Type:	Bug
M-59

The status string "(failed) Navigation Preload Error" in DevTools network tab is anbiguous

Project Member Reported by horo@chromium.org, Apr 12 2017

Issue description

When the service worker navigation preload request failed, NetworkHandler::NavigationPreloadCompleted() just sends "Navigation Preload Error" message to DevTools.

https://chromium.googlesource.com/chromium/src/+/8354e8c5a28b56b46e05dd85a1dbc14a1d064269/content/browser/devtools/protocol/network_handler.cc#698

This is displayed in the DevTools Network tab. (current.png)

But for other type of resource errors, we can see more detailed error like "(failed) net::ERR_CONNECTION_REFUSED".
This string is generated in CreateWebURLError().

https://chromium.googlesource.com/chromium/src/+/8354e8c5a28b56b46e05dd85a1dbc14a1d064269/content/child/web_url_request_util.cc#517

We should provide the detailed error info. (expected.png)

	current.png 60.0 KB View Download

	expected.png 60.1 KB View Download

Project Member

Comment 1 by bugdroid1@chromium.org, Apr 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec2f0c7a07f26bb15dbf42c94153c370eccdbfe3

commit ec2f0c7a07f26bb15dbf42c94153c370eccdbfe3
Author: horo <horo@chromium.org>
Date: Thu Apr 13 23:15:39 2017

Show more detailed error info of navigation preload in DevTools Network tab

See  https://crbug.com/710738  for the screen images.

BUG= 710738 

Review-Url: https://codereview.chromium.org/2809353002
Cr-Commit-Position: refs/heads/master@{#464599}

[modify] https://crrev.com/ec2f0c7a07f26bb15dbf42c94153c370eccdbfe3/content/browser/devtools/protocol/network_handler.cc
[modify] https://crrev.com/ec2f0c7a07f26bb15dbf42c94153c370eccdbfe3/third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/service-workers-navigation-preload-expected.txt

Comment 2 by horo@chromium.org, Apr 18 2017

Labels: M-59
Status: Fixed (was: Started)

$ git find-releases ec2f0c7a07f26bb15dbf42c94153c370eccdbfe3
commit ec2f0c7a07f26bb15dbf42c94153c370eccdbfe3 was:
  initially in 59.0.3071.0

►

Issue 710738 link

Issue metadata

The status string "(failed) Navigation Preload Error" in DevTools network tab is anbiguous

Issue description

Comment 1 by bugdroid1@chromium.org, Apr 13 2017

Comment 1 Deleted

Comment 2 by horo@chromium.org, Apr 18 2017

Comment 2 Deleted

Sign in to add a comment