conditional support ( @supports test ) testing of 'caption-side: left' is incorrect
Reported by
goo...@gtalbot.org,
Apr 12 2017
|
|||||||
Issue descriptionUserAgent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0 Example URL: http://www.gtalbot.org/BrowserBugsSection/CSS3ConditionalRules/supports-caption-side-left.html Steps to reproduce the problem: Load self-explanatory test. Chrome (all versions) does *not* support 'caption-side: left'. What is the expected behavior? Since Chrome does not support 'caption-side: left', then Chrome, in that test page, should display "DOES NOT SUPPORT" in red. What went wrong? Chrome, in that test page, displays "SUPPORTS" in green. But again, this is not true: Chrome (all versions) does *not* support 'caption-side: left'. Does it occur on multiple sites: N/A Is it a problem with a plugin? No Did this work before? No Does this work in other browsers? Yes Chrome version: 59.0.3067.0 Channel: dev OS Version: Flash Version: irrelevant Thread starts here: http://lists.w3.org/Archives/Public/www-style/2017Apr/0021.html 2 people, besides me, believe that Chrome has a bug. - - - - - - - - " The ‘@supports’ rule is a conditional group rule whose condition tests whether the user agent supports CSS property:value pairs. Authors can use it to write style sheets that use new features when available but degrade gracefully when those features are not supported. (...) " https://www.w3.org/TR/css3-conditional/#at-supports Therefore, a supported property with an unsupported value must cause the @supports condition to fail. - - - - - - - The test discloses the user agent string (thanks to a small inline script) so that I can use the test page for browsers in browser shot service sites.
,
Apr 17 2017
Able to reproduce the issue on Linux Ubuntu 14.04,Mac 10.12.4 & Windows 7 using chrome reported version-59.0.3067.0 ,stable-57.0.2987.133 & Canary-60.0.3072.0 as per the URL mentioned in comment#0. In Chrome test page ,it displayed as "SUPPORTS" in green when user navigate to below URL. http://www.gtalbot.org/BrowserBugsSection/CSS3ConditionalRules/supports-caption-side-left.html This is non-regression issue observed from M30.Hence marking it as 'Untriaged' & confirming this issue to get more inputs from dev. Please find the attached screencast for reference. Thanks!!
,
Apr 17 2017
So the thing is that we parse all four values of caption-side, yet we only check against bottom in layout[1]. I don't think there's a particular reason we're parsing all the values? [1]: https://cs.chromium.org/search/?q=CaptionSide+package:%5Echromium$&type=cs
,
Apr 18 2017
While this does appear to be a bug in Chrome, according to https://developer.mozilla.org/en-US/docs/Web/CSS/caption-side Edge also does not support 'caption-side', but testing the provided test in Edge also says 'Supports'.
,
Apr 18 2017
,
Apr 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4af5b86049ac7e3b8fb3db9b5cb9383386dd7bbe commit 4af5b86049ac7e3b8fb3db9b5cb9383386dd7bbe Author: ecobos <ecobos@igalia.com> Date: Tue Apr 18 07:39:21 2017 Do not parse caption-side: left / right as valid CSS. We don't support it, and it's confusing to claim we do. BUG= 710734 Review-Url: https://codereview.chromium.org/2821073002 Cr-Commit-Position: refs/heads/master@{#465173} [modify] https://crrev.com/4af5b86049ac7e3b8fb3db9b5cb9383386dd7bbe/third_party/WebKit/LayoutTests/fast/css/invalidation/independent-inheritance-fast-path-expected.txt [modify] https://crrev.com/4af5b86049ac7e3b8fb3db9b5cb9383386dd7bbe/third_party/WebKit/LayoutTests/fast/css/invalidation/independent-inheritance-fast-path.html [modify] https://crrev.com/4af5b86049ac7e3b8fb3db9b5cb9383386dd7bbe/third_party/WebKit/Source/core/css/CSSProperties.json5 [modify] https://crrev.com/4af5b86049ac7e3b8fb3db9b5cb9383386dd7bbe/third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.cpp
,
Apr 21 2017
Could this be set to fixed now?
,
Apr 21 2017
Yes, thanks rune. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by ranjitkan@chromium.org
, Apr 12 2017