Issue metadata
Sign in to add a comment
|
git cl upload seems to take much longer with gerrit |
||||||||||||||||||||||
Issue descriptionI haven't done a thorough analysis of this really, but the delay between answering the "Title for patchset" prompt and getting any kind of meaningful response seems to be significantly higher than with rietveld.
,
May 11 2017
Issue 720932 has been merged into this issue.
,
May 11 2017
Mine (duped above) was a tiny CL, and it hung for >1min at "Processing changes"
,
May 11 2017
Hey gerrit folks, we've gotten multiple reports of push to refs/for/* being super slow. (This bug, the one duped into it, an email thread, and I experienced a >1min hang during "Processing changes" myself earlier today.) Can we get an investigation into long push times and see if we can figure out what's going on?
,
May 11 2017
Please file a bug internally for the backend team.
,
May 12 2017
Can confirm this has happened to me also. A few times it takes so long I figure it's busted and then retry and I end up with the same CL getting uploaded many times. E.g. https://canary-chromium-review.googlesource.com/c/499013/ https://canary-chromium-review.googlesource.com/c/498793/ https://canary-chromium-review.googlesource.com/c/498539/ and https://canary-chromium-review.googlesource.com/c/497168/ https://canary-chromium-review.googlesource.com/c/498107/ https://canary-chromium-review.googlesource.com/c/497969/ https://canary-chromium-review.googlesource.com/c/498048/ and I usually just end up resorting to `git push origin HEAD:refs/for/master` directly after a few attempts
,
May 15 2017
As mentioned on the Gerrit for Chromium announcement thread: Could it be that it is not really the upload that's slow but the hook-script excution? Are the uploads still slow when you use --bypass-hooks?
,
May 15 2017
mbjoge@ it seems that's indeed not initial push that takes time, but setting of reviewers and cc-s and/or post-upload hooks. Whoever is also experiencing this bug, please do repro it with "-v -v" and then let us know the output: $ git cl upload <your flags> -v -v This should produce logging with timestamps before most operations.
,
May 18 2017
,
May 18 2017
We have exact (albeit local) timestamps for a push that took 36 seconds for a small two-file CL: [D2017-05-17 12:39:50,253 13133 140164720273216 subprocess2.py] git push <snip> [D2017-05-17 12:40:26,228 13133 140164720273216 subprocess2.py] Filed internal bug here: https://b.corp.google.com/issues/38422330
,
May 19 2017
,
Jun 21 2017
The internal tracking bug for this has been fixed. We expect to see much faster uploads and edits as soon as that change is deployed everywhere. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by andyb...@chromium.org
, Apr 12 2017Owner: aga...@chromium.org
Status: Assigned (was: Unconfirmed)