New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 710722 link

Starred by 9 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----



Sign in to add a comment

git cl upload seems to take much longer with gerrit

Project Member Reported by roc...@chromium.org, Apr 12 2017

Issue description

I haven't done a thorough analysis of this really, but the delay between answering the "Title for patchset" prompt and getting any kind of meaningful response seems to be significantly higher than with rietveld.
 
Cc: tandrii@chromium.org
Owner: aga...@chromium.org
Status: Assigned (was: Unconfirmed)

Comment 2 by aga...@chromium.org, May 11 2017

 Issue 720932  has been merged into this issue.
Cc: scottmg@chromium.org
Mine (duped above) was a tiny CL, and it hung for >1min at "Processing changes"

Comment 4 by aga...@chromium.org, May 11 2017

Cc: logan@google.com dborowitz@google.com
Owner: sop@google.com
Hey gerrit folks, we've gotten multiple reports of push to refs/for/* being super slow. (This bug, the one duped into it, an email thread, and I experienced a >1min hang during "Processing changes" myself earlier today.)

Can we get an investigation into long push times and see if we can figure out what's going on?
Please file a bug internally for the backend team.
Can confirm this has happened to me also. A few times it takes so long I figure it's busted and then retry and I end up with the same CL getting uploaded many times.

E.g.
https://canary-chromium-review.googlesource.com/c/499013/
https://canary-chromium-review.googlesource.com/c/498793/
https://canary-chromium-review.googlesource.com/c/498539/

and
https://canary-chromium-review.googlesource.com/c/497168/
https://canary-chromium-review.googlesource.com/c/498107/
https://canary-chromium-review.googlesource.com/c/497969/
https://canary-chromium-review.googlesource.com/c/498048/

and I usually just end up resorting to `git push origin HEAD:refs/for/master` directly after a few attempts

Comment 7 by drott@chromium.org, May 15 2017

As mentioned on the Gerrit for Chromium announcement thread: Could it be that it is not really the upload that's slow but the hook-script excution? Are the uploads still slow when you use --bypass-hooks?

mbjoge@ it seems that's indeed not initial push that takes time, but setting of reviewers and cc-s and/or post-upload hooks.

Whoever is also experiencing this bug, please do repro it with "-v -v" and then let us know the output:
$ git cl upload <your flags> -v -v 

This should produce logging with timestamps before most operations.

Comment 9 by aga...@chromium.org, May 18 2017

Cc: sop@google.com
 Issue 723801  has been merged into this issue.
We have exact (albeit local) timestamps for a push that took 36 seconds for a small two-file CL:

[D2017-05-17 12:39:50,253 13133 140164720273216 subprocess2.py] git push
<snip>
[D2017-05-17 12:40:26,228 13133 140164720273216 subprocess2.py]

Filed internal bug here: https://b.corp.google.com/issues/38422330
Status: ExternalDependency (was: Assigned)
Status: Fixed (was: ExternalDependency)
The internal tracking bug for this has been fixed. We expect to see much faster uploads and edits as soon as that change is deployed everywhere.

Sign in to add a comment