New issue
Advanced search Search tips

Issue 710718 link

Starred by 2 users
Status: Assigned
Owner:
lazyboy@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Complex features should always have > 1 features

Project Member Reported by lazyboy@chromium.org, Apr 12 2017 
I've noticed that some of our features are listed as complex feature but are indeed simple features.

I've fixed all of them here:
https://codereview.chromium.org/2813073003/
I'm also adding a runtime DCHECK so that all complex features have > 1 features.

From Devlin's review: it is better to improve the feature compiler, so that
this is a compile-time warning instead of runtime crash.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f03a9bc2664344b6ee326f7540db022bbb4952f

commit 3f03a9bc2664344b6ee326f7540db022bbb4952f
Author: lazyboy <lazyboy@chromium.org>
Date: Wed Apr 12 16:25:43 2017

Make all ComplexFeatures with single feature to be SimpleFeature.

Change DCHECK in ComplexFeature to ensure it has > 1 features.

BUG=710718
Test=Compile & run chrome.

Review-Url: https://codereview.chromium.org/2813073003
Cr-Commit-Position: refs/heads/master@{#464051}

[modify] https://crrev.com/3f03a9bc2664344b6ee326f7540db022bbb4952f/chrome/common/extensions/api/_permission_features.json
[modify] https://crrev.com/3f03a9bc2664344b6ee326f7540db022bbb4952f/extensions/common/api/_permission_features.json
[modify] https://crrev.com/3f03a9bc2664344b6ee326f7540db022bbb4952f/extensions/common/features/complex_feature.cc
►

Sign in to add a comment