Encryption migration should try to free disk space before giving up. |
|||
Issue descriptionEncryption migration can run if there are 10MB space. However, some users might have less than 10MB. Having less that 10MB is rare and critical condition, but still metrics shows some users are in this situation. Calling cryptohome DoAutomaticFreeDiskSpaceControl API should make some space, and likely to make the available space more than 10MB (hopefully, more than 512MB) Trying this API before asking the user to manually remove files should be better.
,
Apr 18 2017
As long as DoAutomaticFreeDiskSpaceControl is called before the home directory is mounted for migration it will be cleaned up. The check is only for whether the directory is mounted, not if the user has started the login process.
,
Apr 18 2017
Okay, we also talked about making cryptohome side more aggressive on deleting files to reduce migration time, this would impact cryptohome?
,
Apr 18 2017
Yes, in its current state it would be useful for making sure the minimum amount of disk space is free, but will do very little to reduce general migration time for most users. Anything more agressive will either require changes to cryptohome (a new API or new parameters for the existing API) or changes to the migration login flow (first mount the user's directory normally and call internal chrome browser cache cleanup APIs assuming they exist then remount for migration).
,
Apr 19 2017
I've created b/37488582 to track skipping cached files during migration. Note that this issue is still relevant as the migration won't start if there isn't a minimum amount of free space.
,
Apr 24 2017
,
May 17 2017
what's the next step?
,
May 18 2017
cryptohome already does this and nothing to do. |
|||
►
Sign in to add a comment |
|||
Comment 1 by uekawa@google.com
, Apr 18 2017