Issue metadata
Sign in to add a comment
|
MD Settings: Search results are not shown for strings in some sub-pages and dialogs |
||||||||||||||||||||||||
Issue descriptionGoogle Chrome 59.0.3065.0 (Official Build) dev (32-bit) Revision 0 Platform 9449.0.0 (Official Build) dev-channel kevin What steps will reproduce the problem? 1. Open MD Settings and search for "restart" What happens instead? No results Attached screenshots.
,
Apr 12 2017
This happened at https://codereview.chromium.org/2774003002 and was intentional. For performance reasons, dialogs do not exist in the DOM (with very few exceptions) until the user requests to open them. Bringing dialog search back would require abandoning "lazy render" for all our dialogs, and regressing performance. Searching the text that describes the "dialog trigger" seems sufficient to guide the user to what they are looking for (see screenshot for example).
,
Apr 12 2017
,
Apr 13 2017
Nothing in the "About ChromeOS" section is searchable either
,
Apr 13 2017
dhaddock@: the placeholder text says "Search settings..." and About has never really been a part of settings. I understand that it looks a little bit more like it in the new design, but you can't search the about page in the old settings either (visit chrome://help-frame for an example).
,
Apr 17 2017
,
Apr 17 2017
whoops, didn't mean to remove
,
Apr 17 2017
i think the only real problem is that we don't handle cases where text is not mentioned explicitly in the UI. this is fairly brittle and has been useful but kind of ... overly-simplistic over the years. we should enhance search in general. there's plenty of stuff we could do. re-arranging terms. "did you mean?" for misspellings using an edit distance algorithm, etc. those are in issue 692774 (and probably many older bugs I'm not finding right now) |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by dbeam@chromium.org
, Apr 12 2017Status: Assigned (was: Untriaged)