New issue
Advanced search Search tips

Issue 710702 link

Starred by 9 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task

Blocked on:
issue 718622
issue 735518
issue 758302



Sign in to add a comment

Implement device RAM header & API

Project Member Reported by panicker@google.com, Apr 12 2017

Issue description

Feature description:
Header and API to expose the device RAM to web applications.

Eng owners: panicker@google.com, fmeawad@google.com

Links:
https://github.com/spanicker/device-memory

 

Comment 1 by panicker@google.com, Apr 12 2017

Components: Blink>PerformanceAPIs

Comment 2 by owe...@chromium.org, Apr 18 2017

Since this launch likely has privacy, security, testing implications it likely needs a type=Launch issue too to track approval.

See this doc for more details: http://bit.ly/2ncKZfp
Owner: panicker@chromium.org
Blockedon: 718622
Blockedon: 735518
Project Member

Comment 7 by sheriffbot@chromium.org, Jul 20 2017

Labels: Hotlist-Google
Description: Show this description
Project Member

Comment 9 by bugdroid1@chromium.org, Jul 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f73f35d0e461c62ad1e9f5d894c24330b836f76f

commit f73f35d0e461c62ad1e9f5d894c24330b836f76f
Author: Fadi Meawad <fmeawad@chromium.org>
Date: Thu Jul 20 22:58:07 2017

[Device-Memory] Ship Device-Memory Client Hints Header

The feature is described in https://github.com/WICG/device-memory
and the intent to ship is here:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/8qlTjzRY9Mc

Bug:  chromium:710702 , chromium:718622 
Change-Id: If738affc6e171c60ad4b4540c2fec19959a1561a
Reviewed-on: https://chromium-review.googlesource.com/579795
Reviewed-by: Shubhie Panicker <panicker@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Fadi Meawad <fmeawad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488463}
[modify] https://crrev.com/f73f35d0e461c62ad1e9f5d894c24330b836f76f/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5

Comment 10 by n...@fb.com, Jul 24 2017

Labels: DevRel-Facebook
Blockedon: 758302
Project Member

Comment 12 by bugdroid1@chromium.org, Aug 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ce924f715dce1d18dcec93a8cac4589f04c966e7

commit ce924f715dce1d18dcec93a8cac4589f04c966e7
Author: Fadi Meawad <fmeawad@chromium.org>
Date: Wed Aug 30 17:01:11 2017

[DeviceMemory] Ship DeviceMemory JS API

I2S: https://groups.google.com/a/chromium.org/forum/?utm_medium=email&utm_source=footer#!msg/blink-dev/MFBsNZCkotU/hQl4pB25AgAJ

Bug:  chromium:758302 , chromium:710702 
Change-Id: I5ced6f8b73caf401583498682adefad0b8ce06e0
Reviewed-on: https://chromium-review.googlesource.com/641392
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Tim Volodine <timvolodine@chromium.org>
Reviewed-by: Shubhie Panicker <panicker@chromium.org>
Commit-Queue: Fadi Meawad <fmeawad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498503}
[modify] https://crrev.com/ce924f715dce1d18dcec93a8cac4589f04c966e7/android_webview/tools/system_webview_shell/test/data/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/ce924f715dce1d18dcec93a8cac4589f04c966e7/third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/ce924f715dce1d18dcec93a8cac4589f04c966e7/third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/ce924f715dce1d18dcec93a8cac4589f04c966e7/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5

Cc: fmea...@chromium.org
Can you please link me to your type=launch issue for privacy approval tracking? This should not launch without that approval in place, FYI. Thanks!
Here's the bug:
https://bugs.chromium.org/p/chromium/issues/detail?id=758403
Do I need to do something additional to get privacy approval here?
Project Member

Comment 16 by bugdroid1@chromium.org, Sep 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7bacf86ba10a26e119006365a040a1aa5ea579c3

commit 7bacf86ba10a26e119006365a040a1aa5ea579c3
Author: Fadi Meawad <fmeawad@chromium.org>
Date: Mon Sep 11 18:29:39 2017

Revert "[DeviceMemory] Ship DeviceMemory JS API"

This reverts commit ce924f715dce1d18dcec93a8cac4589f04c966e7.

Reason for revert: Postpone shipping this feature to M63.

Original change's description:
> [DeviceMemory] Ship DeviceMemory JS API
> 
> I2S: https://groups.google.com/a/chromium.org/forum/?utm_medium=email&utm_source=footer#!msg/blink-dev/MFBsNZCkotU/hQl4pB25AgAJ
> 
> Bug:  chromium:758302 , chromium:710702 
> Change-Id: I5ced6f8b73caf401583498682adefad0b8ce06e0
> Reviewed-on: https://chromium-review.googlesource.com/641392
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
> Reviewed-by: Tim Volodine <timvolodine@chromium.org>
> Reviewed-by: Shubhie Panicker <panicker@chromium.org>
> Commit-Queue: Fadi Meawad <fmeawad@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#498503}

TBR=chrishtr@chromium.org,fmeawad@chromium.org,haraken@chromium.org,timvolodine@chromium.org,panicker@chromium.org,dglazkov@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  chromium:758302 ,  chromium:710702 ,  chromium:763966 
Change-Id: Idd341adb7c924846ca9c25f75b7aa60e7a4f50dd
Reviewed-on: https://chromium-review.googlesource.com/660481
Reviewed-by: Fadi Meawad <fmeawad@chromium.org>
Commit-Queue: Fadi Meawad <fmeawad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500982}
[modify] https://crrev.com/7bacf86ba10a26e119006365a040a1aa5ea579c3/android_webview/tools/system_webview_shell/test/data/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/7bacf86ba10a26e119006365a040a1aa5ea579c3/third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/7bacf86ba10a26e119006365a040a1aa5ea579c3/third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/7bacf86ba10a26e119006365a040a1aa5ea579c3/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5

Labels: migrated-launch-owp Type-Task
This issue has been automatically relabelled type=task because type=launch-owp issues are now officially deprecated. The deprecation is because they were creating confusion about how to get launch approvals, which should be instead done via type=launch issues.

We recommend this issue be used for implementation tracking (for public visibility), but if you already have an issue for that, you may mark this as duplicate.

For more details see here: https://docs.google.com/document/d/1JA6RohjtZQc26bTrGoIE_bSXGXUDQz8vc6G0n_sZJ2o/edit

For any questions, please contact owencm, sshruthi, larforge
Project Member

Comment 18 by bugdroid1@chromium.org, Sep 13 2017

Labels: merge-merged-3202
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/76cafeff582457d6c20052ffbead439f985bef48

commit 76cafeff582457d6c20052ffbead439f985bef48
Author: Fadi Meawad <fmeawad@chromium.org>
Date: Wed Sep 13 16:12:02 2017

Revert "[DeviceMemory] Ship DeviceMemory JS API"

This reverts commit ce924f715dce1d18dcec93a8cac4589f04c966e7.

Reason for revert: Postpone shipping this feature to M63.

Original change's description:
> [DeviceMemory] Ship DeviceMemory JS API
> 
> I2S: https://groups.google.com/a/chromium.org/forum/?utm_medium=email&utm_source=footer#!msg/blink-dev/MFBsNZCkotU/hQl4pB25AgAJ
> 
> Bug:  chromium:758302 , chromium:710702 
> Change-Id: I5ced6f8b73caf401583498682adefad0b8ce06e0
> Reviewed-on: https://chromium-review.googlesource.com/641392
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
> Reviewed-by: Tim Volodine <timvolodine@chromium.org>
> Reviewed-by: Shubhie Panicker <panicker@chromium.org>
> Commit-Queue: Fadi Meawad <fmeawad@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#498503}

TBR=chrishtr@chromium.org,fmeawad@chromium.org,haraken@chromium.org,timvolodine@chromium.org,panicker@chromium.org,dglazkov@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  chromium:758302 ,  chromium:710702 ,  chromium:763966 
Change-Id: Idd341adb7c924846ca9c25f75b7aa60e7a4f50dd
Reviewed-on: https://chromium-review.googlesource.com/660481
Reviewed-by: Fadi Meawad <fmeawad@chromium.org>
Commit-Queue: Fadi Meawad <fmeawad@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#500982}(cherry picked from commit 7bacf86ba10a26e119006365a040a1aa5ea579c3)
Reviewed-on: https://chromium-review.googlesource.com/665317
Cr-Commit-Position: refs/branch-heads/3202@{#204}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}
[modify] https://crrev.com/76cafeff582457d6c20052ffbead439f985bef48/android_webview/tools/system_webview_shell/test/data/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/76cafeff582457d6c20052ffbead439f985bef48/third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/76cafeff582457d6c20052ffbead439f985bef48/third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/76cafeff582457d6c20052ffbead439f985bef48/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5

Project Member

Comment 19 by bugdroid1@chromium.org, Oct 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aaffb85b56a6da09de221425afdf5320f5038a16

commit aaffb85b56a6da09de221425afdf5320f5038a16
Author: Fadi Meawad <fmeawad@chromium.org>
Date: Thu Oct 12 23:32:38 2017

Reland "[DeviceMemory] Ship DeviceMemory JS API"

This reverts commit 7bacf86ba10a26e119006365a040a1aa5ea579c3.

Reason for revert: The API was approved.

Original change's description:
> Revert "[DeviceMemory] Ship DeviceMemory JS API"
> 
> This reverts commit ce924f715dce1d18dcec93a8cac4589f04c966e7.
> 
> Reason for revert: Postpone shipping this feature to M63.
> 
> Original change's description:
> > [DeviceMemory] Ship DeviceMemory JS API
> > 
> > I2S: https://groups.google.com/a/chromium.org/forum/?utm_medium=email&utm_source=footer#!msg/blink-dev/MFBsNZCkotU/hQl4pB25AgAJ
> > 
> > Bug:  chromium:758302 , chromium:710702 
> > Change-Id: I5ced6f8b73caf401583498682adefad0b8ce06e0
> > Reviewed-on: https://chromium-review.googlesource.com/641392
> > Reviewed-by: Kentaro Hara <haraken@chromium.org>
> > Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
> > Reviewed-by: Tim Volodine <timvolodine@chromium.org>
> > Reviewed-by: Shubhie Panicker <panicker@chromium.org>
> > Commit-Queue: Fadi Meawad <fmeawad@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#498503}
> 
> TBR=chrishtr@chromium.org,fmeawad@chromium.org,haraken@chromium.org,timvolodine@chromium.org,panicker@chromium.org,dglazkov@chromium.org
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug:  chromium:758302 ,  chromium:710702 ,  chromium:763966 
> Change-Id: Idd341adb7c924846ca9c25f75b7aa60e7a4f50dd
> Reviewed-on: https://chromium-review.googlesource.com/660481
> Reviewed-by: Fadi Meawad <fmeawad@chromium.org>
> Commit-Queue: Fadi Meawad <fmeawad@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#500982}

TBR=chrishtr@chromium.org,fmeawad@chromium.org,haraken@chromium.org,timvolodine@chromium.org,panicker@chromium.org,dglazkov@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  chromium:758302 ,  chromium:710702 ,  chromium:763966 
Change-Id: I4099ca458088ddfde32e8af43dda26d6cd7045ea
Reviewed-on: https://chromium-review.googlesource.com/716916
Commit-Queue: Fadi Meawad <fmeawad@chromium.org>
Reviewed-by: Fadi Meawad <fmeawad@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Shubhie Panicker <panicker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508536}
[modify] https://crrev.com/aaffb85b56a6da09de221425afdf5320f5038a16/android_webview/tools/system_webview_shell/test/data/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/aaffb85b56a6da09de221425afdf5320f5038a16/third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/aaffb85b56a6da09de221425afdf5320f5038a16/third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/aaffb85b56a6da09de221425afdf5320f5038a16/third_party/WebKit/Source/platform/runtime_enabled_features.json5

Status: Fixed (was: Assigned)
Spec says deviceMemory should be exposed on Window,Worker
It's only on window
Thank you for pointing that out, I will investigate further and get back to you.

Can you elaborate on your use case with the Worker?
Customizing a progressive web app at the serviceworker level, for example by conditionally loading modules.
Thanks again for reporting the issue.

I landed the deviceMemory for the worker Today, it should be in the next canary with expected stable in M65.

Project Member

Comment 25 by bugdroid1@chromium.org, Aug 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/968995b9e74bc7c9bbbb69c9221e3b092660378f

commit 968995b9e74bc7c9bbbb69c9221e3b092660378f
Author: Eric Willigers <ericwilligers@chromium.org>
Date: Tue Aug 07 22:25:50 2018

Retire DeviceMemoryHeader flag

Device-Memory Client Hints Header shipped in M61.
This client header exposes the device Memory to web applications.
https://chromium-review.googlesource.com/579795
https://www.chromestatus.com/feature/5741299856572416

BUG= 710702 

Change-Id: I33213321cb42ce72e6b5dc9594605d63d12f1a01
Reviewed-on: https://chromium-review.googlesource.com/1165046
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581368}
[modify] https://crrev.com/968995b9e74bc7c9bbbb69c9221e3b092660378f/third_party/blink/renderer/platform/loader/fetch/client_hints_preferences.cc
[modify] https://crrev.com/968995b9e74bc7c9bbbb69c9221e3b092660378f/third_party/blink/renderer/platform/runtime_enabled_features.json5

Sign in to add a comment