Fix mp4 track_run_iterator is_keyframe calculation comment that mismatches code |
|||
Issue descriptionIn this line: https://cs.chromium.org/chromium/src/media/formats/mp4/track_run_iterator.cc?dr&l=173 Should it instead read "Sample dependency is ignored for audio..."? Looking at l.181, if is_audio is true, then indeed sample_depends_on_others is effectively ignored.
,
Apr 17 2017
I agree
,
Apr 25 2017
,
Apr 25 2017
,
Apr 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8ab986c77a7fae2cbe9c63a50c08246ceb2f3e04 commit 8ab986c77a7fae2cbe9c63a50c08246ceb2f3e04 Author: wolenetz <wolenetz@chromium.org> Date: Wed Apr 26 18:33:57 2017 Fix audio keyframe comment in MSE MP4 parser Trivial change to reflect the actual logic and intent already in the code. BUG= 710692 R=chcunningham@chromium.org Review-Url: https://codereview.chromium.org/2835163004 Cr-Commit-Position: refs/heads/master@{#467388} [modify] https://crrev.com/8ab986c77a7fae2cbe9c63a50c08246ceb2f3e04/media/formats/mp4/track_run_iterator.cc
,
Apr 26 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by wolenetz@chromium.org
, Apr 12 2017