New issue
Advanced search Search tips

Issue 710691 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Apr 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 603620



Sign in to add a comment

MD-Settings: A11y - Unlabelled Dropdowns

Project Member Reported by hcarmona@chromium.org, Apr 12 2017

Issue description

Owner: steve...@chromium.org
Status: Assigned (was: Unconfirmed)
Can you take a look at these? I don't know what the label should be on these drop downs and couldn't get to the UI for context.
I'm not really familiar with this section either, can you track down who worked on it?

It is accessible on linux with target_os = "chromeos" in the args.gn file.

Cc: jdufault@chromium.org derat@chromium.org
+jdufault for Stylus
+derat for Power

Is there a flag to expose these sections in a ChromeOS build?
Or can you provide a CL to add the aria-labels? :-)

Comment 4 by derat@chromium.org, Apr 12 2017

Cc: michae...@chromium.org
The stylus section shows up (probably unsurprisingly) on devices with stylus; I think that's just kevin and caroline. It looks like there's #force-enable-stylus-tools at chrome://flags to force it.

I think the power section shows up on devices with USB Type-C ports.
Owner: hcarmona@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4f4530109b8b68643c6a3afbb239e21580d46a8a

commit 4f4530109b8b68643c6a3afbb239e21580d46a8a
Author: hcarmona <hcarmona@chromium.org>
Date: Thu Apr 13 21:34:38 2017

MD-Settings: A11y - Label power source and stylus drop downs.

R=derat@chromium.org
BUG= 710691 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2817973002
Cr-Commit-Position: refs/heads/master@{#464552}

[modify] https://crrev.com/4f4530109b8b68643c6a3afbb239e21580d46a8a/chrome/browser/resources/settings/device_page/power.html
[modify] https://crrev.com/4f4530109b8b68643c6a3afbb239e21580d46a8a/chrome/browser/resources/settings/device_page/stylus.html

Status: Fixed (was: Started)

Comment 8 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 9 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 10 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment