New issue
Advanced search Search tips

Issue 710665 link

Starred by 1 user
Status: Fixed
Owner:
wangxianzhu@chromium.org
Closed: May 2017
Cc:
pdr@chromium.org
pbomm...@chromium.org
enne@chromium.org
vmp...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Assert failures in the pre-paint tree walk

Project Member Reported by chrishtr@chromium.org, Apr 11 2017 
1. Load plus.google.com/+BarackObama in Debug mode. Crashes with:

[1:1:0411/161221.604539:FATAL:FindPaintOffsetAndVisualRectNeedingUpdate.h(166)] Check failed: object_.IsText() || object_.IsSVGChild() || new_location == old_location_ || object_.EnclosingLayer()->SubtreeIsInvisible() || LayoutRect(-1, -1, 2, 2) .Contains(LayoutRect(LayoutPoint(new_location - old_location_), LayoutSize())). Location changed without needing update object="LayoutBlockFlow (positioned) DIV class='kPEoYc'" old="581.016,12.6406" new="580.344,11.2031"


2. Run tools/perf/run_benchmark run rasterize_and_record_micro.top_25 --browser=debug --story-filter=plus

It will crash with this failure:

	[1:1:0411/160725.677444:FATAL:PrePaintTreeWalk.cpp(41)] Check failed: parent_context.tree_builder_context->is_actually_needed. 


Perhaps this should be a P1 M59 blocker?

Comment 1 by wangxianzhu@chromium.org, Apr 12 2017

Labels: -Pri-2 M-59 ReleaseBlock-Beta Pri-1
I wrote the code. I can work on this the next week, so feel free to assign to me. The DCHECK failures might mean crashes in release build (e.g. null tree_builder_context), so it should be a blocker.

Comment 2 by schenney@chromium.org, Apr 12 2017

Labels: BugSource-Team PaintTeamTriaged-20170412

Comment 3 by candr...@chromium.org, Apr 12 2017 

Please tag with applicable OSs.  Thanks!

Comment 4 by pdr@chromium.org, Apr 12 2017

Labels: OS-All

Comment 5 by pdr@chromium.org, Apr 17 2017

Cc: -wangxianzhu@chromium.org pdr@chromium.org
Owner: wangxianzhu@chromium.org
Xianzhu's back and wanted to take this over.

Comment 6 by pbomm...@chromium.org, Apr 17 2017

Cc: pbomm...@chromium.org
wangxianzhu@ we are just a week away from M59 beta promotion and the sooner the CL lands we can get good coverage.
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2fe404ba675b5ba11b63b3a4bf8d8efdd1f86a09

commit 2fe404ba675b5ba11b63b3a4bf8d8efdd1f86a09
Author: wangxianzhu <wangxianzhu@chromium.org>
Date: Tue Apr 18 01:51:57 2017

Don't update descendant visual rects on border radius change

Border radius doesn't affect descendants' visual rects.
This fixes the "Check failed: parent_context.tree_builder_context->
is_actually_needed" failure when running
tools/perf/run_benchmark run rasterize_and_record_micro.top_25 --browser=debug --story-filter=plus
The failure was because the subtree was marked to update visual rects but
ancestors didn't update paint properties.

BUG= 710665 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2821183002
Cr-Commit-Position: refs/heads/master@{#465093}

[modify] https://crrev.com/2fe404ba675b5ba11b63b3a4bf8d8efdd1f86a09/third_party/WebKit/Source/core/paint/PrePaintTreeWalk.cpp
[modify] https://crrev.com/2fe404ba675b5ba11b63b3a4bf8d8efdd1f86a09/third_party/WebKit/Source/core/paint/PrePaintTreeWalk.h
[modify] https://crrev.com/2fe404ba675b5ba11b63b3a4bf8d8efdd1f86a09/third_party/WebKit/Source/core/paint/PrePaintTreeWalkTest.cpp

Comment 8 by wangxianzhu@chromium.org, Apr 18 2017

Labels: Merge-Request-59
Project Member

Comment 9 by sheriffbot@chromium.org, Apr 19 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved Merge-Approved-59
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 10 by bugdroid1@chromium.org, Apr 19 2017

Labels: -merge-approved-59 merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/083dce500b259c3b8ff3c9d3bf641f42bf37fa37

commit 083dce500b259c3b8ff3c9d3bf641f42bf37fa37
Author: wangxianzhu <wangxianzhu@chromium.org>
Date: Wed Apr 19 15:51:26 2017

Don't update descendant visual rects on border radius change

Border radius doesn't affect descendants' visual rects.
This fixes the "Check failed: parent_context.tree_builder_context->
is_actually_needed" failure when running
tools/perf/run_benchmark run rasterize_and_record_micro.top_25 --browser=debug --story-filter=plus
The failure was because the subtree was marked to update visual rects but
ancestors didn't update paint properties.

BUG= 710665 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2821183002
Cr-Commit-Position: refs/heads/master@{#465093}

TBR=wangxianzhu@chromium.org
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2829673002
Cr-Commit-Position: refs/branch-heads/3071@{#50}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/083dce500b259c3b8ff3c9d3bf641f42bf37fa37/third_party/WebKit/Source/core/paint/PrePaintTreeWalk.cpp
[modify] https://crrev.com/083dce500b259c3b8ff3c9d3bf641f42bf37fa37/third_party/WebKit/Source/core/paint/PrePaintTreeWalk.h
[modify] https://crrev.com/083dce500b259c3b8ff3c9d3bf641f42bf37fa37/third_party/WebKit/Source/core/paint/PrePaintTreeWalkTest.cpp

Comment 11 by wangxianzhu@chromium.org, Apr 20 2017

Labels: -ReleaseBlock-Beta -M-59 M-60
Target to M-60 and remove RBB for the first assertion failure.

Comment 12 by wangxianzhu@chromium.org, Apr 21 2017

Labels: -Pri-1 Pri-2
Reduced test case for the first assertion failure:

<!DOCTYPE html>
<div id="container" style="position: absolute; will-change: transform">
  <div id="child" style="transform-origin: 0 0; transform: rotate(129deg); width: 100px; height: 100px; background: blue"></div>
</div>
<script>
var x = 8;
setInterval(function() {
  x += Math.random() * 200 / 100;
  container.style.left = x + 'px';
}, 100);
</script>

Though the child doesn't move in the container, the container's subpixel fraction part affects visual rect and location computation of the child.

For example, at some time
  container's paint offset = (12.4,8)
  child's paint offset translation = translation(12,8)
  child's transform = rotate(129deg)
  child's paint offset = (0.4,0) (the fraction part left after paint offset translation)

though the origin of child in container is always (0,0), but the computed origin is not (0,0):
  paint-offset-translation(transform(child-paint-offset)) - container-paint-offset != (0,0)

When the fraction changes, the computed origin also changes affecting visual rect and location, but child is not marked for NeedsPaintOffsetAndVisualRectUpdate().

For now this seems not to cause any rendering issues because we fully invalidate a GraphicsLayer when its subpixel accumulation changes. This is also not a problem of SPv2.

Will investigate how to avoid assertion failure in the case.
subpixel.html
346 bytes View Download

Comment 13 by wangxianzhu@chromium.org, Apr 25 2017 

The attached test case shows the issue of pixel snapping under scale transform.

We discussed and decided not to accumulate subpixel under non-translation transforms, in PaintLayerPainter, PaintPropertyTreeBuilder and CompositedLayerMapping.
subpixel.html
824 bytes View Download
Project Member

Comment 14 by bugdroid1@chromium.org, May 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/098430b33423191b06dc32f13de764076cf60394

commit 098430b33423191b06dc32f13de764076cf60394
Author: wangxianzhu <wangxianzhu@chromium.org>
Date: Tue May 02 00:52:47 2017

Don't pass subpixel offsets through non-translation transforms

Non-translation transforms will change direction and/or scale, etc.
of offsets thus making subpixel accumulation through the transform
meaningless.

This CL addresses the issue in PaintLayerPainter and
PaintPropertyTreeBuilder. We still need to address the issue in
CompositedLayerMapping ( crbug.com/716163 ).

BUG= 710665 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2847873002
Cr-Commit-Position: refs/heads/master@{#468516}

[modify] https://crrev.com/098430b33423191b06dc32f13de764076cf60394/third_party/WebKit/LayoutTests/fast/sub-pixel/sub-pixel-root-layer.html
[add] https://crrev.com/098430b33423191b06dc32f13de764076cf60394/third_party/WebKit/LayoutTests/paint/invalidation/subpixel-offset-scaled-transform-expected.png
[add] https://crrev.com/098430b33423191b06dc32f13de764076cf60394/third_party/WebKit/LayoutTests/paint/invalidation/subpixel-offset-scaled-transform-expected.txt
[add] https://crrev.com/098430b33423191b06dc32f13de764076cf60394/third_party/WebKit/LayoutTests/paint/invalidation/subpixel-offset-scaled-transform.html
[modify] https://crrev.com/098430b33423191b06dc32f13de764076cf60394/third_party/WebKit/LayoutTests/platform/linux/compositing/shadows/shadow-drawing-expected.png
[modify] https://crrev.com/098430b33423191b06dc32f13de764076cf60394/third_party/WebKit/LayoutTests/platform/linux/editing/selection/transformed-selection-rects-expected.png
[modify] https://crrev.com/098430b33423191b06dc32f13de764076cf60394/third_party/WebKit/LayoutTests/platform/linux/svg/transforms/svg-css-transforms-expected.png
[modify] https://crrev.com/098430b33423191b06dc32f13de764076cf60394/third_party/WebKit/LayoutTests/platform/linux/transforms/svg-vs-css-expected.png
[add] https://crrev.com/098430b33423191b06dc32f13de764076cf60394/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/compositing/shadows/shadow-drawing-expected.png
[modify] https://crrev.com/098430b33423191b06dc32f13de764076cf60394/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/paint/invalidation/reflection-repaint-test-expected.txt
[modify] https://crrev.com/098430b33423191b06dc32f13de764076cf60394/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/paint/invalidation/svg/animated-path-inside-transformed-html-expected.txt
[modify] https://crrev.com/098430b33423191b06dc32f13de764076cf60394/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/paint/invalidation/transform-inline-layered-child-expected.txt
[modify] https://crrev.com/098430b33423191b06dc32f13de764076cf60394/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/paint/invalidation/transform-layout-repaint-expected.txt
[modify] https://crrev.com/098430b33423191b06dc32f13de764076cf60394/third_party/WebKit/LayoutTests/platform/mac-mac10.10/compositing/shadows/shadow-drawing-expected.png
[add] https://crrev.com/098430b33423191b06dc32f13de764076cf60394/third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/disable-spinvalidation/compositing/shadows/shadow-drawing-expected.png
[modify] https://crrev.com/098430b33423191b06dc32f13de764076cf60394/third_party/WebKit/LayoutTests/platform/mac-mac10.11/svg/transforms/svg-css-transforms-expected.png
[modify] https://crrev.com/098430b33423191b06dc32f13de764076cf60394/third_party/WebKit/LayoutTests/platform/mac-mac10.11/transforms/svg-vs-css-expected.png
[modify] https://crrev.com/098430b33423191b06dc32f13de764076cf60394/third_party/WebKit/LayoutTests/platform/mac-retina/svg/transforms/svg-css-transforms-expected.png
[modify] https://crrev.com/098430b33423191b06dc32f13de764076cf60394/third_party/WebKit/LayoutTests/platform/mac-retina/transforms/svg-vs-css-expected.png
[modify] https://crrev.com/098430b33423191b06dc32f13de764076cf60394/third_party/WebKit/LayoutTests/platform/mac/compositing/shadows/shadow-drawing-expected.png
[modify] https://crrev.com/098430b33423191b06dc32f13de764076cf60394/third_party/WebKit/LayoutTests/platform/mac/editing/selection/transformed-selection-rects-expected.png
[modify] https://crrev.com/098430b33423191b06dc32f13de764076cf60394/third_party/WebKit/LayoutTests/platform/mac/svg/transforms/svg-css-transforms-expected.png
[modify] https://crrev.com/098430b33423191b06dc32f13de764076cf60394/third_party/WebKit/LayoutTests/platform/mac/transforms/svg-vs-css-expected.png
[modify] https://crrev.com/098430b33423191b06dc32f13de764076cf60394/third_party/WebKit/LayoutTests/platform/mac/transforms/transform-on-inline-expected.png
[add] https://crrev.com/098430b33423191b06dc32f13de764076cf60394/third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/compositing/shadows/shadow-drawing-expected.png
[modify] https://crrev.com/098430b33423191b06dc32f13de764076cf60394/third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/svg/animated-path-inside-transformed-html-expected.txt
[modify] https://crrev.com/098430b33423191b06dc32f13de764076cf60394/third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/transform-inline-layered-child-expected.txt
[modify] https://crrev.com/098430b33423191b06dc32f13de764076cf60394/third_party/WebKit/LayoutTests/platform/win/compositing/shadows/shadow-drawing-expected.png
[modify] https://crrev.com/098430b33423191b06dc32f13de764076cf60394/third_party/WebKit/LayoutTests/platform/win/svg/transforms/svg-css-transforms-expected.png
[modify] https://crrev.com/098430b33423191b06dc32f13de764076cf60394/third_party/WebKit/LayoutTests/platform/win/transforms/svg-vs-css-expected.png
[add] https://crrev.com/098430b33423191b06dc32f13de764076cf60394/third_party/WebKit/LayoutTests/platform/win/virtual/disable-spinvalidation/compositing/shadows/shadow-drawing-expected.png
[delete] https://crrev.com/2915191f0a64f34fcdf8c4e4a0a5d89b2271d816/third_party/WebKit/LayoutTests/platform/win/virtual/disable-spinvalidation/paint/invalidation/reflection-repaint-test-expected.txt
[modify] https://crrev.com/098430b33423191b06dc32f13de764076cf60394/third_party/WebKit/LayoutTests/platform/win/virtual/disable-spinvalidation/paint/invalidation/svg/animated-path-inside-transformed-html-expected.txt
[modify] https://crrev.com/098430b33423191b06dc32f13de764076cf60394/third_party/WebKit/LayoutTests/platform/win/virtual/disable-spinvalidation/paint/invalidation/transform-inline-layered-child-expected.txt
[modify] https://crrev.com/098430b33423191b06dc32f13de764076cf60394/third_party/WebKit/LayoutTests/platform/win/virtual/disable-spinvalidation/paint/invalidation/transform-layout-repaint-expected.txt
[modify] https://crrev.com/098430b33423191b06dc32f13de764076cf60394/third_party/WebKit/LayoutTests/platform/win7/compositing/shadows/shadow-drawing-expected.png
[modify] https://crrev.com/098430b33423191b06dc32f13de764076cf60394/third_party/WebKit/LayoutTests/platform/win7/virtual/disable-spinvalidation/compositing/shadows/shadow-drawing-expected.png
[delete] https://crrev.com/2915191f0a64f34fcdf8c4e4a0a5d89b2271d816/third_party/WebKit/LayoutTests/virtual/disable-spinvalidation/paint/invalidation/invalidation-with-scale-transform-expected.txt
[modify] https://crrev.com/098430b33423191b06dc32f13de764076cf60394/third_party/WebKit/Source/core/layout/LayoutBox.cpp
[modify] https://crrev.com/098430b33423191b06dc32f13de764076cf60394/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp
[modify] https://crrev.com/098430b33423191b06dc32f13de764076cf60394/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp
[modify] https://crrev.com/098430b33423191b06dc32f13de764076cf60394/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp

Comment 15 by wangxianzhu@chromium.org, May 3 2017

Status: Fixed (was: Assigned)
Remaining issues are tracked by  bug 716163 .
Project Member

Comment 16 by bugdroid1@chromium.org, May 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/763e91015ba203feaa3b27c77ce4aa52638ec6e4

commit 763e91015ba203feaa3b27c77ce4aa52638ec6e4
Author: wangxianzhu <wangxianzhu@chromium.org>
Date: Wed May 03 18:54:10 2017

Revert of Don't pass subpixel offsets through non-translation transforms (patchset #7 id:120001 of https://codereview.chromium.org/2847873002/ )

Reason for revert:
BUG= 717882 

Original issue's description:
> Don't pass subpixel offsets through non-translation transforms
>
> Non-translation transforms will change direction and/or scale, etc.
> of offsets thus making subpixel accumulation through the transform
> meaningless.
>
> This CL addresses the issue in PaintLayerPainter and
> PaintPropertyTreeBuilder. We still need to address the issue in
> CompositedLayerMapping ( crbug.com/716163 ).
>
> BUG= 710665 
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
>
> Review-Url: https://codereview.chromium.org/2847873002
> Cr-Commit-Position: refs/heads/master@{#468516}
> Committed: https://chromium.googlesource.com/chromium/src/+/098430b33423191b06dc32f13de764076cf60394

TBR=chrishtr@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 710665 

Review-Url: https://codereview.chromium.org/2859483004
Cr-Commit-Position: refs/heads/master@{#469054}

[modify] https://crrev.com/763e91015ba203feaa3b27c77ce4aa52638ec6e4/third_party/WebKit/LayoutTests/fast/sub-pixel/sub-pixel-root-layer.html
[delete] https://crrev.com/e16cd1440c94c183b042fdd1c38a76138878a17b/third_party/WebKit/LayoutTests/paint/invalidation/subpixel-offset-scaled-transform-expected.png
[delete] https://crrev.com/e16cd1440c94c183b042fdd1c38a76138878a17b/third_party/WebKit/LayoutTests/paint/invalidation/subpixel-offset-scaled-transform-expected.txt
[delete] https://crrev.com/e16cd1440c94c183b042fdd1c38a76138878a17b/third_party/WebKit/LayoutTests/paint/invalidation/subpixel-offset-scaled-transform.html
[modify] https://crrev.com/763e91015ba203feaa3b27c77ce4aa52638ec6e4/third_party/WebKit/LayoutTests/platform/linux/compositing/shadows/shadow-drawing-expected.png
[modify] https://crrev.com/763e91015ba203feaa3b27c77ce4aa52638ec6e4/third_party/WebKit/LayoutTests/platform/linux/editing/selection/transformed-selection-rects-expected.png
[modify] https://crrev.com/763e91015ba203feaa3b27c77ce4aa52638ec6e4/third_party/WebKit/LayoutTests/platform/linux/svg/transforms/svg-css-transforms-expected.png
[modify] https://crrev.com/763e91015ba203feaa3b27c77ce4aa52638ec6e4/third_party/WebKit/LayoutTests/platform/linux/transforms/svg-vs-css-expected.png
[delete] https://crrev.com/e16cd1440c94c183b042fdd1c38a76138878a17b/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/compositing/shadows/shadow-drawing-expected.png
[modify] https://crrev.com/763e91015ba203feaa3b27c77ce4aa52638ec6e4/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/paint/invalidation/reflection-repaint-test-expected.txt
[modify] https://crrev.com/763e91015ba203feaa3b27c77ce4aa52638ec6e4/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/paint/invalidation/svg/animated-path-inside-transformed-html-expected.txt
[modify] https://crrev.com/763e91015ba203feaa3b27c77ce4aa52638ec6e4/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/paint/invalidation/transform-inline-layered-child-expected.txt
[modify] https://crrev.com/763e91015ba203feaa3b27c77ce4aa52638ec6e4/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/paint/invalidation/transform-layout-repaint-expected.txt
[modify] https://crrev.com/763e91015ba203feaa3b27c77ce4aa52638ec6e4/third_party/WebKit/LayoutTests/platform/mac-mac10.10/compositing/shadows/shadow-drawing-expected.png
[delete] https://crrev.com/e16cd1440c94c183b042fdd1c38a76138878a17b/third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/disable-spinvalidation/compositing/shadows/shadow-drawing-expected.png
[modify] https://crrev.com/763e91015ba203feaa3b27c77ce4aa52638ec6e4/third_party/WebKit/LayoutTests/platform/mac-mac10.11/svg/transforms/svg-css-transforms-expected.png
[modify] https://crrev.com/763e91015ba203feaa3b27c77ce4aa52638ec6e4/third_party/WebKit/LayoutTests/platform/mac-mac10.11/transforms/svg-vs-css-expected.png
[modify] https://crrev.com/763e91015ba203feaa3b27c77ce4aa52638ec6e4/third_party/WebKit/LayoutTests/platform/mac-retina/svg/transforms/svg-css-transforms-expected.png
[modify] https://crrev.com/763e91015ba203feaa3b27c77ce4aa52638ec6e4/third_party/WebKit/LayoutTests/platform/mac-retina/transforms/svg-vs-css-expected.png
[modify] https://crrev.com/763e91015ba203feaa3b27c77ce4aa52638ec6e4/third_party/WebKit/LayoutTests/platform/mac/compositing/shadows/shadow-drawing-expected.png
[modify] https://crrev.com/763e91015ba203feaa3b27c77ce4aa52638ec6e4/third_party/WebKit/LayoutTests/platform/mac/editing/selection/transformed-selection-rects-expected.png
[modify] https://crrev.com/763e91015ba203feaa3b27c77ce4aa52638ec6e4/third_party/WebKit/LayoutTests/platform/mac/svg/transforms/svg-css-transforms-expected.png
[modify] https://crrev.com/763e91015ba203feaa3b27c77ce4aa52638ec6e4/third_party/WebKit/LayoutTests/platform/mac/transforms/svg-vs-css-expected.png
[modify] https://crrev.com/763e91015ba203feaa3b27c77ce4aa52638ec6e4/third_party/WebKit/LayoutTests/platform/mac/transforms/transform-on-inline-expected.png
[delete] https://crrev.com/e16cd1440c94c183b042fdd1c38a76138878a17b/third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/compositing/shadows/shadow-drawing-expected.png
[modify] https://crrev.com/763e91015ba203feaa3b27c77ce4aa52638ec6e4/third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/svg/animated-path-inside-transformed-html-expected.txt
[modify] https://crrev.com/763e91015ba203feaa3b27c77ce4aa52638ec6e4/third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/transform-inline-layered-child-expected.txt
[modify] https://crrev.com/763e91015ba203feaa3b27c77ce4aa52638ec6e4/third_party/WebKit/LayoutTests/platform/win/compositing/shadows/shadow-drawing-expected.png
[modify] https://crrev.com/763e91015ba203feaa3b27c77ce4aa52638ec6e4/third_party/WebKit/LayoutTests/platform/win/svg/transforms/svg-css-transforms-expected.png
[modify] https://crrev.com/763e91015ba203feaa3b27c77ce4aa52638ec6e4/third_party/WebKit/LayoutTests/platform/win/transforms/svg-vs-css-expected.png
[delete] https://crrev.com/e16cd1440c94c183b042fdd1c38a76138878a17b/third_party/WebKit/LayoutTests/platform/win/virtual/disable-spinvalidation/compositing/shadows/shadow-drawing-expected.png
[add] https://crrev.com/763e91015ba203feaa3b27c77ce4aa52638ec6e4/third_party/WebKit/LayoutTests/platform/win/virtual/disable-spinvalidation/paint/invalidation/reflection-repaint-test-expected.txt
[modify] https://crrev.com/763e91015ba203feaa3b27c77ce4aa52638ec6e4/third_party/WebKit/LayoutTests/platform/win/virtual/disable-spinvalidation/paint/invalidation/svg/animated-path-inside-transformed-html-expected.txt
[modify] https://crrev.com/763e91015ba203feaa3b27c77ce4aa52638ec6e4/third_party/WebKit/LayoutTests/platform/win/virtual/disable-spinvalidation/paint/invalidation/transform-inline-layered-child-expected.txt
[modify] https://crrev.com/763e91015ba203feaa3b27c77ce4aa52638ec6e4/third_party/WebKit/LayoutTests/platform/win/virtual/disable-spinvalidation/paint/invalidation/transform-layout-repaint-expected.txt
[modify] https://crrev.com/763e91015ba203feaa3b27c77ce4aa52638ec6e4/third_party/WebKit/LayoutTests/platform/win7/compositing/shadows/shadow-drawing-expected.png
[modify] https://crrev.com/763e91015ba203feaa3b27c77ce4aa52638ec6e4/third_party/WebKit/LayoutTests/platform/win7/virtual/disable-spinvalidation/compositing/shadows/shadow-drawing-expected.png
[add] https://crrev.com/763e91015ba203feaa3b27c77ce4aa52638ec6e4/third_party/WebKit/LayoutTests/virtual/disable-spinvalidation/paint/invalidation/invalidation-with-scale-transform-expected.txt
[modify] https://crrev.com/763e91015ba203feaa3b27c77ce4aa52638ec6e4/third_party/WebKit/Source/core/layout/LayoutBox.cpp
[modify] https://crrev.com/763e91015ba203feaa3b27c77ce4aa52638ec6e4/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp
[modify] https://crrev.com/763e91015ba203feaa3b27c77ce4aa52638ec6e4/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp
[modify] https://crrev.com/763e91015ba203feaa3b27c77ce4aa52638ec6e4/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp
►

Sign in to add a comment