Disabling following tests because they are flaky on devices (failed 5 times during the past 20 runs): SCTabTestCase/testLaunchWithTopToolbar SCTabTestCase/testLaunchWithBottomToolbar SCTabTestCase/testLaunchAndTappingCell
example: https://uberchromegw.corp.google.com/i/internal.bling.main/builders/iphone10-device-x64/builds/4413
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0a3ff882814b1367aa8397337e2696686816efd4 commit 0a3ff882814b1367aa8397337e2696686816efd4 Author: liaoyuke <liaoyuke@chromium.org> Date: Tue Apr 11 23:22:54 2017 disable flaky showcase tests Disabling following tests because they are flaky on devices (failed 5 times during the past 20 runs): SCTabTestCase/testLaunchWithTopToolbar SCTabTestCase/testLaunchWithBottomToolbar SCTabTestCase/testLaunchAndTappingCell TBR=lpromero@chromium.org BUG= 710662 Review-Url: https://codereview.chromium.org/2815773002 Cr-Commit-Position: refs/heads/master@{#463831} [modify] https://crrev.com/0a3ff882814b1367aa8397337e2696686816efd4/ios/showcase/tab/sc_tab_egtest.mm [modify] https://crrev.com/0a3ff882814b1367aa8397337e2696686816efd4/ios/showcase/tab_grid/sc_tab_grid_egtest.mm
Hello Ed, 710385 is now fixed. Can you retake a look at these showcase tab tests?
Yuke gave me some very good clues to this issue. Apparently 710385 was not fixed. I am now actively working on solving this.
Great!
This is a showcase test and therefore it is not an RBB
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/71fadc89028fa77f71391e64361ea6c37372f53c commit 71fadc89028fa77f71391e64361ea6c37372f53c Author: Mark Cogan <marq@google.com> Date: Thu Nov 16 18:35:41 2017 [iOS showcase] Remove dependencies on clean/ from showcase. This CL removes clean/ view controllers from Showcase. Bug: 785925 , 710662 , 772186 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Iebce9f69b7776aa2755e46ec379d7245075a55a7 Reviewed-on: https://chromium-review.googlesource.com/774465 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by: Louis Romero <lpromero@chromium.org> Cr-Commit-Position: refs/heads/master@{#517135} [modify] https://crrev.com/71fadc89028fa77f71391e64361ea6c37372f53c/ios/showcase/BUILD.gn [modify] https://crrev.com/71fadc89028fa77f71391e64361ea6c37372f53c/ios/showcase/DEPS [modify] https://crrev.com/71fadc89028fa77f71391e64361ea6c37372f53c/ios/showcase/core/showcase_model.mm [delete] https://crrev.com/4935983c64668fb4a3d0e1eb8a4fcc4d3933113f/ios/showcase/ntp/BUILD.gn [delete] https://crrev.com/4935983c64668fb4a3d0e1eb8a4fcc4d3933113f/ios/showcase/ntp/sc_ntp_coordinator.h [delete] https://crrev.com/4935983c64668fb4a3d0e1eb8a4fcc4d3933113f/ios/showcase/ntp/sc_ntp_coordinator.mm [delete] https://crrev.com/4935983c64668fb4a3d0e1eb8a4fcc4d3933113f/ios/showcase/root/BUILD.gn [delete] https://crrev.com/4935983c64668fb4a3d0e1eb8a4fcc4d3933113f/ios/showcase/root/sc_root_coordinator.h [delete] https://crrev.com/4935983c64668fb4a3d0e1eb8a4fcc4d3933113f/ios/showcase/root/sc_root_coordinator.mm [delete] https://crrev.com/4935983c64668fb4a3d0e1eb8a4fcc4d3933113f/ios/showcase/root/sc_root_egtest.mm [delete] https://crrev.com/4935983c64668fb4a3d0e1eb8a4fcc4d3933113f/ios/showcase/tab/BUILD.gn [delete] https://crrev.com/4935983c64668fb4a3d0e1eb8a4fcc4d3933113f/ios/showcase/tab/sc_bottom_toolbar_tab_coordinator.h [delete] https://crrev.com/4935983c64668fb4a3d0e1eb8a4fcc4d3933113f/ios/showcase/tab/sc_bottom_toolbar_tab_coordinator.mm [delete] https://crrev.com/4935983c64668fb4a3d0e1eb8a4fcc4d3933113f/ios/showcase/tab/sc_tab_egtest.mm [delete] https://crrev.com/4935983c64668fb4a3d0e1eb8a4fcc4d3933113f/ios/showcase/tab/sc_top_toolbar_tab_coordinator.h [delete] https://crrev.com/4935983c64668fb4a3d0e1eb8a4fcc4d3933113f/ios/showcase/tab/sc_top_toolbar_tab_coordinator.mm [delete] https://crrev.com/4935983c64668fb4a3d0e1eb8a4fcc4d3933113f/ios/showcase/tab_grid/BUILD.gn [delete] https://crrev.com/4935983c64668fb4a3d0e1eb8a4fcc4d3933113f/ios/showcase/tab_grid/sc_tab_grid_coordinator.h [delete] https://crrev.com/4935983c64668fb4a3d0e1eb8a4fcc4d3933113f/ios/showcase/tab_grid/sc_tab_grid_coordinator.mm [delete] https://crrev.com/4935983c64668fb4a3d0e1eb8a4fcc4d3933113f/ios/showcase/tab_grid/sc_tab_grid_egtest.mm [delete] https://crrev.com/4935983c64668fb4a3d0e1eb8a4fcc4d3933113f/ios/showcase/toolbar/BUILD.gn [delete] https://crrev.com/4935983c64668fb4a3d0e1eb8a4fcc4d3933113f/ios/showcase/toolbar/sc_toolbar_coordinator.h [delete] https://crrev.com/4935983c64668fb4a3d0e1eb8a4fcc4d3933113f/ios/showcase/toolbar/sc_toolbar_coordinator.mm [delete] https://crrev.com/4935983c64668fb4a3d0e1eb8a4fcc4d3933113f/ios/showcase/toolbar/sc_toolbar_egtest.mm [delete] https://crrev.com/4935983c64668fb4a3d0e1eb8a4fcc4d3933113f/ios/showcase/tools_menu/BUILD.gn [delete] https://crrev.com/4935983c64668fb4a3d0e1eb8a4fcc4d3933113f/ios/showcase/tools_menu/sc_tools_coordinator.h [delete] https://crrev.com/4935983c64668fb4a3d0e1eb8a4fcc4d3933113f/ios/showcase/tools_menu/sc_tools_coordinator.mm
This is no longer relevant as clean was deleted. I'm marking this fixed by virtue of being deleted.
Comment 1 by liaoyuke@chromium.org
, Apr 11 2017