New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 710660 link

Starred by 6 users
Status: Fixed
Owner:
aee@chromium.org
Closed: Mar 2018
Cc:
tommycli@chromium.org
mahmadi@chromium.org
nyerramilli@chromium.org
rbasuvula@chromium.org
dbeam@chromium.org
█ msrchandra@chromium.org
dpa...@chromium.org
est...@chromium.org
█ dschuyler@chromium.org
jmukthavaram@chromium.org
█ ranjitkan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

MD Settings: blue line to show current profile photo not working initially

Project Member Reported by dbeam@chromium.org, Apr 11 2017 
0. visit chrome://md-settings
1. click on profile icon (to change it)

what do you expect?
a blue border on the current icon

what happens instead?
dbeam@ broke this to make avatars higher res.

additional info:
we currently use URLs as selection keys.  when I made the user's profile info higher resolution, I did so by sending a data URI (the whole image encoded as base64).  it'd be better for performance to just give a smaller url (like chrome://theme/IDR_PROFILE_AVATAR_*) and update theme_source.cc to look for a high res icon when possible.

Comment 1 by dbeam@chromium.org, Apr 12 2017

Cc: msrchandra@chromium.org dbeam@chromium.org ranjitkan@chromium.org rbasuvula@chromium.org nyerramilli@chromium.org
 Issue 710782  has been merged into this issue.

Comment 2 by dpa...@chromium.org, Jun 21 2017

Cc: mahmadi@chromium.org
 Issue 735542  has been merged into this issue.

Comment 3 by dpa...@chromium.org, Jun 29 2017

Cc: jmukthavaram@chromium.org dpa...@chromium.org
 Issue 737865  has been merged into this issue.

Comment 4 by dpa...@chromium.org, Oct 27 2017 

 Issue 779018  has been merged into this issue.

Comment 5 by aee@chromium.org, Mar 2 2018

Owner: aee@chromium.org
Status: Assigned (was: Available)

Comment 6 by aee@chromium.org, Mar 5 2018

Status: Started (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 8 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9541cad0d8922abcddf5cb0e7495fb910d82f4ce

commit 9541cad0d8922abcddf5cb0e7495fb910d82f4ce
Author: Esmael El-Moslimany <aee@chromium.org>
Date: Thu Mar 08 19:29:08 2018

Settings WebUI: show selected avatar on initial load of manage profile

Bug:  710660 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I2a43c8a51c6702d2e79e05b72162133d18f82041
Reviewed-on: https://chromium-review.googlesource.com/949419
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541862}
[modify] https://crrev.com/9541cad0d8922abcddf5cb0e7495fb910d82f4ce/chrome/browser/resources/settings/people_page/manage_profile.js
[modify] https://crrev.com/9541cad0d8922abcddf5cb0e7495fb910d82f4ce/chrome/browser/ui/webui/settings/settings_manage_profile_handler.cc
[modify] https://crrev.com/9541cad0d8922abcddf5cb0e7495fb910d82f4ce/chrome/browser/ui/webui/settings/settings_manage_profile_handler.h
[modify] https://crrev.com/9541cad0d8922abcddf5cb0e7495fb910d82f4ce/chrome/browser/ui/webui/settings/settings_manage_profile_handler_unittest.cc
[modify] https://crrev.com/9541cad0d8922abcddf5cb0e7495fb910d82f4ce/chrome/test/data/webui/settings/people_page_manage_profile_test.js
[modify] https://crrev.com/9541cad0d8922abcddf5cb0e7495fb910d82f4ce/ui/webui/resources/cr_elements/cr_profile_avatar_selector/cr_profile_avatar_selector.html
[modify] https://crrev.com/9541cad0d8922abcddf5cb0e7495fb910d82f4ce/ui/webui/resources/cr_elements/cr_profile_avatar_selector/cr_profile_avatar_selector.js

Comment 8 by aee@chromium.org, Mar 8 2018

Status: Fixed (was: Started)
►

Sign in to add a comment