- See "Feature Configurations: Previews" in https://docs.google.com/a/google.com/document/d/1PhvySbeYOuI6KN3GaJ24ZtZ6vgwJ56Fqmmup0C8NCfc/edit?usp=sharing - See "Previews" (slide 15) in https://docs.google.com/a/google.com/presentation/d/1p9G33j1FNmoeI5jwcqFjBRC1Vm1TbpsJZktwJCXgim0/edit?usp=sharing This involves: (1) Adding event tags to the UI (2) Adding a trigger to show the popup bubble
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a8c329d4466035b680575a794744e469641e7b9b commit a8c329d4466035b680575a794744e469641e7b9b Author: dtrainor <dtrainor@chromium.org> Date: Fri Apr 28 08:45:23 2017 IPH - connect data saver previews Adds the IPH that points to the data saver preview infobar. This includes three main changes: - Adding support for determining which kind of infobar is showing in Java. - Hooking up the info bar show code to log an event saying it was shown. - Hooking up the info bar show code to a function which can pick (if any) a feature and string to show which will point to that infobar. BUG= 710648 Review-Url: https://codereview.chromium.org/2815653003 Cr-Commit-Position: refs/heads/master@{#467935} [add] https://crrev.com/a8c329d4466035b680575a794744e469641e7b9b/chrome/android/java/src/org/chromium/chrome/browser/infobar/IPHInfoBarSupport.java [modify] https://crrev.com/a8c329d4466035b680575a794744e469641e7b9b/chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBar.java [modify] https://crrev.com/a8c329d4466035b680575a794744e469641e7b9b/chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarContainer.java [modify] https://crrev.com/a8c329d4466035b680575a794744e469641e7b9b/chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarContainerLayout.java [modify] https://crrev.com/a8c329d4466035b680575a794744e469641e7b9b/chrome/android/java/src/org/chromium/chrome/browser/widget/textbubble/TextBubble.java [modify] https://crrev.com/a8c329d4466035b680575a794744e469641e7b9b/chrome/android/java/strings/android_chrome_strings.grd [modify] https://crrev.com/a8c329d4466035b680575a794744e469641e7b9b/chrome/android/java_sources.gni [modify] https://crrev.com/a8c329d4466035b680575a794744e469641e7b9b/chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java [modify] https://crrev.com/a8c329d4466035b680575a794744e469641e7b9b/chrome/android/javatests/src/org/chromium/chrome/browser/infobar/InfoBarContainerTest.java [modify] https://crrev.com/a8c329d4466035b680575a794744e469641e7b9b/chrome/android/javatests/src/org/chromium/chrome/browser/infobar/InfoBarTest.java [modify] https://crrev.com/a8c329d4466035b680575a794744e469641e7b9b/chrome/android/javatests/src/org/chromium/chrome/browser/infobar/PermissionUpdateInfobarTest.java [modify] https://crrev.com/a8c329d4466035b680575a794744e469641e7b9b/chrome/android/javatests/src/org/chromium/chrome/browser/infobar/SearchGeolocationDisclosureInfoBarTest.java [modify] https://crrev.com/a8c329d4466035b680575a794744e469641e7b9b/chrome/android/javatests/src/org/chromium/chrome/browser/permissions/PermissionTestCaseBase.java [modify] https://crrev.com/a8c329d4466035b680575a794744e469641e7b9b/chrome/android/javatests/src/org/chromium/chrome/browser/preferences/website/SiteSettingsPreferencesTest.java [modify] https://crrev.com/a8c329d4466035b680575a794744e469641e7b9b/chrome/android/javatests/src/org/chromium/chrome/browser/translate/TranslateInfoBarTest.java [modify] https://crrev.com/a8c329d4466035b680575a794744e469641e7b9b/chrome/browser/ui/android/infobars/infobar_android.cc [modify] https://crrev.com/a8c329d4466035b680575a794744e469641e7b9b/chrome/browser/ui/android/infobars/infobar_android.h [modify] https://crrev.com/a8c329d4466035b680575a794744e469641e7b9b/chrome/test/android/javatests/src/org/chromium/chrome/test/util/InfoBarTestAnimationListener.java [modify] https://crrev.com/a8c329d4466035b680575a794744e469641e7b9b/components/feature_engagement_tracker/internal/feature_constants.cc [modify] https://crrev.com/a8c329d4466035b680575a794744e469641e7b9b/components/feature_engagement_tracker/internal/feature_list.cc [modify] https://crrev.com/a8c329d4466035b680575a794744e469641e7b9b/components/feature_engagement_tracker/public/android/java/src/org/chromium/components/feature_engagement_tracker/EventConstants.java [modify] https://crrev.com/a8c329d4466035b680575a794744e469641e7b9b/components/feature_engagement_tracker/public/android/java/src/org/chromium/components/feature_engagement_tracker/FeatureConstants.java [modify] https://crrev.com/a8c329d4466035b680575a794744e469641e7b9b/components/feature_engagement_tracker/public/feature_constants.h
Comment 1 by dtrainor@chromium.org
, Apr 12 2017Owner: dtrainor@chromium.org
Status: Started (was: Assigned)