New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 710647 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug


Show other hotlists

Hotlists containing this issue:
In-Product-Help


Sign in to add a comment

[IPH] UI - Add triggers for Download Home

Project Member Reported by dtrainor@chromium.org, Apr 11 2017

Issue description

- See "Feature Configurations: Download Home" in https://docs.google.com/a/google.com/document/d/1PhvySbeYOuI6KN3GaJ24ZtZ6vgwJ56Fqmmup0C8NCfc/edit?usp=sharing
- See "Download Home" (slide 14) in https://docs.google.com/a/google.com/presentation/d/1p9G33j1FNmoeI5jwcqFjBRC1Vm1TbpsJZktwJCXgim0/edit?usp=sharing

This involves:
(1) Adding event tags to the UI
(2) Adding a trigger to show the popup bubble
(3) Adding the menu highlight as well

 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/56bf32f77a418628dd04bc68f4ef8400a3cf0480

commit 56bf32f77a418628dd04bc68f4ef8400a3cf0480
Author: shaktisahu <shaktisahu@chromium.org>
Date: Tue Apr 25 22:54:03 2017

IPH - Added triggers to show Download Home message

This CL shows in-product-help message to user about download home.
The text bubble would be shown at chrome startup if the user has completed at least one download.

Backend interaction:
1 - On every startup - Check ShouldTriggerHelpUI(IPH_DownloadHome)
2 - On every completed download - Send event download_completed
3 - On every open of download home - Send event download_home_opened
4 - On every dismiss of IPH - Send dismissed() to tracker

BUG= 710647 

Review-Url: https://codereview.chromium.org/2815183002
Cr-Commit-Position: refs/heads/master@{#467154}

[modify] https://crrev.com/56bf32f77a418628dd04bc68f4ef8400a3cf0480/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
[modify] https://crrev.com/56bf32f77a418628dd04bc68f4ef8400a3cf0480/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java
[modify] https://crrev.com/56bf32f77a418628dd04bc68f4ef8400a3cf0480/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUtils.java
[modify] https://crrev.com/56bf32f77a418628dd04bc68f4ef8400a3cf0480/chrome/android/java/src/org/chromium/chrome/browser/download/SystemDownloadNotifier.java
[modify] https://crrev.com/56bf32f77a418628dd04bc68f4ef8400a3cf0480/chrome/android/java/strings/android_chrome_strings.grd
[modify] https://crrev.com/56bf32f77a418628dd04bc68f4ef8400a3cf0480/components/feature_engagement_tracker/internal/feature_constants.cc
[modify] https://crrev.com/56bf32f77a418628dd04bc68f4ef8400a3cf0480/components/feature_engagement_tracker/internal/feature_list.cc
[modify] https://crrev.com/56bf32f77a418628dd04bc68f4ef8400a3cf0480/components/feature_engagement_tracker/public/android/java/src/org/chromium/components/feature_engagement_tracker/EventConstants.java
[modify] https://crrev.com/56bf32f77a418628dd04bc68f4ef8400a3cf0480/components/feature_engagement_tracker/public/android/java/src/org/chromium/components/feature_engagement_tracker/FeatureConstants.java
[modify] https://crrev.com/56bf32f77a418628dd04bc68f4ef8400a3cf0480/components/feature_engagement_tracker/public/feature_constants.h

Status: Fixed (was: Started)

Sign in to add a comment