- See "Feature Configurations: Download Page" in https://docs.google.com/a/google.com/document/d/1PhvySbeYOuI6KN3GaJ24ZtZ6vgwJ56Fqmmup0C8NCfc/edit?usp=sharing - See "Download Page" (slide 13) in https://docs.google.com/a/google.com/presentation/d/1p9G33j1FNmoeI5jwcqFjBRC1Vm1TbpsJZktwJCXgim0/edit?usp=sharing This involves: (1) Adding event tags to the UI (2) Adding a trigger to show the popup bubble (3) Adding the menu highlight as well
CL in progress : https://codereview.chromium.org/2814843006/
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/758540e55198236edc0a417b7dd69e60a3ceedac commit 758540e55198236edc0a417b7dd69e60a3ceedac Author: shaktisahu <shaktisahu@chromium.org> Date: Tue Apr 25 20:20:54 2017 IPH - Added triggers for Download page This CL adds in-product-help to download a page for viewing offline later. The IPH would be shown after a successful page navigation after the user has seen an offline dino. Backend interaction: 1 - On every successful page load - Check ShouldTriggerHelpUI(IPH_DownloadPage) 2 - On every show of dino page - Send event user_has_seen_dino 3 - On every of download of page - Send event download_page_started 4 - On dismiss of IPH - Send dismissed() to tracker BUG= 710646 Review-Url: https://codereview.chromium.org/2814843006 Cr-Commit-Position: refs/heads/master@{#467091} [modify] https://crrev.com/758540e55198236edc0a417b7dd69e60a3ceedac/chrome/android/java/res/values/dimens.xml [modify] https://crrev.com/758540e55198236edc0a417b7dd69e60a3ceedac/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUtils.java [modify] https://crrev.com/758540e55198236edc0a417b7dd69e60a3ceedac/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java [modify] https://crrev.com/758540e55198236edc0a417b7dd69e60a3ceedac/chrome/android/java/strings/android_chrome_strings.grd [modify] https://crrev.com/758540e55198236edc0a417b7dd69e60a3ceedac/components/feature_engagement_tracker/internal/feature_constants.cc [modify] https://crrev.com/758540e55198236edc0a417b7dd69e60a3ceedac/components/feature_engagement_tracker/internal/feature_list.cc [modify] https://crrev.com/758540e55198236edc0a417b7dd69e60a3ceedac/components/feature_engagement_tracker/public/BUILD.gn [add] https://crrev.com/758540e55198236edc0a417b7dd69e60a3ceedac/components/feature_engagement_tracker/public/android/java/src/org/chromium/components/feature_engagement_tracker/EventConstants.java [modify] https://crrev.com/758540e55198236edc0a417b7dd69e60a3ceedac/components/feature_engagement_tracker/public/android/java/src/org/chromium/components/feature_engagement_tracker/FeatureConstants.java [modify] https://crrev.com/758540e55198236edc0a417b7dd69e60a3ceedac/components/feature_engagement_tracker/public/feature_constants.h [modify] https://crrev.com/758540e55198236edc0a417b7dd69e60a3ceedac/tools/android/eclipse/.classpath
Comment 1 by dtrainor@chromium.org
, Apr 11 2017