New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 710633 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Feature

Blocking:
issue 737231



Sign in to add a comment

Enable Brotli in Cronet

Project Member Reported by xunji...@chromium.org, Apr 11 2017

Issue description

This bug is filed to track Brotli in Cronet.
(1) New version of Cronet will include Brotli library.
(2) Cronet will expose an API to enable/disable Brotli on CronetEngine. 
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/8b20c8c84b1a400173458f5179b8dc0f3137018c

commit 8b20c8c84b1a400173458f5179b8dc0f3137018c
Author: Helen Li <xunjieli@chromium.org>
Date: Mon Apr 17 15:42:55 2017

Remove disable_brotli_filter from Cronet recipe

Cronet now includes Brotli support.

Bug:  710633 
Change-Id: I91ce954e1b0ab26dcc8eddd61baa7726e8fc626f
Reviewed-on: https://chromium-review.googlesource.com/479154
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Xunjie Li <xunjieli@chromium.org>

[modify] https://crrev.com/8b20c8c84b1a400173458f5179b8dc0f3137018c/scripts/slave/recipe_modules/cronet/example.expected/gn_test.json
[modify] https://crrev.com/8b20c8c84b1a400173458f5179b8dc0f3137018c/scripts/slave/recipe_modules/chromium_android/chromium_config.py

Project Member

Comment 2 by bugdroid1@chromium.org, Apr 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/186d2bf1b6ff14929c79d6d4a8b310ba639dfbf9

commit 186d2bf1b6ff14929c79d6d4a8b310ba639dfbf9
Author: xunjieli <xunjieli@chromium.org>
Date: Tue Apr 18 13:45:47 2017

[Cronet] Enable Brotli

- removes the compile time flag to disable brotli when building Cronet.
- adds an API to enable Brotli on CronetEngine.
- adds three basic java tests in BrotliTest.java

BUG= 710633 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2805053005
Cr-Commit-Position: refs/heads/master@{#465216}

[modify] https://crrev.com/186d2bf1b6ff14929c79d6d4a8b310ba639dfbf9/components/cronet/android/BUILD.gn
[modify] https://crrev.com/186d2bf1b6ff14929c79d6d4a8b310ba639dfbf9/components/cronet/android/api.txt
[modify] https://crrev.com/186d2bf1b6ff14929c79d6d4a8b310ba639dfbf9/components/cronet/android/api/src/org/chromium/net/CronetEngine.java
[modify] https://crrev.com/186d2bf1b6ff14929c79d6d4a8b310ba639dfbf9/components/cronet/android/api/src/org/chromium/net/ICronetEngineBuilder.java
[modify] https://crrev.com/186d2bf1b6ff14929c79d6d4a8b310ba639dfbf9/components/cronet/android/api_version.txt
[modify] https://crrev.com/186d2bf1b6ff14929c79d6d4a8b310ba639dfbf9/components/cronet/android/cronet_url_request_context_adapter.cc
[modify] https://crrev.com/186d2bf1b6ff14929c79d6d4a8b310ba639dfbf9/components/cronet/android/java/src/org/chromium/net/impl/CronetEngineBuilderImpl.java
[modify] https://crrev.com/186d2bf1b6ff14929c79d6d4a8b310ba639dfbf9/components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequestContext.java
[add] https://crrev.com/186d2bf1b6ff14929c79d6d4a8b310ba639dfbf9/components/cronet/android/test/javatests/src/org/chromium/net/BrotliTest.java
[modify] https://crrev.com/186d2bf1b6ff14929c79d6d4a8b310ba639dfbf9/components/cronet/android/test/src/org/chromium/net/Http2TestHandler.java
[modify] https://crrev.com/186d2bf1b6ff14929c79d6d4a8b310ba639dfbf9/components/cronet/android/test/src/org/chromium/net/Http2TestServer.java
[modify] https://crrev.com/186d2bf1b6ff14929c79d6d4a8b310ba639dfbf9/components/cronet/stale_host_resolver_unittest.cc
[modify] https://crrev.com/186d2bf1b6ff14929c79d6d4a8b310ba639dfbf9/components/cronet/tools/cr_cronet.py
[modify] https://crrev.com/186d2bf1b6ff14929c79d6d4a8b310ba639dfbf9/components/cronet/url_request_context_config.cc
[modify] https://crrev.com/186d2bf1b6ff14929c79d6d4a8b310ba639dfbf9/components/cronet/url_request_context_config.h
[modify] https://crrev.com/186d2bf1b6ff14929c79d6d4a8b310ba639dfbf9/components/cronet/url_request_context_config_unittest.cc
[modify] https://crrev.com/186d2bf1b6ff14929c79d6d4a8b310ba639dfbf9/tools/mb/mb_config.pyl

Status: Fixed (was: Assigned)
For reference the commit in comment #2 went into 60.0.3075.0

Comment 6 by mef@chromium.org, Jun 27 2017

Blocking: 737231

Sign in to add a comment