This bug is filed to track Brotli in Cronet. (1) New version of Cronet will include Brotli library. (2) Cronet will expose an API to enable/disable Brotli on CronetEngine.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/8b20c8c84b1a400173458f5179b8dc0f3137018c commit 8b20c8c84b1a400173458f5179b8dc0f3137018c Author: Helen Li <xunjieli@chromium.org> Date: Mon Apr 17 15:42:55 2017 Remove disable_brotli_filter from Cronet recipe Cronet now includes Brotli support. Bug: 710633 Change-Id: I91ce954e1b0ab26dcc8eddd61baa7726e8fc626f Reviewed-on: https://chromium-review.googlesource.com/479154 Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: Xunjie Li <xunjieli@chromium.org> [modify] https://crrev.com/8b20c8c84b1a400173458f5179b8dc0f3137018c/scripts/slave/recipe_modules/cronet/example.expected/gn_test.json [modify] https://crrev.com/8b20c8c84b1a400173458f5179b8dc0f3137018c/scripts/slave/recipe_modules/chromium_android/chromium_config.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/186d2bf1b6ff14929c79d6d4a8b310ba639dfbf9 commit 186d2bf1b6ff14929c79d6d4a8b310ba639dfbf9 Author: xunjieli <xunjieli@chromium.org> Date: Tue Apr 18 13:45:47 2017 [Cronet] Enable Brotli - removes the compile time flag to disable brotli when building Cronet. - adds an API to enable Brotli on CronetEngine. - adds three basic java tests in BrotliTest.java BUG= 710633 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Review-Url: https://codereview.chromium.org/2805053005 Cr-Commit-Position: refs/heads/master@{#465216} [modify] https://crrev.com/186d2bf1b6ff14929c79d6d4a8b310ba639dfbf9/components/cronet/android/BUILD.gn [modify] https://crrev.com/186d2bf1b6ff14929c79d6d4a8b310ba639dfbf9/components/cronet/android/api.txt [modify] https://crrev.com/186d2bf1b6ff14929c79d6d4a8b310ba639dfbf9/components/cronet/android/api/src/org/chromium/net/CronetEngine.java [modify] https://crrev.com/186d2bf1b6ff14929c79d6d4a8b310ba639dfbf9/components/cronet/android/api/src/org/chromium/net/ICronetEngineBuilder.java [modify] https://crrev.com/186d2bf1b6ff14929c79d6d4a8b310ba639dfbf9/components/cronet/android/api_version.txt [modify] https://crrev.com/186d2bf1b6ff14929c79d6d4a8b310ba639dfbf9/components/cronet/android/cronet_url_request_context_adapter.cc [modify] https://crrev.com/186d2bf1b6ff14929c79d6d4a8b310ba639dfbf9/components/cronet/android/java/src/org/chromium/net/impl/CronetEngineBuilderImpl.java [modify] https://crrev.com/186d2bf1b6ff14929c79d6d4a8b310ba639dfbf9/components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequestContext.java [add] https://crrev.com/186d2bf1b6ff14929c79d6d4a8b310ba639dfbf9/components/cronet/android/test/javatests/src/org/chromium/net/BrotliTest.java [modify] https://crrev.com/186d2bf1b6ff14929c79d6d4a8b310ba639dfbf9/components/cronet/android/test/src/org/chromium/net/Http2TestHandler.java [modify] https://crrev.com/186d2bf1b6ff14929c79d6d4a8b310ba639dfbf9/components/cronet/android/test/src/org/chromium/net/Http2TestServer.java [modify] https://crrev.com/186d2bf1b6ff14929c79d6d4a8b310ba639dfbf9/components/cronet/stale_host_resolver_unittest.cc [modify] https://crrev.com/186d2bf1b6ff14929c79d6d4a8b310ba639dfbf9/components/cronet/tools/cr_cronet.py [modify] https://crrev.com/186d2bf1b6ff14929c79d6d4a8b310ba639dfbf9/components/cronet/url_request_context_config.cc [modify] https://crrev.com/186d2bf1b6ff14929c79d6d4a8b310ba639dfbf9/components/cronet/url_request_context_config.h [modify] https://crrev.com/186d2bf1b6ff14929c79d6d4a8b310ba639dfbf9/components/cronet/url_request_context_config_unittest.cc [modify] https://crrev.com/186d2bf1b6ff14929c79d6d4a8b310ba639dfbf9/tools/mb/mb_config.pyl
Binary size footprint as a percentage of libcronet.so in release: armv7 148.0 KiB Relative change: + 4.9% https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgosHEuQkM arm64 160.0 KiB Relative change: + 3.2% https://chromeperf.appspot.com/report?sid=cc9d842d17a31b42cc52e08bd709f3ed8a3f109374c8cdcdf0d0e3f193286f2d&rev=465220 x86 164.0 KiB Relative change: + 2.8% https://chromeperf.appspot.com/report?sid=c0e27db037f1dbe3079daccb4aaec67e6a26ea1db584744452070d2ad3a7fda7&rev=465219 MIPS: 192.1 KiB Relative change: + 2.9% https://chromeperf.appspot.com/report?sid=5773a327381e24ffd7ed5d3e12c9b86f11948bd687a654b0eeede5bea5ec93d4&rev=465219
For reference the commit in comment #2 went into 60.0.3075.0
Comment 1 by bugdroid1@chromium.org
, Apr 17 2017