New issue
Advanced search Search tips

Issue 710626 link

Starred by 3 users

Issue metadata

Status: Duplicate
Merged: issue 716998
Owner:
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

[Cronet] testRealTimeNetworkQualityObservationsQuicDisabled flake

Project Member Reported by xunji...@chromium.org, Apr 11 2017

Issue description

testRealTimeNetworkQualityObservationsQuicDisabled is failing on Cronet bots.

The failing assertion is:
 assertTrue(testFramework.mCronetEngine.getTransportRttMs() >= 0); 


6bdcf:  04-11 21:06:54.721  3871  3884 I TestRunner: started: testRealTimeNetworkQualityObservationsQuicDisabled(org.chromium.net.CronetUrlRequestContextTest)
6bdcf:  04-11 21:06:54.749  3871  3884 I cr_TestServer: Waiting for EmbeddedTestServer service connection.
6bdcf:  04-11 21:06:54.751  3871  3884 I cr_TestServer: Still waiting for EmbeddedTestServer service connection.
6bdcf:  04-11 21:06:54.752  3871  3884 I cr_TestServer: EmbeddedTestServer service connected.
6bdcf:  04-11 21:06:54.772  3871  3884 I cr_CronetLibraryLoader: Cronet version: 59.0.3068.0, arch: aarch64
6bdcf:  04-11 21:06:54.781   922  3248 D ConnectivityService: listenForNetwork for Listen from uid/pid:10090/3871 for NetworkRequest [ id=64, legacyType=-1, [ Capabilities: INTERNET&NOT_RESTRICTED&TRUSTED] ]
6bdcf:  04-11 21:06:54.804  3871  3884 I cr_CronetUrlRequestContextTest: Still waiting for pref file update.....
6bdcf:  04-11 21:07:06.806  3871  3884 I cr_CronetUrlRequestContextTest: Still waiting for pref file update.....
6bdcf:  04-11 21:07:18.873  3871  3884 I TestRunner: failed: testRealTimeNetworkQualityObservationsQuicDisabled(org.chromium.net.CronetUrlRequestContextTest)
6bdcf:  04-11 21:07:18.874  3871  3884 I TestRunner: ----- begin exception -----
6bdcf:  04-11 21:07:18.875  3871  3884 I TestRunner: 
6bdcf:  04-11 21:07:18.875  3871  3884 I TestRunner: java.lang.Throwable: CronetTestBase#runTest failed.
6bdcf:  04-11 21:07:18.875  3871  3884 I TestRunner: 	at org.chromium.net.CronetTestBase.runTest(CronetTestBase.java:147)
6bdcf:  04-11 21:07:18.875  3871  3884 I TestRunner: 	at junit.framework.TestCase.runBare(TestCase.java:134)
6bdcf:  04-11 21:07:18.875  3871  3884 I TestRunner: 	at junit.framework.TestResult$1.protect(TestResult.java:115)
6bdcf:  04-11 21:07:18.875  3871  3884 I TestRunner: 	at junit.framework.TestResult.runProtected(TestResult.java:133)
6bdcf:  04-11 21:07:18.875  3871  3884 I TestRunner: 	at junit.framework.TestResult.run(TestResult.java:118)
6bdcf:  04-11 21:07:18.875  3871  3884 I TestRunner: 	at junit.framework.TestCase.run(TestCase.java:124)
6bdcf:  04-11 21:07:18.875  3871  3884 I TestRunner: 	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
6bdcf:  04-11 21:07:18.875  3871  3884 I TestRunner: 	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
6bdcf:  04-11 21:07:18.875  3871  3884 I TestRunner: 	at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:555)
6bdcf:  04-11 21:07:18.875  3871  3884 I TestRunner: 	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1879)
6bdcf:  04-11 21:07:18.875  3871  3884 I TestRunner: Caused by: junit.framework.AssertionFailedError
6bdcf:  04-11 21:07:18.875  3871  3884 I TestRunner: 	at junit.framework.Assert.fail(Assert.java:48)
6bdcf:  04-11 21:07:18.875  3871  3884 I TestRunner: 	at junit.framework.Assert.assertTrue(Assert.java:20)
6bdcf:  04-11 21:07:18.875  3871  3884 I TestRunner: 	at junit.framework.Assert.assertTrue(Assert.java:27)
6bdcf:  04-11 21:07:18.875  3871  3884 I TestRunner: 	at org.chromium.net.CronetUrlRequestContextTest.testRealTimeNetworkQualityObservationsQuicDisabled(CronetUrlRequestContextTest.java:347)
6bdcf:  04-11 21:07:18.875  3871  3884 I TestRunner: 	at java.lang.reflect.Method.invoke(Native Method)
6bdcf:  04-11 21:07:18.875  3871  3884 I TestRunner: 	at junit.framework.TestCase.runTest(TestCase.java:168)
6bdcf:  04-11 21:07:18.875  3871  3884 I TestRunner: 	at org.chromium.net.CronetTestBase.runTest(CronetTestBase.java:144)
6bdcf:  04-11 21:07:18.875  3871  3884 I TestRunner: 	... 9 more
6bdcf:  04-11 21:07:18.875  3871  3884 I TestRunner: ----- end exception -----
6bdcf:  04-11 21:07:18.878  3871  3884 I TestRunner: finished: testRealTimeNetworkQualityObservationsQuicDisabled(org.chromium.net.CronetUrlRequestContextTest)

 
Cc: tbansal@chromium.org
Summary: [Cronet] testRealTimeNetworkQualityObservationsQuicDisabled flake (was: [Cronet] testRealTimeNetworkQualityObservationsQuicDisabled )
This is indeed a flake.

Comment 5 by pschm...@google.com, Apr 13 2017

Issue 711344 has been merged into this issue.
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/844858e34bd823d24ee1ac41b23203c7fb597d31

commit 844858e34bd823d24ee1ac41b23203c7fb597d31
Author: xunjieli <xunjieli@chromium.org>
Date: Thu Apr 13 19:09:46 2017

[Cronet] Disable flaky testRealTimeNetworkQualityObservationsQuicDisabled

testRealTimeNetworkQualityObservationsQuicDisabled is flaky

BUG= 710626 

TBR=kapishnikov@chromium.org

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2821503002
Cr-Commit-Position: refs/heads/master@{#464491}

[modify] https://crrev.com/844858e34bd823d24ee1ac41b23203c7fb597d31/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java

Labels: -Pri-1 M-60 Pri-2

Comment 8 by mge...@chromium.org, Apr 28 2017

Looks like https://codereview.chromium.org/2821503002 disabled the wrong test. There are a bunch with similar names and it disabled testRealTimeNetworkQualityObservationsNotEnabled instead of testRealTimeNetworkQualityObservationsQuicDisabled.
Status: Started (was: Untriaged)
Cc: -tbansal@chromium.org
Owner: tbansal@chromium.org
Miriam, ah, thanks, good catch! Maybe we can do something about the long test names.


Project Member

Comment 11 by bugdroid1@chromium.org, May 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/228ebf10b2054a06baf2bffcdb0825ddecdc96ae

commit 228ebf10b2054a06baf2bffcdb0825ddecdc96ae
Author: tbansal <tbansal@chromium.org>
Date: Mon May 01 17:25:55 2017

Disable flaky NQE test in Cronet

Disable flaky NetworkQualityEstimator (NQE) test in Cronet. Also, rename
a few NQE tests.

BUG= 710626 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2850873002
Cr-Commit-Position: refs/heads/master@{#468342}

[modify] https://crrev.com/228ebf10b2054a06baf2bffcdb0825ddecdc96ae/components/cronet/android/BUILD.gn
[modify] https://crrev.com/228ebf10b2054a06baf2bffcdb0825ddecdc96ae/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java
[add] https://crrev.com/228ebf10b2054a06baf2bffcdb0825ddecdc96ae/components/cronet/android/test/javatests/src/org/chromium/net/NQETest.java

Mergedinto: 716998
Status: Duplicate (was: Started)

Sign in to add a comment