New issue
Advanced search Search tips

Issue 710619 link

Starred by 1 user
Status: Available
Owner: ----
Cc:
no...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Deleted projects are still partially visible in LUCI config

Project Member Reported by vadimsh@chromium.org, Apr 11 2017 
This CL deleted a bunch of projects: https://chrome-internal.googlesource.com/infradata/config/+/90c35b4a75e354ec2bb8654581ea7c20114db95d

The correctly disappeared from config.get_projects API and config.get_project_configs API outputs.

But config.get_config(<deleted project set>, config) API still returns old config from removed project: https://apis-explorer.appspot.com/apis-explorer/?base=https://luci-config.appspot.com/_ah/api#p/config/v1/config.get_config?config_set=projects%252Fcobalt&path=luci-scheduler.cfg&_h=4&

This trips LUCI Scheduler that uses config.get_config(<project>, "luci-scheduler.cfg") to fetch job configurations.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/external/github.com/luci/luci-go.git/+/5d8ab084ffb1e53647bb2ced4a55e3f406f838db

commit 5d8ab084ffb1e53647bb2ced4a55e3f406f838db
Author: vadimsh <vadimsh@chromium.org>
Date: Wed Apr 12 00:48:51 2017

luci-scheduler: Workaround for luci-config reporting ghost configs.

R=nodir@chromium.org
BUG=710619

Review-Url: https://codereview.chromium.org/2817603002

[modify] https://crrev.com/5d8ab084ffb1e53647bb2ced4a55e3f406f838db/scheduler/appengine/catalog/catalog.go

Comment 2 by estaab@chromium.org, Jun 22 2017

Labels: -Pri-3 Pri-2
Status: Available (was: Untriaged)

Comment 3 by no...@chromium.org, Jul 12 2017 

luci-config never deletes data that it ever imported, so anyone can load an old revision of a config.

however, listing APIs (get_projects, get_project_configs, get_ref_configs, get_config_sets) should not return deleted config sets. I think https://cs.chromium.org/chromium/infra/go/src/github.com/luci/luci-go/scheduler/appengine/frontend/handler.go?type=cs&q=config+file:%5Einfra/go/src/github%5C.com/luci/luci-go/scheduler/appengine/+package:%5Echromium$&l=221 must unregister projects not returned by luci-config

Comment 4 by vadimsh@chromium.org, Jul 12 2017 

I can accept this explanation for "historical" pinned configs, that are referenced by some hash or git revision.

But get_config(...) call asking for most recent config should not return non-existing configs.

E.g. this call should not return HTTP 200: https://apis-explorer.appspot.com/apis-explorer/?base=https://luci-config.appspot.com/_ah/api#p/config/v1/config.get_config?config_set=projects%252Fcobalt&path=luci-scheduler.cfg&_h=1&

This config doesn't exist now (and I'm asking for "now", because I do not specify 'revision').
Project Member

Comment 5 by sheriffbot@chromium.org, Jul 12

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 6 by mar...@chromium.org, Jul 26

Labels: -Hotlist-Recharge-Cold
Status: Available (was: Untriaged)
Is this important?
►

Sign in to add a comment