New issue
Advanced search Search tips

Issue 710572 link

Starred by 1 user
Status: Fixed
Owner:
rch@chromium.org
Closed: Apr 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[Chromecast] ServerSetDoNotFragment failing on device

Project Member Reported by mbjorge@chromium.org, Apr 11 2017 
[20238/20238] WebSocketEndpointLockManagerTest.SocketAssociationForgottenOnUnlock (0 ms)
Retrying 11 tests (retry #1)
[ RUN      ] UDPSocketTest.ServerSetDoNotFragment
[6440:6440:0411/071919.369528:1279645555:INFO:udp_socket_unittest.cc(603)] ip: 127.0.0.1
[6440:6440:0411/071919.370325:1279646344:INFO:udp_socket_unittest.cc(603)] ip: ::1
../../net/socket/udp_socket_unittest.cc:611: Failure
Value of: rv
Expected: net::OK
  Actual: -109, net::ERR_ADDRESS_UNREACHABLE
[6440:6440:0411/071919.370936:1279646956:FATAL:udp_socket_posix.cc(515)] Check failed: socket_ != kInvalidSocket (-1 vs. -1)

Comment 1 by mbjorge@chromium.org, Apr 11 2017

Owner: rch@chromium.org
Seems to be failing on the ::1 IPv6 case. The test code actually has some logic to handle IPv6 not being configured: https://cs.chromium.org/chromium/src/net/socket/udp_socket_unittest.cc?dr=C&q=ServerSetDoNotFragment&l=601

In ClientSetDoNotFragment it checks for rv == ERR_ADDRESS_UNREACHABLE
in ServerSetDoNotFragment though it checks for rv == ERR_ADDRESS_INVALID

Code was added in https://codereview.chromium.org/2235973002

@rch, is the difference int he check rv value intentional? Or should either value be accepted to return early in the test
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/58d40e4d8570ce25575e42709c6b534124a99612

commit 58d40e4d8570ce25575e42709c6b534124a99612
Author: mbjorge <mbjorge@chromium.org>
Date: Wed Apr 12 20:43:03 2017

Change UDPSocketTest.ServerSetDoNotFragment to ignore ERR_ADDRESS_UNREACHABLE errors when binding to IPv6.

BUG= 710572 

Review-Url: https://codereview.chromium.org/2809993003
Cr-Commit-Position: refs/heads/master@{#464140}

[modify] https://crrev.com/58d40e4d8570ce25575e42709c6b534124a99612/net/socket/udp_socket_unittest.cc

Comment 3 by mbjorge@chromium.org, Apr 13 2017

Status: Fixed (was: Untriaged)
►

Sign in to add a comment