Change alpha values for the overlay scrollbars to be more visible |
||||||||
Issue descriptionI modified the spec as followed: Small thumb needs its fill alpha to be bumped to 50% (30% previously) for white and black Big thumb needs its fill alpha to be bumped to 70% (50% previously) for white and black. Spec link: https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZZ81wHrRDEfC/files/MCF9SfqrxP8nO1BIdlsZaMEjwMSJbxAVNpw
,
Apr 13 2017
Just to clarify, we don't (and currently can't) repaint the thumb on expansion, the color and alpha only change when the mouse is actually over the scrollbar.
,
Apr 13 2017
i assume this also applies to the native overlay bars (i.e. in system menu etc.)?
,
Apr 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9dd1986a8ffdd33a72ebab4063752c973f69432c commit 9dd1986a8ffdd33a72ebab4063752c973f69432c Author: bokan <bokan@chromium.org> Date: Thu Apr 13 16:11:04 2017 Update alpha values when painting overlay scrollbars. Bumped up to make scrollbars more visible, as requested by UI review. BUG= 710550 Review-Url: https://codereview.chromium.org/2815833005 Cr-Commit-Position: refs/heads/master@{#464429} [modify] https://crrev.com/9dd1986a8ffdd33a72ebab4063752c973f69432c/ui/native_theme/native_theme_aura.cc
,
Apr 13 2017
Assuming it also applies to native overlays, assigning to estade@ to do that side.
,
Apr 13 2017
,
Apr 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/41aea3751213e055f31f13d449bf21518432c6cf commit 41aea3751213e055f31f13d449bf21518432c6cf Author: estade <estade@chromium.org> Date: Tue Apr 18 19:17:09 2017 Adjust overlay scrollbar appearance. - share more constants between Blink and native (Views) - make Views paint a 1px stroke instead of a 1dip stroke, and update constants as per latest spec. - fix a bug with Blink overlay scrollbars where stroke was painted on all sides instead of just three sides. BUG= 710550 Review-Url: https://codereview.chromium.org/2818033002 Cr-Commit-Position: refs/heads/master@{#465319} [modify] https://crrev.com/41aea3751213e055f31f13d449bf21518432c6cf/ui/native_theme/native_theme_aura.cc [modify] https://crrev.com/41aea3751213e055f31f13d449bf21518432c6cf/ui/native_theme/overlay_scrollbar_constants_aura.h [modify] https://crrev.com/41aea3751213e055f31f13d449bf21518432c6cf/ui/views/controls/scrollbar/overlay_scroll_bar.cc
,
Apr 20 2017
I think the patch in #7 needs to be merged to 59, right?
,
Apr 20 2017
yea, should be merged
,
Apr 20 2017
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fa5b15157ef0dee2e2969115095a1a97bf0323d4 commit fa5b15157ef0dee2e2969115095a1a97bf0323d4 Author: Evan Stade <estade@chromium.org> Date: Thu Apr 20 22:52:06 2017 Adjust overlay scrollbar appearance. - share more constants between Blink and native (Views) - make Views paint a 1px stroke instead of a 1dip stroke, and update constants as per latest spec. - fix a bug with Blink overlay scrollbars where stroke was painted on all sides instead of just three sides. BUG= 710550 Review-Url: https://codereview.chromium.org/2818033002 Cr-Commit-Position: refs/heads/master@{#465319} (cherry picked from commit 41aea3751213e055f31f13d449bf21518432c6cf) Review-Url: https://codereview.chromium.org/2830163002 . Cr-Commit-Position: refs/branch-heads/3071@{#104} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} [modify] https://crrev.com/fa5b15157ef0dee2e2969115095a1a97bf0323d4/ui/native_theme/native_theme_aura.cc [modify] https://crrev.com/fa5b15157ef0dee2e2969115095a1a97bf0323d4/ui/native_theme/overlay_scrollbar_constants_aura.h [modify] https://crrev.com/fa5b15157ef0dee2e2969115095a1a97bf0323d4/ui/views/controls/scrollbar/overlay_scroll_bar.cc
,
Apr 26 2017
,
May 16 2017
9557.0.0, 60.0.3101.0 |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by bokan@chromium.org
, Apr 12 2017Labels: -Restrict-View-Google -Pri-2 Hotlist-Input-Dev OS-Chrome Pri-1