Dialog showModal() causes unnecessary full-document layout
Reported by
a...@scirra.com,
Apr 11 2017
|
|||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/59.0.3068.1 Safari/537.36 Steps to reproduce the problem: 1. Visit https://editor.construct.net 2. Open dev tools Performance tab, start recording 3. Click Menu -> About, and close the dialog 4. Repeat step 3 a few times 5. End the profile and inspect results What is the expected behavior? Reasonable layout performance. What went wrong? On a high-end desktop development machine, the showModal() call results in a ~22ms layout. On a low-end machine this could easily be a fraction of a second. The main problem is that showing a dialog that floats on top of the existing document should not cause a full layout of the entire document again - it doesn't affect it. Secondly, 22ms is a pretty slow layout time even for the full document, since there doesn't seem to be that much going on. Did this work before? N/A Does this work in other browsers? N/A Chrome version: 59.0.3068.1 Channel: canary OS Version: 10.0 Flash Version:
,
Apr 12 2017
Tested this on Windows-10, chrome version: 59.0.3068.1 and attached is the screenshot of the observation. @reporter: Could you please help with the exact metrice to look for the layout performance. Thanks in advance!
,
Apr 12 2017
Look for the showModal call near the start of an animation. It looks like this: https://dl.dropboxusercontent.com/u/15217362/chrome-showmodal-layouttime.png
,
Apr 12 2017
Thank you for providing more feedback. Adding requester "ajha@chromium.org" to the cc list and removing "Needs-Feedback" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 18 2017
We might want to use contains: strict on showModal.
,
Apr 21 2017
Removing Needs-Triage-M59 label as per comment #5 Thanks.
,
Jul 6 2017
contain: strict on the <dialog> would force dialogs to have to have an explicit size, since strict containment does layout as if the element was empty. Surely contain: content would be more appropriate?
,
Jul 6
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 9
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by ranjitkan@chromium.org
, Apr 12 2017