New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 710522 link

Starred by 1 user
Status: Fixed
Owner:
chanli@chromium.org
Closed: Apr 2017
Cc:
█ robert...@chromium.org
lijeffrey@chromium.org
chanli@chromium.org
liaoyuke@chromium.org
st...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: ----

Blocking:
issue 708324



Sign in to add a comment

False positive even though compile failed at good revision

Project Member Reported by st...@chromium.org, Apr 11 2017 
Url to the build Failure:
https://luci-milo.appspot.com/buildbot/chromium.chrome/Google Chrome ChromeOS/32152

What is the bug or feature:
This is a flaky compile due to incorrect gn config for dependency on a generated header file.
In this case, Findit should not return any suspect.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/68ef932b2657f8548ec3bce5f7685d00cf83fd20

commit 68ef932b2657f8548ec3bce5f7685d00cf83fd20
Author: Chan <chanli@chromium.org>
Date: Tue Apr 11 18:53:14 2017

[Findit] Always use culprit from compile try job result report.

Bug:  710522 
Change-Id: Id13217c62a4d057a83a809959f079d2798ac342e
Reviewed-on: https://chromium-review.googlesource.com/474236
Commit-Queue: Chan Li <chanli@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Reviewed-by: Roberto Carrillo <robertocn@chromium.org>

[modify] https://crrev.com/68ef932b2657f8548ec3bce5f7685d00cf83fd20/appengine/findit/waterfall/identify_try_job_culprit_pipeline.py
[modify] https://crrev.com/68ef932b2657f8548ec3bce5f7685d00cf83fd20/appengine/findit/waterfall/test/identify_try_job_culprit_pipeline_test.py

Comment 2 by chanli@chromium.org, Apr 11 2017

Status: Fixed (was: Assigned)

Comment 3 by chanli@chromium.org, Apr 13 2017

Blocking: 708324
►

Sign in to add a comment