New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 710508 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----

Blocking:
issue 708324



Sign in to add a comment

[Findit] Notification sent, but the try job related to the CL seemed exceptioned out

Project Member Reported by chanli@chromium.org, Apr 11 2017

Issue description

Comment 1 by chanli@chromium.org, Apr 11 2017

Owner: chanli@chromium.org
Status: Started (was: Available)

Comment 2 by chanli@chromium.org, Apr 11 2017

Findings: 
1. https://build.chromium.org/p/tryserver.chromium.android/builders/android_chromium_variable/builds/420/steps/steps/logs/err.text

2. Buildbucket set this try job as 'COMPLETED'

3. Although the try job exceptioned out, I can still get report from Logdog.


Need to fix the "File name too long" issue in 1 and also change on Findit side to avoid adding culprit for such try jobs.

Comment 3 by st...@chromium.org, Apr 12 2017

2. If it is not expected to be COMPLETED, we may want to talk to nodir@ and check whether it is a bug on the buildbucket side.

3. There is no report log, why we still could retrieve the result?

Comment 4 by st...@chromium.org, Apr 12 2017

For "File name too long", we could file a separate bug to track that and cc jbudorick@. I believe he will be able to help out or find someone else to fix it.

Possible workaround on our recipe side is to shorten the wrapping step names which contains the whole git hash like "test 011ef8d97d0b06877ca4cfc621d2e56f19aeef8c".

Comment 5 by chanli@chromium.org, Apr 12 2017

2. I'll contact nodir@ about this.

3. We added the report in finally block. I'm not sure why we don't see the step on build page, but the log exists.

Comment 6 by st...@chromium.org, Apr 12 2017

3. Seems like a bug in Logdog integration with buildbot?

Comment 8 by chanli@chromium.org, Apr 12 2017

So the buildbucket should work normal, the result is "FAILURE" and failure_reason is "INFRA FAILURE". 

As for the report, I think Logdog works normal? It's more of a bug to me why there is no report and failure reason on build page like other build failures.

Blocking: 708324
Project Member

Comment 11 by bugdroid1@chromium.org, Apr 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/1d58c5e2f2b5afbf0c163d49d52f352df8c0ca5e

commit 1d58c5e2f2b5afbf0c163d49d52f352df8c0ca5e
Author: Chan <chanli@chromium.org>
Date: Fri Apr 14 20:36:07 2017

[Findit] Change test.py to deflake by running on good_revision.

1. Add a flag to allow defalke by running on good_revision.
  a. Only runs on tests that failed on the first revision in range.
  b. If some of the tests also failed on good_revision, remove them from culprits and add to flakes.
2. Also, only add culprits to report if the try job completes.
3. Add a field for iterations to run a test, default to 20.

Bug:  710508 
Change-Id: I92bb840ba62cee7d1b021eb3382eba82ef98fa5c
Reviewed-on: https://chromium-review.googlesource.com/474988
Commit-Queue: Chan Li <chanli@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>

[modify] https://crrev.com/1d58c5e2f2b5afbf0c163d49d52f352df8c0ca5e/scripts/slave/recipes/findit/chromium/test.expected/findit_steps_multiple_culprits.json
[modify] https://crrev.com/1d58c5e2f2b5afbf0c163d49d52f352df8c0ca5e/scripts/slave/recipes/findit/chromium/test.expected/unaffected_test_skipped_by_analyze.json
[modify] https://crrev.com/1d58c5e2f2b5afbf0c163d49d52f352df8c0ca5e/scripts/slave/recipes/findit/chromium/test.expected/findit_consecutive_culprits.json
[modify] https://crrev.com/1d58c5e2f2b5afbf0c163d49d52f352df8c0ca5e/scripts/slave/recipes/findit/chromium/test.expected/only_one_test_passed.json
[add] https://crrev.com/1d58c5e2f2b5afbf0c163d49d52f352df8c0ca5e/scripts/slave/recipes/findit/chromium/test.expected/flaky_tests.json
[modify] https://crrev.com/1d58c5e2f2b5afbf0c163d49d52f352df8c0ca5e/scripts/slave/recipes/findit/chromium/test.expected/use_analyze_set_to_False_for_non_linear_try_job.json
[modify] https://crrev.com/1d58c5e2f2b5afbf0c163d49d52f352df8c0ca5e/scripts/slave/recipes/findit/chromium/test.expected/findit_culprit_in_last_sub_range.json
[modify] https://crrev.com/1d58c5e2f2b5afbf0c163d49d52f352df8c0ca5e/scripts/slave/recipes/findit/chromium/test.expected/all_test_failed.json
[modify] https://crrev.com/1d58c5e2f2b5afbf0c163d49d52f352df8c0ca5e/scripts/slave/recipes/findit/chromium/test.py
[modify] https://crrev.com/1d58c5e2f2b5afbf0c163d49d52f352df8c0ca5e/scripts/slave/recipes/findit/chromium/test.expected/findit_tests_multiple_culprits.json
[modify] https://crrev.com/1d58c5e2f2b5afbf0c163d49d52f352df8c0ca5e/scripts/slave/recipes/findit/chromium/test.expected/use_build_parameter_for_tests.json
[modify] https://crrev.com/1d58c5e2f2b5afbf0c163d49d52f352df8c0ca5e/scripts/slave/recipes/findit/chromium/test.expected/none_swarming_tests.json
[modify] https://crrev.com/1d58c5e2f2b5afbf0c163d49d52f352df8c0ca5e/scripts/slave/recipes/findit/chromium/test.expected/findit_culprit_in_first_sub_range.json
[modify] https://crrev.com/1d58c5e2f2b5afbf0c163d49d52f352df8c0ca5e/scripts/slave/recipes/findit/chromium/test.expected/all_test_passed.json
[modify] https://crrev.com/1d58c5e2f2b5afbf0c163d49d52f352df8c0ca5e/scripts/slave/recipes/findit/chromium/test.expected/findit_culprit_in_middle_sub_range.json
[modify] https://crrev.com/1d58c5e2f2b5afbf0c163d49d52f352df8c0ca5e/scripts/slave/recipes/findit/chromium/test.expected/swarming_tests.json

Status: Fixed (was: Started)

Sign in to add a comment