New issue
Advanced search Search tips

Issue 710501 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Eliminate linux_chromium_gn_* trybots

Project Member Reported by steve...@chromium.org, Apr 11 2017

Issue description

We still have the following trybots listed:

 linux_chromium_gn_chromeos_dbg
 linux_chromium_gn_chromeos_rel
 linux_chromium_gn_upload

I assume these are all redundant now and can be removed from the (already very long) list?

 
Owner: dpranke@chromium.org
Status: Assigned (was: Untriaged)
linux_chromium_gn_upload is actually the builder that builds the release versions of the GN binaries, so we still need it, but we can remove the other two, yes.
Ah, that makes sense.

BTW, is _ng still relevant? It makes already lengthy and confusing builder names that much more so, e.g. linux_chromium_chromeos_compile_rel_ng

No, it's not, but renaming builders is an errorprone and risky process, for stupid reasons.

I think we'll clean up the names as part of moving off of buildbot, though, which is coming soon.
OK, sgtm, thanks!
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/b1a7d712f761e01acbfc82d4970deeee495a1034

commit b1a7d712f761e01acbfc82d4970deeee495a1034
Author: Dirk Pranke <dpranke@chromium.org>
Date: Fri Apr 14 23:59:04 2017

Remove no-longer needed chromeos GN tryservers.

R=stevenjb@chromium.org
BUG= 710501 

Change-Id: I16c4e0147e22395a9b9c63a211f6ff61a8292613
Reviewed-on: https://chromium-review.googlesource.com/474971
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>

[modify] https://crrev.com/b1a7d712f761e01acbfc82d4970deeee495a1034/masters/master.tryserver.chromium.linux/slaves.cfg
[modify] https://crrev.com/b1a7d712f761e01acbfc82d4970deeee495a1034/masters/master.tryserver.chromium.linux/master.cfg

Project Member

Comment 7 by bugdroid1@chromium.org, Apr 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/aa5b745742c9e3c11613bb78fc732b4249240c5e

commit aa5b745742c9e3c11613bb78fc732b4249240c5e
Author: Dirk Pranke <dpranke@chromium.org>
Date: Mon Apr 17 19:55:10 2017

Remove linux_chromium_gn_chromeos_variable builder.

This removes the linux_chromium_gn_chromeos_variable builder from
tryserver.chromium.linux; the builder it was mirroring is gone.

R=stgao@chromium.org
BUG= 710501 

Change-Id: I2acefd39ceea9276c0326070713152369f3e8346
Reviewed-on: https://chromium-review.googlesource.com/478870
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Reviewed-by: Jeffrey Li <lijeffrey@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>

[modify] https://crrev.com/aa5b745742c9e3c11613bb78fc732b4249240c5e/masters/master.tryserver.chromium.linux/slaves.cfg
[modify] https://crrev.com/aa5b745742c9e3c11613bb78fc732b4249240c5e/masters/master.tryserver.chromium.linux/master.cfg

Status: Fixed (was: Assigned)

Comment 9 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 10 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment