[WestingHouse][O] Ensure there's no IA loop |
|||||
Issue descriptionReported in https://buganizer.corp.google.com/issues/37014744 I know we have the other bugs (tripit, dashlane, buzzfeed), but in case this is a different scenario, filing a formal bug. Steps: 1. Load an AIA link list in Gmail 2. Turn on airplane mode (notification shade, airplane mode icon) 3. Click an AIA link Observed: Crash looping, any AIA link Expected: No crash loop, I expect Chrome to open and say no connectivity Build is golden build as of 4/4/17 from http://go/aia-o-setup
,
Apr 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5a927f0f8dfc60e4309662fd6c68655785be6ab9 commit 5a927f0f8dfc60e4309662fd6c68655785be6ab9 Author: mariakhomenko <mariakhomenko@chromium.org> Date: Tue Apr 11 18:22:16 2017 Check for DO_NOT_LAUNCH flag on O. BUG= 710497 Review-Url: https://codereview.chromium.org/2808383003 Cr-Commit-Position: refs/heads/master@{#463689} [modify] https://crrev.com/5a927f0f8dfc60e4309662fd6c68655785be6ab9/chrome/android/java/src/org/chromium/chrome/browser/instantapps/InstantAppsHandler.java
,
Apr 11 2017
,
Apr 11 2017
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/65277eec45adf8274da264b65d9dd8745f664b76 commit 65277eec45adf8274da264b65d9dd8745f664b76 Author: Maria Khomenko <mariakhomenko@chromium.org> Date: Tue Apr 11 22:47:35 2017 Check for DO_NOT_LAUNCH flag on O. BUG= 710497 Review-Url: https://codereview.chromium.org/2808383003 Cr-Commit-Position: refs/heads/master@{#463689} (cherry picked from commit 5a927f0f8dfc60e4309662fd6c68655785be6ab9) Review-Url: https://codereview.chromium.org/2814923002 . Cr-Commit-Position: refs/branch-heads/3029@{#670} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} [modify] https://crrev.com/65277eec45adf8274da264b65d9dd8745f664b76/chrome/android/java/src/org/chromium/chrome/browser/instantapps/InstantAppsHandler.java
,
Apr 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8152d2adcabba8e58d47308f233f2619230fe711 commit 8152d2adcabba8e58d47308f233f2619230fe711 Author: mariakhomenko <mariakhomenko@chromium.org> Date: Tue Apr 11 23:51:40 2017 Instant Apps: Be extra safe with the flag check. I just thought of the possibility that OEMs may have found other uses for unused flag ids. This flag is only defined in O, so let's only check for it in O to ensure we aren't capturing any weird OEM-customized edge cases. BUG= 710497 Review-Url: https://codereview.chromium.org/2813993002 Cr-Commit-Position: refs/heads/master@{#463841} [modify] https://crrev.com/8152d2adcabba8e58d47308f233f2619230fe711/chrome/android/java/src/org/chromium/chrome/browser/instantapps/InstantAppsHandler.java
,
Apr 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cb65deb6746cd262ff82bef478127e34d0110fd2 commit cb65deb6746cd262ff82bef478127e34d0110fd2 Author: Maria Khomenko <mariakhomenko@chromium.org> Date: Wed Apr 12 00:32:59 2017 Instant Apps: Be extra safe with the flag check. I just thought of the possibility that OEMs may have found other uses for unused flag ids. This flag is only defined in O, so let's only check for it in O to ensure we aren't capturing any weird OEM-customized edge cases. BUG= 710497 Review-Url: https://codereview.chromium.org/2813993002 Cr-Commit-Position: refs/heads/master@{#463841} (cherry picked from commit 8152d2adcabba8e58d47308f233f2619230fe711) Review-Url: https://codereview.chromium.org/2808203004 . Cr-Commit-Position: refs/branch-heads/3029@{#674} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} [modify] https://crrev.com/cb65deb6746cd262ff82bef478127e34d0110fd2/chrome/android/java/src/org/chromium/chrome/browser/instantapps/InstantAppsHandler.java
,
Apr 12 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by mariakho...@chromium.org
, Apr 11 2017