Consistently process |getter|, |setter|, |initial| method name overrides in all consumers of CSSProperties.json5. |
|||
Issue descriptionIn particular, the manual patch pointed out in https://chromium-review.googlesource.com/c/472428/3/third_party/WebKit/Source/build/scripts/make_computed_style_base.py#132 is wrong: - It only takes into account |getter|, but not |setter| and |initial| - It tries to dance around |<getter>IsInherited| names in a hackish and most likely incorrect way
,
Apr 11 2017
,
Apr 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4b44200a3a78e42f34af7f888ebb6e68ee7b1687 commit 4b44200a3a78e42f34af7f888ebb6e68ee7b1687 Author: shend <shend@chromium.org> Date: Thu Apr 13 04:34:10 2017 Respect method name overrides in make_computed_style_base.py. Currently make_computed_style_base.py ignores any overrides to the setter and initial method names in CSSProperties.json5. This patch ensures that the generator uses the overridden names (which are already handled in its parent class, StyleBuilderWriter, and stored in property_['setter'] and property_['initial']). This patch does not change any generated code. BUG= 710496 Review-Url: https://codereview.chromium.org/2811183004 Cr-Commit-Position: refs/heads/master@{#464295} [modify] https://crrev.com/4b44200a3a78e42f34af7f888ebb6e68ee7b1687/third_party/WebKit/Source/build/scripts/make_computed_style_base.py
,
Apr 13 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by shend@chromium.org
, Apr 11 2017Owner: shend@chromium.org