Issue metadata
Sign in to add a comment
|
WebViewTests/WebViewTest.Shim_TestFindAPI_findupdate pretty flaky on the msan bots |
||||||||||||||||||||
Issue descriptione.g. here https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.memory.full%2FLinux_ChromeOS_MSan_Tests%2F6220%2F%2B%2Frecipes%2Fsteps%2Fbrowser_tests%2F0%2Flogs%2FWebViewTests_WebViewTest.Shim_TestFindAPI_findupdate_0%2F0 [7505:7505:0403/174043.830966:INFO:CONSOLE(92)] "assertion failed: cat != dog", source: chrome-extension://ofnmegkahkmpbnpommippnckdojabhpe/main.js (92) ../../chrome/browser/apps/guest_view/web_view_browsertest.cc:668: Failure Value of: done_listener.WaitUntilSatisfied() Actual: false Expected: true [7505:7505:0403/174043.863979:INFO:CONSOLE(92)] "assertion failed: 10 != 100", source: chrome-extension://ofnmegkahkmpbnpommippnckdojabhpe/main.js (92) etc. browser_tests was pretty happy until about April 3, since then it's pretty flaky due to this test.
,
Apr 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7cefc60264ab620406f71fdb27e817b406465e94 commit 7cefc60264ab620406f71fdb27e817b406465e94 Author: thakis <thakis@chromium.org> Date: Thu Apr 13 17:56:05 2017 Update bug numbers of disabled MSan tests. https://codereview.chromium.org/2817443004/ used a tracking bug as TODO for various tests failing on MSan. Used one targeted bug per failing test instead. BUG= 697171 , 711318 , 709341 ,710486 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel TBR=danakj,dalecurtis Review-Url: https://codereview.chromium.org/2818763002 Cr-Commit-Position: refs/heads/master@{#464463} [modify] https://crrev.com/7cefc60264ab620406f71fdb27e817b406465e94/cc/tiles/gpu_image_decode_cache_unittest.cc [modify] https://crrev.com/7cefc60264ab620406f71fdb27e817b406465e94/chrome/browser/apps/guest_view/web_view_browsertest.cc [modify] https://crrev.com/7cefc60264ab620406f71fdb27e817b406465e94/media/renderers/video_renderer_impl_unittest.cc
,
May 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f5bea1f45cd62b26b49e4b8cd1ee1ad096351717 commit f5bea1f45cd62b26b49e4b8cd1ee1ad096351717 Author: paulmeyer <paulmeyer@chromium.org> Date: Thu May 04 18:27:53 2017 Fix for flaky WebViewTest.Shim_TestFindAPI_findupdate test on msan bots. Part of what this test tests is canceling an in-progress find session by searching for another search term. The problem that was causing the flakiness was that the find session that was meant to get canceled actually finished (rarely) before the subsequent request made it to the renderer, and so the completed session was not reported as canceled. The small adjustment made in this CL is to only attempt to cancel the search that has many results, so that its find session is much less likely to complete before the next find request comes through. BUG=710486 Review-Url: https://codereview.chromium.org/2857953004 Cr-Commit-Position: refs/heads/master@{#469390} [modify] https://crrev.com/f5bea1f45cd62b26b49e4b8cd1ee1ad096351717/chrome/test/data/extensions/platform_apps/web_view/shim/main.js
,
May 4 2017
,
May 4 2017
Don't you need to renable the test too?
,
May 4 2017
*reenable
,
May 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2a3f50f3684ccd28c4eb5160909a9cb3d64c9187 commit 2a3f50f3684ccd28c4eb5160909a9cb3d64c9187 Author: paulmeyer <paulmeyer@chromium.org> Date: Thu May 04 20:59:30 2017 Reenable WebViewTests/WebViewTest.Shim_TestFindAPI_findupdate. BUG=710486 TBR=wjmaclean@chromium.org Review-Url: https://codereview.chromium.org/2863633003 Cr-Commit-Position: refs/heads/master@{#469465} [modify] https://crrev.com/2a3f50f3684ccd28c4eb5160909a9cb3d64c9187/chrome/browser/apps/guest_view/web_view_browsertest.cc
,
May 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f92fd977be7cd346c693e88e8de19ee4e3b914b3 commit f92fd977be7cd346c693e88e8de19ee4e3b914b3 Author: johnme <johnme@chromium.org> Date: Fri May 05 10:58:01 2017 Revert of Reenable WebViewTests/WebViewTest.Shim_TestFindAPI_findupdate. (patchset #1 id:1 of https://codereview.chromium.org/2863633003/ ) Reason for revert: This test immediately started flaking heavily on the MSAN bots. Original issue's description: > Reenable WebViewTests/WebViewTest.Shim_TestFindAPI_findupdate. > > BUG=710486 > TBR=wjmaclean@chromium.org > > Review-Url: https://codereview.chromium.org/2863633003 > Cr-Commit-Position: refs/heads/master@{#469465} > Committed: https://chromium.googlesource.com/chromium/src/+/2a3f50f3684ccd28c4eb5160909a9cb3d64c9187 TBR=paulmeyer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=710486 Review-Url: https://codereview.chromium.org/2858393004 Cr-Commit-Position: refs/heads/master@{#469623} [modify] https://crrev.com/f92fd977be7cd346c693e88e8de19ee4e3b914b3/chrome/browser/apps/guest_view/web_view_browsertest.cc
,
May 5 2017
Unfortunately, the test started flaking heavily as soon as it was re-enabled, with failures like: [27968:27968:0504/153853.518286:INFO:CONSOLE(92)] "assertion failed: dog != cat", source: chrome-extension://bjeodlgnchgjbiglapdooknacnngcflb/main.js (92) ../../chrome/browser/apps/guest_view/web_view_browsertest.cc:660: Failure Value of: done_listener.WaitUntilSatisfied() Actual: false Expected: true https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.memory%2FLinux_MSan_Tests%2F587%2F%2B%2Frecipes%2Fsteps%2Fbrowser_tests%2F0%2Flogs%2FWebViewTests__x2f_WebViewTest.Shim_TestFindAPI_findupdate__x2f_0%2F0 So I had to revert the re-enabling (see #8).
,
Oct 17 2017
,
Apr 24 2018
WebViewTests currently have 23 bugs filed on them, most in the last month: https://bugs.chromium.org/p/chromium/issues/list?can=2&q=WebViewTests&colspec=ID+Pri+M+Stars+ReleaseBlock+Component+Status+Owner+Summary+OS+Modified&x=m&y=releaseblock&cells=ids Can we disable them: They seem to cause all kinds of issues all over the place.
,
Aug 3
This bug has an owner, thus, it's been triaged. Changing status to "assigned". |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by lfg@chromium.org
, Apr 11 2017Components: Platform>Apps>BrowserTag
Owner: paulmeyer@chromium.org