Strip only whitespace per the set defined by HTML in SVG attributes |
|||
Issue descriptionWe're not consistent with what is considered whitespace and not depending on the context. We should try to stick to one definition, and use the "ASCII whitespace" defintion [1] as used by HTML. The wider (Unicode; WS) definition seems to be used primarily (exclusively?) in SMIL (parsing) code. [1] https://infra.spec.whatwg.org/#ascii-whitespace
,
Apr 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cd2205139c375696291bffcf86d27ef4e83d7994 commit cd2205139c375696291bffcf86d27ef4e83d7994 Author: fs <fs@opera.com> Date: Tue Apr 11 17:08:49 2017 Strip only ASCII spaces from SMIL 'values' attributes This is more consistent with other microsyntaxes used for attribute parsing, while also making it consistent with the XSSAuditor. BUG= 709365 , 710460 Review-Url: https://codereview.chromium.org/2807193003 Cr-Commit-Position: refs/heads/master@{#463662} [add] https://crrev.com/cd2205139c375696291bffcf86d27ef4e83d7994/third_party/WebKit/LayoutTests/svg/animations/animate-values-whitespace.html [modify] https://crrev.com/cd2205139c375696291bffcf86d27ef4e83d7994/third_party/WebKit/Source/core/svg/SVGAnimationElement.cpp
,
Apr 12 2018
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 12 2018
All done with this?
,
Aug 21
There are a few left: renderer/core/svg/animation/svg_smil_element.cc:356: String parse = data.StripWhiteSpace(); renderer/core/svg/animation/svg_smil_element.cc:376: String parse = data.StripWhiteSpace(); renderer/core/svg/animation/svg_smil_element.cc:414: String parse_string = value.StripWhiteSpace(); renderer/core/svg/animation/svg_smil_element.cc:429: condition_string = parse_string.Left(pos).StripWhiteSpace(); renderer/core/svg/animation/svg_smil_element.cc:430: String offset_string = parse_string.Substring(pos + 1).StripWhiteSpace(); renderer/core/svg/svg_animated_color.cc:32: if (CSSParser::ParseColor(color, color_string.StripWhiteSpace())) renderer/core/svg/svg_animation_element.cc:81: String time_string = parse_list[n].StripWhiteSpace(); |
|||
►
Sign in to add a comment |
|||
Comment 1 by schenney@chromium.org
, Apr 11 2017