clang tot broken with -Wunused-function warnings, probably after clang r299930 |
||||||||
Issue descriptionhttps://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.fyi%2FClangToTMac%2F13669%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout FAILED: obj/base/base/task_annotator.o export DEVELOPER_DIR=/b/c/b/ClangToTMac/src/build/mac_files/Xcode.app; ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/base/base/task_annotator.o.d -DSYSTEM_NATIVE_UTF8 -DV8_DEPRECATION_WARNINGS -DNO_TCMALLOC -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DENABLE_MEDIA_ROUTER=1 -DFIELDTRIAL_TESTING_ENABLED -DCR_CLANG_REVISION=\"299942\" -DCR_XCODE_VERSION=0511 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 -DCOMPONENT_BUILD -D__ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORE=0 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DBASE_IMPLEMENTATION -I../.. -Igen -fno-strict-aliasing -fstack-protector -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= -fcolor-diagnostics -arch x86_64 -Wall -Werror -Wextra -Wpartial-availability -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-address-of-packed-member -Wno-unused-lambda-capture -Wno-user-defined-warnings -fno-omit-frame-pointer -g1 -isysroot /b/c/b/ClangToTMac/src/build/mac_files/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk -mmacosx-version-min=10.9 -fvisibility=hidden -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -Wno-char-subscripts -Wexit-time-destructors -Wexit-time-destructors -O2 -fvisibility-inlines-hidden -std=c++11 -stdlib=libc++ -fno-rtti -fno-exceptions -include obj/base/base/precompile.h-cc -c ../../base/debug/task_annotator.cc -o obj/base/base/task_annotator.o In file included from ../../base/debug/task_annotator.cc:12: ../../base/trace_event/trace_event.h:1011:13: error: unused function 'AddMetadataEvent' [-Werror,-Wunused-function] static void AddMetadataEvent(const unsigned char* category_group_enabled, ^ 1 error generated. There might be more.
,
Apr 11 2017
Linux too: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.fyi%2FClangToTLinux__dbg_%2F5878%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout
,
Apr 11 2017
Windows has a separate error too:
FAILED: obj/breakpad/dump_syms/omap.obj
../../third_party/llvm-build/Release+Asserts/bin/clang-cl.exe /nologo /showIncludes /FC @obj/breakpad/dump_syms/omap.obj.rsp /c ../../breakpad/src/common/windows/omap.cc /Foobj/breakpad/dump_syms/omap.obj /Fd"obj/breakpad/dump_syms_cc.pdb"
C:\b\c\b\ClangToTWin_dbg_\src\breakpad\src\common\windows\omap.cc(126,10): error: unused function 'Max' [-Werror,-Wunused-function]
const T& Max(const T& t1, const T& t2) { return t1 > t2 ? t1 : t2; }
^
1 error generated.
Maybe it makes sense to ask upstream to put this behind -Wunused-template-function or something like that, so we can clean it up async. (I'd try building locally and see just how often this fires now with -Werror removed, and if it's a lot then putting this behind a separate flag will be useful for others too eventually. If it's just 3 files, might as well fix.)
I'll stop looking at this now, sorry :-)
,
Apr 11 2017
The warning was reverted in r299956 as it fired all over libc++ I'll attach my build log to see where this is firing, but marking this closed for now.
,
Apr 11 2017
,
Apr 11 2017
Looking forward to the attachment :-) If it fires a lot, we should still suggest a separate warning flag, ideally before it relands.
,
Apr 11 2017
Yup, I did suggest that. These are the instances I saw on a full release build on Linux: The ones in .cc files are likely to be dead code. I'll take a shot at removing some of it. ../../base/trace_event/trace_event.h:1011:13: warning: unused function 'AddMetadataEvent' [-Wunused-function] ../../cc/base/contiguous_container_unittest.cc:166:6: warning: unused function 'EqualPointers' [-Wunused-function] ../../cc/trees/layer_tree_impl.cc:1797:20: warning: unused function 'LayerClipsSubtree' [-Wunused-function] ../../chrome/browser/browsing_data/browsing_data_remover_impl.cc:52:6: warning: unused function 'IgnoreArgumentHelper' [-Wunused-function] ../../chrome/browser/browsing_data/browsing_data_remover_impl.cc:59:25: warning: unused function 'IgnoreArgument' [-Wunused-function] ../../chrome/browser/download/chrome_download_manager_delegate_unittest.cc:75:10: warning: unused function 'ScheduleCallback' [-Wunused-function] ../../chrome/browser/download/chrome_download_manager_delegate_unittest.cc:81:11: warning: unused function 'ScheduleCallback2' [-Wunused-function] ../../chrome/browser/extensions/api/context_menus/context_menus_api_helpers.h:22:43: warning: unused function 'GetParentId' [-Wunused-function] ../../chrome/browser/site_details_browsertest.cc:159:6: warning: unused function 'PrintTo' [-Wunused-function] ../../chrome/browser/sync_file_system/drive_backend/metadata_database_unittest.cc:139:6: warning: unused function 'ExpectEquivalent' [-Wunused-function] ../../chrome/browser/sync_file_system/drive_backend/sync_task_manager_unittest.cc:51:6: warning: unused function 'IncrementAndAssignWithOwnedPointer' [-Wunused-function] ../../components/leveldb_proto/proto_database_impl.h:106:6: warning: unused function 'RunLoadKeysCallback' [-Wunused-function] ../../components/leveldb_proto/proto_database_impl.h:114:6: warning: unused function 'RunGetCallback' [-Wunused-function] ../../components/leveldb_proto/proto_database_impl.h:122:6: warning: unused function 'RunDestroyCallback' [-Wunused-function] ../../components/leveldb_proto/proto_database_impl.h:145:6: warning: unused function 'UpdateEntriesFromTaskRunner' [-Wunused-function] ../../components/leveldb_proto/proto_database_impl.h:163:6: warning: unused function 'LoadEntriesFromTaskRunner' [-Wunused-function] ../../components/leveldb_proto/proto_database_impl.h:195:6: warning: unused function 'GetEntryFromTaskRunner' [-Wunused-function] ../../components/leveldb_proto/proto_database_impl.h:86:6: warning: unused function 'RunInitCallback' [-Wunused-function] ../../components/leveldb_proto/proto_database_impl.h:92:6: warning: unused function 'RunUpdateCallback' [-Wunused-function] ../../components/leveldb_proto/proto_database_impl.h:99:6: warning: unused function 'RunLoadCallback' [-Wunused-function] ../../components/ntp_snippets/remote/remote_suggestions_provider_impl_unittest.cc:92:11: warning: unused function 'IsCategory' [-Wunused-function] ../../components/password_manager/core/browser/password_form_manager_unittest.cc:109:11: warning: unused function 'CheckUsername' [-Wunused-function] ../../components/sync/driver/async_directory_type_controller_unittest.cc:59:10: warning: unused function 'SaveChangeProcessor' [-Wunused-function] ../../components/sync/driver/glue/sync_backend_host_impl_unittest.cc:62:10: warning: unused function 'Signal' [-Wunused-function] ../../content/browser/download/download_manager_impl_unittest.cc:75:12: warning: unused function 'DownloadCreateInfoWithDefaultPath' [-Wunused-function] ../../content/browser/media/capture/desktop_capture_device_unittest.cc:39:12: warning: unused function 'EqualsCaptureCapability' [-Wunused-function] ../../content/utility/utility_thread_impl.cc:35:6: warning: unused function 'ConvertVector' [-Wunused-function] ../../dbus/values_util.cc:21:6: warning: unused function 'IsExactlyRepresentableByDouble' [-Wunused-function] ../../media/filters/decrypting_audio_decoder_unittest.cc:59:10: warning: unused function 'ReturnBuffer' [-Wunused-function] ../../media/filters/decrypting_video_decoder_unittest.cc:52:11: warning: unused function 'ResetAndRunCallback' [-Wunused-function] ../../mojo/edk/system/node_channel.cc:27:3: warning: unused function 'Align' [-Wunused-function] ../../ppapi/cpp/module_impl.h:20:35: warning: unused function 'interface_name' [-Wunused-function] ../../ppapi/proxy/nacl_message_scanner.cc:167:6: warning: unused function 'ScanTuple' [-Wunused-function] ../../remoting/protocol/ice_transport_unittest.cc:43:10: warning: unused function 'QuitRunLoop' [-Wunused-function] ../../testing/gtest/src/gtest-internal-inl.h:340:13: warning: unused function 'Delete' [-Wunused-function] ../../third_party/angle/src/image_util/generatemip.inl:122:13: warning: unused function 'GenerateMip_YZ' [-Wunused-function] ../../third_party/angle/src/image_util/generatemip.inl:151:13: warning: unused function 'GenerateMip_XZ' [-Wunused-function] ../../third_party/angle/src/image_util/generatemip.inl:180:13: warning: unused function 'GenerateMip_XYZ' [-Wunused-function] ../../third_party/angle/src/image_util/generatemip.inl:228:30: warning: unused function 'GetMipGenerationFunction' [-Wunused-function] ../../third_party/angle/src/image_util/generatemip.inl:33:13: warning: unused function 'GenerateMip_Y' [-Wunused-function] ../../third_party/angle/src/image_util/generatemip.inl:53:13: warning: unused function 'GenerateMip_X' [-Wunused-function] ../../third_party/angle/src/image_util/generatemip.inl:73:13: warning: unused function 'GenerateMip_Z' [-Wunused-function] ../../third_party/angle/src/image_util/generatemip.inl:93:13: warning: unused function 'GenerateMip_XY' [-Wunused-function] ../../third_party/angle/src/libANGLE/formatutils.cpp:114:13: warning: unused function 'RequireESOrExtAndExt' [-Wunused-function] ../../third_party/skia/include/core/../private/../private/SkTemplates.h:36:45: warning: unused function 'SkTAfter' [-Wunused-function] ../../third_party/skia/include/core/../private/../private/SkTemplates.h:43:45: warning: unused function 'SkTAddOffset' [-Wunused-function] ../../third_party/skia/include/core/../private/SkTemplates.h:36:45: warning: unused function 'SkTAfter' [-Wunused-function] ../../third_party/skia/include/core/../private/SkTemplates.h:43:45: warning: unused function 'SkTAddOffset' [-Wunused-function] ../../third_party/skia/include/gpu/../private/SkTemplates.h:36:45: warning: unused function 'SkTAfter' [-Wunused-function] ../../third_party/skia/include/gpu/../private/SkTemplates.h:43:45: warning: unused function 'SkTAddOffset' [-Wunused-function] ../../third_party/skia/include/ports/../private/SkTemplates.h:36:45: warning: unused function 'SkTAfter' [-Wunused-function] ../../third_party/skia/include/ports/../private/SkTemplates.h:43:45: warning: unused function 'SkTAddOffset' [-Wunused-function] ../../third_party/skia/include/private/../private/SkTemplates.h:36:45: warning: unused function 'SkTAfter' [-Wunused-function] ../../third_party/skia/include/private/../private/SkTemplates.h:43:45: warning: unused function 'SkTAddOffset' [-Wunused-function] ../../third_party/skia/include/private/SkTemplates.h:36:45: warning: unused function 'SkTAfter' [-Wunused-function] ../../third_party/skia/include/private/SkTemplates.h:43:45: warning: unused function 'SkTAddOffset' [-Wunused-function] ../../third_party/skia/include/utils/../private/../private/SkTemplates.h:36:45: warning: unused function 'SkTAfter' [-Wunused-function] ../../third_party/skia/include/utils/../private/../private/SkTemplates.h:43:45: warning: unused function 'SkTAddOffset' [-Wunused-function] ../../third_party/skia/src/core/SkScanPriv.h:56:13: warning: unused function 'backward_insert_edge_based_on_x' [-Wunused-function] ../../third_party/skia/src/core/SkScanPriv.h:73:18: warning: unused function 'backward_insert_start' [-Wunused-function] ../../third_party/skia/src/core/SkTSort.h:120:47: warning: unused function 'SkTInsertionSort' [-Wunused-function] ../../third_party/skia/src/core/SkTSort.h:138:11: warning: unused function 'SkTQSort_Partition' [-Wunused-function] ../../third_party/skia/src/pathops/SkPathOpsTSect.h:1388:13: warning: unused function 'is_parallel' [-Wunused-function] ../../third_party/skia/src/ports/SkFontMgr_android_parser.h:123:35: warning: unused function 'parse_non_negative_integer' [-Wunused-function] ../../third_party/skia/src/ports/SkFontMgr_android_parser.h:160:42: warning: unused function 'parse_fixed' [-Wunused-function] ../../third_party/swiftshader/third_party/llvm-subzero/include/llvm/ADT/PointerUnion.h:193:13: warning: unused function 'operator==' [-Wunused-function] ../../third_party/swiftshader/third_party/llvm-subzero/include/llvm/ADT/PointerUnion.h:198:13: warning: unused function 'operator!=' [-Wunused-function] ../../third_party/swiftshader/third_party/llvm-subzero/include/llvm/ADT/PointerUnion.h:203:13: warning: unused function 'operator<' [-Wunused-function] ../../third_party/swiftshader/third_party/pnacl-subzero/src/IceDefs.h:120:27: warning: unused function 'makeUnique' [-Wunused-function] ../../third_party/WebKit/Source/bindings/core/v8/V8Binding.h:1111:13: warning: unused function 'IndexedPropertyEnumerator' [-Wunused-function] ../../third_party/WebKit/Source/core/frame/csp/CSPDirectiveList.cpp:44:13: warning: unused function 'IsASCIIAlphanumericOrHyphen' [-Wunused-function] ../../third_party/WebKit/Source/core/layout/ListMarkerText.cpp:122:15: warning: unused function 'ToSymbolic' [-Wunused-function] ../../third_party/WebKit/Source/core/layout/ListMarkerText.cpp:169:22: warning: unused function 'ToSymbolic' [-Wunused-function]
,
Apr 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f6e00db21abb2680b4bb504e8d9345946ab7479e commit f6e00db21abb2680b4bb504e8d9345946ab7479e Author: hans <hans@chromium.org> Date: Tue Apr 11 17:49:48 2017 contiguous_container_unittest.cc: Remove dead code. Found by a Clang warning. BUG= 710456 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2815713002 Cr-Commit-Position: refs/heads/master@{#463679} [modify] https://crrev.com/f6e00db21abb2680b4bb504e8d9345946ab7479e/cc/base/contiguous_container_unittest.cc
,
Apr 11 2017
Is this still an issue? Re #1: I think it's fine to replace static inline functions with inline. Also, it'd think we can remove functions/macros if they are really unused. The error message is on AddMetadataEvent, which is not inline. I don't think we should make that inline, increasing code size (issue 702718).
,
Apr 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c69f6dd1905bf9e23d902634240c88f7d5e513c8 commit c69f6dd1905bf9e23d902634240c88f7d5e513c8 Author: hans <hans@chromium.org> Date: Tue Apr 11 18:23:46 2017 browsing_data_remover_impl: Remove dead code. Found by a Clang warning. BUG= 710456 Review-Url: https://codereview.chromium.org/2817433002 Cr-Commit-Position: refs/heads/master@{#463690} [modify] https://crrev.com/c69f6dd1905bf9e23d902634240c88f7d5e513c8/chrome/browser/browsing_data/browsing_data_remover_impl.cc
,
Apr 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e02f869d678d735f93dfbcc60152c69305c33e5e commit e02f869d678d735f93dfbcc60152c69305c33e5e Author: hans <hans@chromium.org> Date: Tue Apr 11 18:30:27 2017 async_directory_type_controller_unittest.cc: Remove dead code. Found by a Clang warning. BUG= 710456 Review-Url: https://codereview.chromium.org/2815643003 Cr-Commit-Position: refs/heads/master@{#463694} [modify] https://crrev.com/e02f869d678d735f93dfbcc60152c69305c33e5e/components/sync/driver/async_directory_type_controller_unittest.cc
,
Apr 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b490c2b2f874b49181c9e021909f4a70caeff951 commit b490c2b2f874b49181c9e021909f4a70caeff951 Author: hans <hans@chromium.org> Date: Tue Apr 11 18:42:57 2017 chrome_download_manager_delegate_unittest.cc: Remove dead code. Found by a Clang warning. BUG= 710456 Review-Url: https://codereview.chromium.org/2810943003 Cr-Commit-Position: refs/heads/master@{#463700} [modify] https://crrev.com/b490c2b2f874b49181c9e021909f4a70caeff951/chrome/browser/download/chrome_download_manager_delegate_unittest.cc
,
Apr 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1387f5e7201a59a0db16a8b03f56bbf5479e8b93 commit 1387f5e7201a59a0db16a8b03f56bbf5479e8b93 Author: hans <hans@chromium.org> Date: Tue Apr 11 18:59:23 2017 desktop_capture_device_unittest.cc: Remove dead code. Found by a Clang warning. BUG= 710456 Review-Url: https://codereview.chromium.org/2812973002 Cr-Commit-Position: refs/heads/master@{#463707} [modify] https://crrev.com/1387f5e7201a59a0db16a8b03f56bbf5479e8b93/content/browser/media/capture/desktop_capture_device_unittest.cc
,
Apr 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b0042a678670b01517c238dc0091065715bef5ab commit b0042a678670b01517c238dc0091065715bef5ab Author: hans <hans@chromium.org> Date: Tue Apr 11 19:02:42 2017 sync_backend_host_impl_unittest.cc: Remove dead code. Found by a Clang warning. BUG= 710456 Review-Url: https://codereview.chromium.org/2810023002 Cr-Commit-Position: refs/heads/master@{#463709} [modify] https://crrev.com/b0042a678670b01517c238dc0091065715bef5ab/components/sync/driver/glue/sync_backend_host_impl_unittest.cc
,
Apr 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ef3b58845bda96bfd62a771dc53c8b17d508db19 commit ef3b58845bda96bfd62a771dc53c8b17d508db19 Author: hans <hans@chromium.org> Date: Tue Apr 11 19:20:21 2017 ice_transport_unittest.cc: Remove dead code. Found by a Clang warning. BUG= 710456 Review-Url: https://codereview.chromium.org/2812053002 Cr-Commit-Position: refs/heads/master@{#463718} [modify] https://crrev.com/ef3b58845bda96bfd62a771dc53c8b17d508db19/remoting/protocol/ice_transport_unittest.cc
,
Apr 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b0f7a5bde66c81d833a60bdc636eb61a0b2296da commit b0f7a5bde66c81d833a60bdc636eb61a0b2296da Author: hans <hans@chromium.org> Date: Tue Apr 11 19:30:10 2017 download_manager_impl_unittest.cc: Remove dead code. Found by a Clang warning. BUG= 710456 Review-Url: https://codereview.chromium.org/2809793003 Cr-Commit-Position: refs/heads/master@{#463724} [modify] https://crrev.com/b0f7a5bde66c81d833a60bdc636eb61a0b2296da/content/browser/download/download_manager_impl_unittest.cc
,
Apr 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/52e41a9f1668cd5cb986b6b25b30d0c2630b1b6a commit 52e41a9f1668cd5cb986b6b25b30d0c2630b1b6a Author: hans <hans@chromium.org> Date: Tue Apr 11 20:08:02 2017 CSPDirectiveList.cpp: Remove dead code. Found by a Clang warning. BUG= 710456 Review-Url: https://codereview.chromium.org/2808263003 Cr-Commit-Position: refs/heads/master@{#463742} [modify] https://crrev.com/52e41a9f1668cd5cb986b6b25b30d0c2630b1b6a/third_party/WebKit/Source/core/frame/csp/CSPDirectiveList.cpp
,
Apr 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/022037f0d183a9d602f7f42accfd4ebf6af80e23 commit 022037f0d183a9d602f7f42accfd4ebf6af80e23 Author: hans <hans@chromium.org> Date: Tue Apr 11 20:34:29 2017 node_channel.cc: Remove dead code. Found by a Clang warning. BUG= 710456 Review-Url: https://codereview.chromium.org/2811133002 Cr-Commit-Position: refs/heads/master@{#463752} [modify] https://crrev.com/022037f0d183a9d602f7f42accfd4ebf6af80e23/mojo/edk/system/node_channel.cc
,
Apr 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/477c1b8082ff61d2e53d9b4b4e60d14467f4fbbb commit 477c1b8082ff61d2e53d9b4b4e60d14467f4fbbb Author: hans <hans@chromium.org> Date: Tue Apr 11 20:50:27 2017 remote_suggestions_provider_impl_unittest.cc: Remove unused code Found by a Clang warning. BUG= 710456 Review-Url: https://codereview.chromium.org/2809963003 Cr-Commit-Position: refs/heads/master@{#463760} [modify] https://crrev.com/477c1b8082ff61d2e53d9b4b4e60d14467f4fbbb/components/ntp_snippets/remote/remote_suggestions_provider_impl_unittest.cc
,
Apr 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7a67eff3570e6f3535486e0806651971832d2f56 commit 7a67eff3570e6f3535486e0806651971832d2f56 Author: hans <hans@chromium.org> Date: Tue Apr 11 20:51:56 2017 layer_tree_impl.cc: Remove dead code. Found by a Clang warning. BUG= 710456 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2811103003 Cr-Commit-Position: refs/heads/master@{#463761} [modify] https://crrev.com/7a67eff3570e6f3535486e0806651971832d2f56/cc/trees/layer_tree_impl.cc
,
Apr 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b8c1687658d2d39fac8355f7c2e65ebf928a4ab0 commit b8c1687658d2d39fac8355f7c2e65ebf928a4ab0 Author: hans <hans@chromium.org> Date: Tue Apr 11 22:39:07 2017 decrypting_{audio,video}_decoder_unittest.cc: Remove dead code. Found by a Clang warning. BUG= 710456 Review-Url: https://codereview.chromium.org/2812043002 Cr-Commit-Position: refs/heads/master@{#463809} [modify] https://crrev.com/b8c1687658d2d39fac8355f7c2e65ebf928a4ab0/media/filters/decrypting_audio_decoder_unittest.cc [modify] https://crrev.com/b8c1687658d2d39fac8355f7c2e65ebf928a4ab0/media/filters/decrypting_video_decoder_unittest.cc
,
Apr 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/88b13e159698184c646a6b522a5313100bfcdf1b commit 88b13e159698184c646a6b522a5313100bfcdf1b Author: hans <hans@chromium.org> Date: Tue Apr 11 22:52:15 2017 utility_thread_impl.cc: Remove dead code. Found by a Clang warning. BUG= 710456 Review-Url: https://codereview.chromium.org/2816593002 Cr-Commit-Position: refs/heads/master@{#463817} [modify] https://crrev.com/88b13e159698184c646a6b522a5313100bfcdf1b/content/utility/utility_thread_impl.cc
,
Apr 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eb3eb6c7fc2ef28b4fbf1633b32afea7f2be27e2 commit eb3eb6c7fc2ef28b4fbf1633b32afea7f2be27e2 Author: hans <hans@chromium.org> Date: Wed Apr 12 00:53:49 2017 ListMarkerText.cpp: Delete dead code. Found by a Clang warning. BUG= 710456 Review-Url: https://codereview.chromium.org/2807213005 Cr-Commit-Position: refs/heads/master@{#463862} [modify] https://crrev.com/eb3eb6c7fc2ef28b4fbf1633b32afea7f2be27e2/third_party/WebKit/Source/core/layout/ListMarkerText.cpp
,
Apr 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7c5c7ff58a42a63cf45a647239a951dafffd91ae commit 7c5c7ff58a42a63cf45a647239a951dafffd91ae Author: hans <hans@chromium.org> Date: Wed Apr 12 01:48:28 2017 sync_task_manager_unittest.cc: Remove dead code. Found by a Clang warning. BUG= 710456 Review-Url: https://codereview.chromium.org/2814803002 Cr-Commit-Position: refs/heads/master@{#463889} [modify] https://crrev.com/7c5c7ff58a42a63cf45a647239a951dafffd91ae/chrome/browser/sync_file_system/drive_backend/sync_task_manager_unittest.cc |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by thakis@chromium.org
, Apr 11 2017Status: Untriaged (was: Unconfirmed)