New issue
Advanced search Search tips

Issue 710452 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

authpolicy: Add a D-Bus method to report account info

Project Member Reported by ljusten@chromium.org, Apr 11 2017

Issue description

Also add TGT validity lifetime (UTC time) and SAM account name to the info blob.

WHEN CHROME SIDE IS DONE, REMOVE active_directory_account_data.proto IN system_api!
 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/system_api/+/00c3a429ab633a8d623c1c15746876b356d91ac6

commit 00c3a429ab633a8d623c1c15746876b356d91ac6
Author: Lutz Justen <ljusten@chromium.org>
Date: Mon Apr 17 21:06:20 2017

authpolicy: Add SAM account name to account info protobuf

The SAM account name is reported back to Chrome, where it is going to
be used to update the user's logon name displayed in Chrome (part
before @). Note that the user's logon name might change in Active
Directory.

CQ-DEPEND=CL:474032

BUG= chromium:710452 
TEST=Compiled, ran tests.

Change-Id: I74a42b5c2f5631e282533f29a4a6402e9f6b9978
Reviewed-on: https://chromium-review.googlesource.com/474866
Commit-Ready: Lutz Justen <ljusten@chromium.org>
Tested-by: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Roman Sorokin <rsorokin@chromium.org>

[modify] https://crrev.com/00c3a429ab633a8d623c1c15746876b356d91ac6/dbus/authpolicy/active_directory_account_data.proto

Project Member

Comment 3 by bugdroid1@chromium.org, Apr 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/ef083f7e6e8d5ea5d5ea0282d00c5362ac2e1dfb

commit ef083f7e6e8d5ea5d5ea0282d00c5362ac2e1dfb
Author: Lutz Justen <ljusten@chromium.org>
Date: Mon Apr 17 21:06:19 2017

authpolicy: Add SAM account name to account info

The SAM account name is reported back to Chrome, where it is going to
be used to update the user's logon name displayed in Chrome (part
before @). Note that the user's logon name might change in Active
Directory.

CQ-DEPEND=CL:474866

BUG= chromium:710452 
TEST=Compiled, ran tests.

Change-Id: I24590617d0fab989b0f3e69b78cf182641df6da9
Reviewed-on: https://chromium-review.googlesource.com/474032
Commit-Ready: Lutz Justen <ljusten@chromium.org>
Tested-by: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Roman Sorokin <rsorokin@chromium.org>

[modify] https://crrev.com/ef083f7e6e8d5ea5d5ea0282d00c5362ac2e1dfb/authpolicy/authpolicy.cc
[modify] https://crrev.com/ef083f7e6e8d5ea5d5ea0282d00c5362ac2e1dfb/authpolicy/stub_common.cc
[modify] https://crrev.com/ef083f7e6e8d5ea5d5ea0282d00c5362ac2e1dfb/authpolicy/stub_common.h
[modify] https://crrev.com/ef083f7e6e8d5ea5d5ea0282d00c5362ac2e1dfb/authpolicy/stub_net_main.cc
[modify] https://crrev.com/ef083f7e6e8d5ea5d5ea0282d00c5362ac2e1dfb/authpolicy/authpolicy_unittest.cc

Description: Show this description
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/system_api/+/fd7d48e736a6e28b3e72ebeaa02353b56a9e9be0

commit fd7d48e736a6e28b3e72ebeaa02353b56a9e9be0
Author: Lutz Justen <ljusten@chromium.org>
Date: Tue Apr 25 21:03:56 2017

authpolicy: Add ActiveDirectoryUserStatus protobuf

Required for new GetUserStatus D-Bus call from Chrome to authpolicy
(see CL:481319).

BUG= chromium:710452 
TEST=Emerges and works with dependent CL.

Change-Id: Ia6374a0ff2f9cd637447dd2b1b7ed007e297451d
Reviewed-on: https://chromium-review.googlesource.com/481299
Commit-Ready: Lutz Justen <ljusten@chromium.org>
Tested-by: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Roman Sorokin <rsorokin@chromium.org>

[modify] https://crrev.com/fd7d48e736a6e28b3e72ebeaa02353b56a9e9be0/dbus/authpolicy/dbus-constants.h
[add] https://crrev.com/fd7d48e736a6e28b3e72ebeaa02353b56a9e9be0/dbus/authpolicy/active_directory_info.proto
[modify] https://crrev.com/fd7d48e736a6e28b3e72ebeaa02353b56a9e9be0/system_api.gyp
[modify] https://crrev.com/fd7d48e736a6e28b3e72ebeaa02353b56a9e9be0/dbus/authpolicy/active_directory_account_data.proto

Project Member

Comment 6 by bugdroid1@chromium.org, Apr 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/90ffc743bfde68b21cba4b981c01f1f1d094ccb4

commit 90ffc743bfde68b21cba4b981c01f1f1d094ccb4
Author: Lutz Justen <ljusten@chromium.org>
Date: Thu Apr 27 18:15:45 2017

authpolicy: Add GetUserStatus D-Bus call

Adds a GetUserStatus D-Bus call to be called from Chrome in order to
get the status of a given user account. The status contains account
information, in particular display names, which might change on the
server, as well as the status of the user's Kerberos ticket-granting-
ticket (TGT). Chrome can use this data to prompt the user to relog,
so that a fresh TGT can be acquired (requires password).

CQ-DEPEND=CL:481299

BUG= chromium:710452 
TEST=Compiled, ran tests.

Change-Id: I8759ff15dc6aceb57cd3d50953345cb65da4ef25
Reviewed-on: https://chromium-review.googlesource.com/481319
Commit-Ready: Lutz Justen <ljusten@chromium.org>
Tested-by: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Roman Sorokin <rsorokin@chromium.org>

[modify] https://crrev.com/90ffc743bfde68b21cba4b981c01f1f1d094ccb4/authpolicy/stub_klist_main.cc
[modify] https://crrev.com/90ffc743bfde68b21cba4b981c01f1f1d094ccb4/authpolicy/authpolicy_metrics.h
[modify] https://crrev.com/90ffc743bfde68b21cba4b981c01f1f1d094ccb4/authpolicy/authpolicy_unittest.cc
[modify] https://crrev.com/90ffc743bfde68b21cba4b981c01f1f1d094ccb4/authpolicy/authpolicy.h
[modify] https://crrev.com/90ffc743bfde68b21cba4b981c01f1f1d094ccb4/authpolicy/stub_common.h
[modify] https://crrev.com/90ffc743bfde68b21cba4b981c01f1f1d094ccb4/authpolicy/dbus_bindings/org.chromium.AuthPolicy.xml
[modify] https://crrev.com/90ffc743bfde68b21cba4b981c01f1f1d094ccb4/authpolicy/stub_kinit_main.cc
[modify] https://crrev.com/90ffc743bfde68b21cba4b981c01f1f1d094ccb4/authpolicy/proto/authpolicy_containers.proto
[modify] https://crrev.com/90ffc743bfde68b21cba4b981c01f1f1d094ccb4/authpolicy/authpolicy_parser_main.cc
[modify] https://crrev.com/90ffc743bfde68b21cba4b981c01f1f1d094ccb4/authpolicy/samba_interface.cc
[modify] https://crrev.com/90ffc743bfde68b21cba4b981c01f1f1d094ccb4/authpolicy/samba_interface.h
[modify] https://crrev.com/90ffc743bfde68b21cba4b981c01f1f1d094ccb4/authpolicy/stub_common.cc
[modify] https://crrev.com/90ffc743bfde68b21cba4b981c01f1f1d094ccb4/authpolicy/authpolicy_metrics.cc
[modify] https://crrev.com/90ffc743bfde68b21cba4b981c01f1f1d094ccb4/authpolicy/authpolicy.gyp
[modify] https://crrev.com/90ffc743bfde68b21cba4b981c01f1f1d094ccb4/authpolicy/authpolicy.cc
[modify] https://crrev.com/90ffc743bfde68b21cba4b981c01f1f1d094ccb4/authpolicy/stub_net_main.cc
[modify] https://crrev.com/90ffc743bfde68b21cba4b981c01f1f1d094ccb4/authpolicy/etc/dbus-1/org.chromium.AuthPolicy.conf

Description: Show this description
Status: Fixed (was: Started)
Project Member

Comment 9 by bugdroid1@chromium.org, Jun 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/system_api/+/638d4895cdde26daa446099844d0a1cef6d1397d

commit 638d4895cdde26daa446099844d0a1cef6d1397d
Author: Lutz Justen <ljusten@chromium.org>
Date: Tue Jun 06 10:14:33 2017

Remove authpolicy/active_directory_account_data.proto

It was replaced by active_directory_info.proto a while ago. The
Chrome side already uses the new file, so this CL is safe to be
pushed to Chrome.

BUG= chromium:710452 
TEST=build_packages for chell

Change-Id: Ie655a82985ee567994479c4ba31f6cdaba6cf3fa
Reviewed-on: https://chromium-review.googlesource.com/521042
Commit-Ready: Lutz Justen <ljusten@chromium.org>
Tested-by: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Roman Sorokin <rsorokin@chromium.org>

[modify] https://crrev.com/638d4895cdde26daa446099844d0a1cef6d1397d/system_api.gyp
[delete] https://crrev.com/0fed00b89ef09f5cafa1d4ed1f6c816b9710053e/dbus/authpolicy/active_directory_account_data.proto

Status: Verified (was: Fixed)
bulk Verify of older or not-user-facing Chromad bugs

Sign in to add a comment