New issue
Advanced search Search tips

Issue 710449 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 625701



Sign in to add a comment

Record Sliding Window Expected Queueing Time Metric in UMA

Project Member Reported by tdres...@chromium.org, Apr 11 2017

Issue description

We currently record the expected queueing time once per 1 second window (RendererScheduler.ExpectedTaskQueueingDuration).

We want to record the maximum EQT in an N ms sliding window between TTI and when the user navigates away.
 
Ulan, did we ever settle on the size of the sliding window?
Project Member

Comment 2 by bugdroid1@chromium.org, May 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7a8f8e51e1e0d43cb0a24a629d508bc473864a28

commit 7a8f8e51e1e0d43cb0a24a629d508bc473864a28
Author: maxlg <maxlg@chromium.org>
Date: Mon May 15 16:53:13 2017

EQT: Change Expected Queuing Time from per-second to sliding window

In order to record Sliding Window Expected Queuing Time(EQT) Metric in UMA, we
need to extend the current EQT from the per-second approach to a sliding window
approach. The change makes the original per-second use case a special case of
the sliding window use cases.

BUG= 710449 

Review-Url: https://codereview.chromium.org/2866613002
Cr-Commit-Position: refs/heads/master@{#471803}

[modify] https://crrev.com/7a8f8e51e1e0d43cb0a24a629d508bc473864a28/third_party/WebKit/Source/platform/scheduler/base/queueing_time_estimator.cc
[modify] https://crrev.com/7a8f8e51e1e0d43cb0a24a629d508bc473864a28/third_party/WebKit/Source/platform/scheduler/base/queueing_time_estimator.h
[modify] https://crrev.com/7a8f8e51e1e0d43cb0a24a629d508bc473864a28/third_party/WebKit/Source/platform/scheduler/base/queueing_time_estimator_unittest.cc
[modify] https://crrev.com/7a8f8e51e1e0d43cb0a24a629d508bc473864a28/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc
[modify] https://crrev.com/7a8f8e51e1e0d43cb0a24a629d508bc473864a28/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.h
[modify] https://crrev.com/7a8f8e51e1e0d43cb0a24a629d508bc473864a28/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl_unittest.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/206f88a3c6df64c70511446235ed6ff72a94ce9e

commit 206f88a3c6df64c70511446235ed6ff72a94ce9e
Author: maxlg <maxlg@chromium.org>
Date: Tue Jun 06 15:14:09 2017

EQT: Record the max queueing time from navigation start to navigation away

We want to record the maximum EQT in an N ms sliding window between TTI and when
the user navigates away, yet TTI is not landed yet, so this CL will
measure the max EQT from navigation start to navigation away as a first step.

BUG= 710449 

Review-Url: https://codereview.chromium.org/2890173002
Cr-Commit-Position: refs/heads/master@{#477289}

[modify] https://crrev.com/206f88a3c6df64c70511446235ed6ff72a94ce9e/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/206f88a3c6df64c70511446235ed6ff72a94ce9e/third_party/WebKit/Source/platform/scheduler/renderer/DEPS
[modify] https://crrev.com/206f88a3c6df64c70511446235ed6ff72a94ce9e/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc
[modify] https://crrev.com/206f88a3c6df64c70511446235ed6ff72a94ce9e/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.h
[modify] https://crrev.com/206f88a3c6df64c70511446235ed6ff72a94ce9e/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl_unittest.cc
[modify] https://crrev.com/206f88a3c6df64c70511446235ed6ff72a94ce9e/third_party/WebKit/Source/platform/scheduler/test/fake_renderer_scheduler.cc
[modify] https://crrev.com/206f88a3c6df64c70511446235ed6ff72a94ce9e/third_party/WebKit/public/platform/scheduler/renderer/renderer_scheduler.h
[modify] https://crrev.com/206f88a3c6df64c70511446235ed6ff72a94ce9e/third_party/WebKit/public/platform/scheduler/test/fake_renderer_scheduler.h
[modify] https://crrev.com/206f88a3c6df64c70511446235ed6ff72a94ce9e/third_party/WebKit/public/platform/scheduler/test/mock_renderer_scheduler.h
[modify] https://crrev.com/206f88a3c6df64c70511446235ed6ff72a94ce9e/tools/metrics/histograms/histograms.xml

Comment 5 by dproy@chromium.org, Mar 16 2018

Labels: -progressivewebmetrics

Sign in to add a comment