New issue
Advanced search Search tips

Issue 710438 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

Saved password in chrome are not auto filled on login page of https://www.iblogmarket.com

Project Member Reported by madhusudhan@chromium.org, Apr 11 2017

Issue description

App Version: 57.0.2987.137
iOS Version: 10.2.1, 10.3
Device: iPad, iPhone

Steps to Reproduce:
1. Launch chrome.
2. Navigate to “https://www.iblogmarket.com/” and navigate to sign-up page
3. Enter the email address and password and tap on login
4. Tap on save button displayed on the save password info bar
5. Log out of the webpage  and navigate back to sign-in/login page.

Observed results:
Username & password is not auto filled in login page

Expected results:
Saved password should be  autofilled on the sign-in page

Number of times you were able to reproduce: 5/5
Bug reproducible after clean install: Yes
Bug reproducible after clearing cache and cookies: Yes
Bug reproducible on Chrome Mobile on Android: No
Bug reproducible on Safari/Firefox: Firefox: NA Safari: No
Bug reproducible on current stable build (App Version, iOS Version): Yes
Bug reproducible on the current beta channel build (App Version, iOS Version): Yes
 
Labels: found-in-M57

Comment 2 by vabr@chromium.org, Apr 13 2017

Labels: Hotlist-Polish
Cc: vabr@chromium.org melandory@chromium.org
Status: Available (was: Untriaged)

Comment 4 by vabr@chromium.org, Apr 14 2017

Cc: -melandory@chromium.org -vabr@chromium.org
Labels: Hotlist-WorksOnDesktop
This is working on desktop and hence likely to be fixed once we start sharing desktop heuristics with iOS code.

Comment 5 by vabr@chromium.org, Apr 24 2017

This is broken on iPad as well. Both on iPhone and iPad (Chrome 58) I can see the keyboard accessory offering the saved account, but tapping it does not fill anything (filling on load also does not work).
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cdd46b0be27f87114037e15970f97209fea79bca

commit cdd46b0be27f87114037e15970f97209fea79bca
Author: Vadym Doroshenko <dvadym@chromium.org>
Date: Wed Aug 02 18:05:54 2017

[Bling Password Manager] Unifying treating of password form action

Normalizing of password form action is done in 2 different cases with different code:
 1.On Load, in Obj-C code in password_controller.mm
 2.On fill in JS in password_controller.js

That's bad, as any duplicating code, because in some cases it generates different canonical actions (for example when the action is empty). This CL unifying canonical action calculation. As a model for canonical action calculation GetCanonicalActionForForm from Desktop/Android implementation is taken.

Bug:  710438 ,  708602 
Change-Id: I1ea879c60d01cf02bed6ea9715089221971ff4a0
Reviewed-on: https://chromium-review.googlesource.com/596031
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491434}
[modify] https://crrev.com/cdd46b0be27f87114037e15970f97209fea79bca/ios/chrome/browser/passwords/password_controller.mm
[modify] https://crrev.com/cdd46b0be27f87114037e15970f97209fea79bca/ios/chrome/browser/passwords/password_controller_js_unittest.mm
[modify] https://crrev.com/cdd46b0be27f87114037e15970f97209fea79bca/ios/chrome/browser/passwords/password_controller_unittest.mm
[modify] https://crrev.com/cdd46b0be27f87114037e15970f97209fea79bca/ios/chrome/browser/passwords/resources/password_controller.js

Owner: dvadym@chromium.org
Status: Fixed (was: Available)
Status: Verified (was: Fixed)
Saved Username and Password are auto-filled into Sign in form correctly.
Verified on M62.0.3079.0 canary
Device: iPhone7 plus, ipad Pro
iOS: 11.0 beta#5, iOS10.3.3

Sign in to add a comment