AutofillInteractiveIsolationTest.SimpleCrossSiteFill is flaky on windows. |
|||
Issue descriptioninteractive_ui_tests failing on chromium.win/Win7 Tests (dbg)(1) Builders failed on: - Win7 Tests (dbg)(1): https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29
,
Apr 11 2017
The test seems to time out. The first instance I saw was in https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/58983 (log attached).
,
Apr 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7e0b9a9cdf69d9175d41ad5338c185daf88660ae commit 7e0b9a9cdf69d9175d41ad5338c185daf88660ae Author: rouslan <rouslan@chromium.org> Date: Tue Apr 11 14:27:28 2017 Disable AutofillInteractiveIsolationTest.SimpleCrossSiteFill on Windows. TBR=vabr@chromium.org BUG= 710436 Review-Url: https://codereview.chromium.org/2810913004 Cr-Commit-Position: refs/heads/master@{#463619} [modify] https://crrev.com/7e0b9a9cdf69d9175d41ad5338c185daf88660ae/chrome/browser/autofill/autofill_interactive_uitest.cc
,
Oct 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/522146e8024f81aff5a7c076f5a819aec719ed99 commit 522146e8024f81aff5a7c076f5a819aec719ed99 Author: Greg Thompson <grt@chromium.org> Date: Thu Oct 05 00:02:06 2017 Deflake ui_controls::SendMouseMove on Windows. On Windows, SendMouseMove must transform a point in screen coordinates into the range (0..2^16-1) for consumption by SendInput. Windows then converts this back to screen coordinates. This change rounds up rather than down in the initial conversion so that Windows lands on the correct point when it seemly truncates. Previously, we'd see off-by-one errors from time to time. While this may seem insignificant at first blush, it's problematic when SendMouseMove is called to move the mouse to a point where it already resides. No events are generated by SendInput in this case, so the hook proc will never be called. This shouldn't be a problem since SendMouseMove detects this case and short-circuits the request. With the ob1, however, SendMouseMove thinks it needs to move the mouse by one point, yet the bad math results in a call to SendInput to move the mouse to its current position. This makes tests timeout and all of us sad. BUG= 390564 , 639940 , 710436 , 726659 , 728488 , 764415 R=mathp@chromium.org, sky@chromium.org Change-Id: I1daebe8281db0a799ef7266c3c1765de65580f03 Reviewed-on: https://chromium-review.googlesource.com/686898 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Mathieu Perreault <mathp@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#506574} [modify] https://crrev.com/522146e8024f81aff5a7c076f5a819aec719ed99/chrome/browser/autofill/autofill_interactive_uitest.cc [add] https://crrev.com/522146e8024f81aff5a7c076f5a819aec719ed99/chrome/browser/ui/send_mouse_move_uitest_win.cc [modify] https://crrev.com/522146e8024f81aff5a7c076f5a819aec719ed99/chrome/test/BUILD.gn [modify] https://crrev.com/522146e8024f81aff5a7c076f5a819aec719ed99/ui/base/test/ui_controls_internal_win.cc
,
Oct 6 2017
Looking at recent builds on https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29, grt@'s fix worked. Thanks, grt@! |
|||
►
Sign in to add a comment |
|||
Comment 1 by rouslan@chromium.org
, Apr 11 2017