New issue
Advanced search Search tips

Issue 710431 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , All , Chrome , Mac
Pri: 3
Type: Bug

Blocking:
issue 808410
issue 712010



Sign in to add a comment

Save password infobar is not displayed for “https://nimia.com/”

Project Member Reported by pmadalla@chromium.org, Apr 11 2017

Issue description

App Version: 57.0.2987.137 
iOS Version: 9.3.5,iOS 10
Device : iPad Air 2
URL : https://nimia.com/

Steps to reproduce:
1- Launch chrome.
2- Goto “https://nimia.com/”.
3- Tap on Login and sign in with valid credentials
(User name : ipuntoevo2 Pswd : 123456789321).
4- Tap on Sign in.

Observed results:
Save password infobar is not displayed.
 
Expected results:
Save password infobar should be displayed

Number of times you were able to reproduce: 5/5
Bug reproducible after clean install: Yes
Bug reproducible after clearing cache and cookies: Yes
Bug reproducible on Chrome Mobile on Android: No
Bug reproducible on Dolphin/Safari/Firefox: Safari : No
Bug reproducible on current stable build (App Version, iOS Version): Yes in M57
Bug reproducible on the current beta channel build (App Version, iOS Version): Yes

Link to Video :
https://drive.google.com/a/google.com/file/d/0B--UpU2GW2EpMmFyNnRxUkcwTmc/view?usp=sharing

 
Cc: linds...@chromium.org
Components: UI>Browser>Passwords
Labels: -UIBrowserPasswords
Status: Available (was: Untriaged)
Can you please add if the infobar is showing on desktop for the same site?
Savepassword infobar is shown once we logout from the site in desktop chrome.

Comment 3 by vabr@chromium.org, Apr 13 2017

Labels: Hotlist-Polish

Comment 4 by vabr@chromium.org, Apr 16 2017

Blocking: 712010
Labels: -Pri-2 OS-Android OS-Chrome OS-Linux OS-Mac OS-Windows OS-All Pri-3
Thanks for the report.

This is also observed on other platforms. Looking at chrome://password-manager-internals, Chrome fails to detect the submission.
A reason why the the infobar isn't triggered timely, is because PasswordManager::OnPasswordFormsRendered(...) or other reaction to the in-page navigation aren't triggered after form submission.

e.g.
1. Log in 
--> OnPasswordFormsRendered or other in-page navigations are not triggered - probably because a similar form (in terms of action, origin, etc.) is still present on the page.

2. Log out
--> OnPasswordFormsRendered is triggered and the saving prompt is shown.


Further details:
OnPasswordFormsRendered is not called as the PasswordAutofillAgent::DidFinishLoad() never calls SendPasswordForms(/*only_visible=*/true).
If only_visible is false, the OnPasswordFormsRendered event is never triggered.

This site loads quite slowly but the DidFinishLoad() event should be triggered at some point at least.
DidFinishLoad() will not be called for this page or other pages that sign in as "same document navigation".

When inspecting PasswordAutofillAgent::DidCommitProvisionalLoad(bool is_new_navigation, bool is_same_document_navigation), the parameter "is_same_document_navigation" is set to true which implies that DidFinishLoad() will never get called.
We need a different way to react to these kinds of navigations. Other events like DidStopLoading might be helpful.

Comment 8 by battre@chromium.org, Jan 30 2018

I could imagine that this gets fixed once https://chromium-review.googlesource.com/c/chromium/src/+/892882 lands. If you have credentials, feel free to stop by my computer to try it out.

Comment 9 by battre@chromium.org, Jan 30 2018

Cc: fhorschig@chromium.org
CC fhorschig for my last comment.
The credentials are (from comment #1):
 
Username: ipuntoevo2
Pwd: 123456789321
Owner: battre@chromium.org
Status: Assigned (was: Available)
I just tried it locally and your CL works perfectly  for nimia.com.
The bubble pops up immediately after the login.

(I assigned you this bug so nobody else starts it without consulting you first.) 
Confirmed. This works if we can land https://chromium-review.googlesource.com/c/chromium/src/+/892882
Project Member

Comment 13 by bugdroid1@chromium.org, Feb 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fadf05485d1a5703562fc7639f5b099875f7fe18

commit fadf05485d1a5703562fc7639f5b099875f7fe18
Author: Dominic Battre <battre@chromium.org>
Date: Fri Feb 02 13:15:47 2018

More robust capturing <form>s that are taken out of the DOM.

Chrome's password manager tries to capture events where <form> elements
are taken out of the DOM or made invisible. This is used to detect
form submissions. This trigger failed in the past if a parent element
for the form was removed from the DOM or made invisible (as opposed
to the form it self). This CL makes the trigger logic more robust.

Bug:  760579 ,  710431 
Change-Id: Idbc72d7ab57d9e6c61b0907ac5c9b3f96346d4a5
Reviewed-on: https://chromium-review.googlesource.com/892882
Commit-Queue: Dominic Battré <battre@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534037}
[modify] https://crrev.com/fadf05485d1a5703562fc7639f5b099875f7fe18/chrome/renderer/autofill/password_autofill_agent_browsertest.cc
[modify] https://crrev.com/fadf05485d1a5703562fc7639f5b099875f7fe18/third_party/WebKit/Source/core/exported/WebFormElementObserverImpl.cpp

Blocking: 808410
Labels: -OS-iOS
Status: Fixed (was: Assigned)
I have filed issue 808410 for iOS.
Project Member

Comment 16 by bugdroid1@chromium.org, Feb 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0fd617ef5b871cbaaa3c2197e43617c594aa273f

commit 0fd617ef5b871cbaaa3c2197e43617c594aa273f
Author: Adam Klein <adamk@chromium.org>
Date: Wed Feb 07 23:47:39 2018

Revert "More robust capturing <form>s that are taken out of the DOM."

This reverts commit fadf05485d1a5703562fc7639f5b099875f7fe18.

Reason for revert: Speculative revert due to Dev-blocking crash bug

See https://crbug.com/808911#c25 for more details.

Original change's description:
> More robust capturing <form>s that are taken out of the DOM.
> 
> Chrome's password manager tries to capture events where <form> elements
> are taken out of the DOM or made invisible. This is used to detect
> form submissions. This trigger failed in the past if a parent element
> for the form was removed from the DOM or made invisible (as opposed
> to the form it self). This CL makes the trigger logic more robust.
> 
> Bug:  760579 ,  710431 
> Change-Id: Idbc72d7ab57d9e6c61b0907ac5c9b3f96346d4a5
> Reviewed-on: https://chromium-review.googlesource.com/892882
> Commit-Queue: Dominic Battré <battre@chromium.org>
> Reviewed-by: Jochen Eisinger <jochen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#534037}

TBR=battre@chromium.org,ojan@chromium.org,jochen@chromium.org
Bug:  760579 ,  710431 , 808911

Change-Id: I22af4860f9944b2a80bc5aae19048109a66b84c3
Reviewed-on: https://chromium-review.googlesource.com/906845
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535192}
[modify] https://crrev.com/0fd617ef5b871cbaaa3c2197e43617c594aa273f/chrome/renderer/autofill/password_autofill_agent_browsertest.cc
[modify] https://crrev.com/0fd617ef5b871cbaaa3c2197e43617c594aa273f/third_party/WebKit/Source/core/exported/WebFormElementObserverImpl.cpp

Project Member

Comment 17 by bugdroid1@chromium.org, Feb 8 2018

Labels: merge-merged-3342
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/72dfba7281ad7706c8a1d72a61e376fa02579e66

commit 72dfba7281ad7706c8a1d72a61e376fa02579e66
Author: Adam Klein <adamk@chromium.org>
Date: Thu Feb 08 01:23:06 2018

Revert "More robust capturing <form>s that are taken out of the DOM."

This reverts commit fadf05485d1a5703562fc7639f5b099875f7fe18.

Reason for revert: Speculative revert due to Dev-blocking crash bug

See https://crbug.com/808911#c25 for more details.

Original change's description:
> More robust capturing <form>s that are taken out of the DOM.
> 
> Chrome's password manager tries to capture events where <form> elements
> are taken out of the DOM or made invisible. This is used to detect
> form submissions. This trigger failed in the past if a parent element
> for the form was removed from the DOM or made invisible (as opposed
> to the form it self). This CL makes the trigger logic more robust.
> 
> Bug:  760579 ,  710431 
> Change-Id: Idbc72d7ab57d9e6c61b0907ac5c9b3f96346d4a5
> Reviewed-on: https://chromium-review.googlesource.com/892882
> Commit-Queue: Dominic Battré <battre@chromium.org>
> Reviewed-by: Jochen Eisinger <jochen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#534037}

(cherry picked from commit 0fd617ef5b871cbaaa3c2197e43617c594aa273f)

Change-Id: Ie779c0bb36df4319a6220b6b10c02434ec26984c
Tbr: battre@chromium.org,ojan@chromium.org,jochen@chromium.org
Bug:  760579 ,  710431 , 808911
Reviewed-on: https://chromium-review.googlesource.com/907598
Reviewed-by: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/branch-heads/3342@{#5}
Cr-Branched-From: 7a08be580eb458170d11b34a8de66fe08db41bc5-refs/heads/master@{#534887}
[modify] https://crrev.com/72dfba7281ad7706c8a1d72a61e376fa02579e66/chrome/renderer/autofill/password_autofill_agent_browsertest.cc
[modify] https://crrev.com/72dfba7281ad7706c8a1d72a61e376fa02579e66/third_party/WebKit/Source/core/exported/WebFormElementObserverImpl.cpp

Project Member

Comment 18 by bugdroid1@chromium.org, Feb 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fd8c26e0c11b2db8df69b7b5a3937c3e0eb63f67

commit fd8c26e0c11b2db8df69b7b5a3937c3e0eb63f67
Author: Dominic Battre <battre@chromium.org>
Date: Fri Feb 09 11:00:25 2018

More robust capturing <form>s that are taken out of the DOM.

Chrome's password manager tries to capture events where <form> elements
are taken out of the DOM or made invisible. This is used to detect
form submissions. This trigger failed in the past if a parent element
for the form was removed from the DOM or made invisible (as opposed
to the form it self). This CL makes the trigger logic more robust.

Bug:  760579 ,  710431 ,  593288 , 808911
Change-Id: I3dbe4618a8811da3299a1884bc37db3d46a79adb
Reviewed-on: https://chromium-review.googlesource.com/910968
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Commit-Queue: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535682}
[modify] https://crrev.com/fd8c26e0c11b2db8df69b7b5a3937c3e0eb63f67/chrome/renderer/autofill/password_autofill_agent_browsertest.cc
[modify] https://crrev.com/fd8c26e0c11b2db8df69b7b5a3937c3e0eb63f67/third_party/WebKit/Source/core/exported/WebFormElementObserverImpl.cpp

Sign in to add a comment