New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 710418 link

Starred by 1 user
Status: Fixed
Owner:
einbinder@chromium.org
Closed: Apr 2017
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : In devtools, drop down lists appear with grey background color when list is opened via keyboard.

Reported by avsha...@etouch.net, Apr 11 2017 
Chrome Version : 59.0.3067.6 (Official Build) 7f10b9ec80c846716034dd950e301e76c6f4f757-refs/branch-heads/3067@{#10} 32/64 bit
OS : Windows (7,8,10), Linux (14.04 LTS)

What steps will reproduce the problem?
1. Launch chrome and open devtools on NTP.
2. In 'Console drawer', click inside 'Filter' text box and hit TAB key.
3. Press 'Space bar' key (list opens) and observe the background color of 'Level' drop down list.

Actual : Background color of "Level" drop down list appears grey when list is opened via keyboard.

Expected : Instead, drop down list should have white background color.

This is a regression issue broken in ‘M-59’, below is the Manual Regression range and will soon update other info.
Good build : 59.0.3057.0
Bad build : 59.0.3059.0

Note : 
1. Above issue is not seen on Mac OS since the drop down UI is different.
2. Above issue is seen for all the drop down lists in devtools.
Act_Exp_BG_color.png
10.9 KB View Download
Actual_Result.mp4
1.9 MB View Download
Expected_Result.mp4
1.6 MB View Download

Comment 1 by rbasuvula@chromium.org, Apr 11 2017

Cc: rbasuvula@chromium.org
Labels: hasbisect-per-revision
Owner: einbinder@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build:59.0.3057.0 (Revision:460966).
Bad build:59.0.3059.0 (Revision:461269).

You are probably looking for a change made after 461006 (known good), but no later than 461007 (first known bad).

CHANGE-LOG URL:
---------------
https://chromium.googlesource.com/chromium/src/+log/903171556a94ceb362dc1681684aa9c82ba41a9b..4485d3c0dda30d0355fc7086bba089555e604f7a

From the CL above, assigning the issue to the concern owner

@einbinder: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Review-Url:  https://codereview.chromium.org/2741863002
Note :Able to reproduce the issue in Win 10.0,Ubuntu 14.04 & Not in Mac 10.12.3 and Able to reproduce in latest Canary #59.0.3068.1
Adding Release Block-Stable for this issue.Please remove if not the case.

Comment 2 by rbasuvula@chromium.org, Apr 11 2017

Labels: ReleaseBlock-Stable
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/90a6a03b89af32402fad1e443a3a2e48736795e4

commit 90a6a03b89af32402fad1e443a3a2e48736795e4
Author: einbinder <einbinder@chromium.org>
Date: Thu Apr 13 03:44:28 2017

DevTools: Dropdown lists shouldn't have grey background color

BUG= 710418 

Review-Url: https://codereview.chromium.org/2815983002
Cr-Commit-Position: refs/heads/master@{#464281}

[modify] https://crrev.com/90a6a03b89af32402fad1e443a3a2e48736795e4/third_party/WebKit/Source/devtools/front_end/ui/toolbar.css

Comment 4 by einbinder@chromium.org, Apr 13 2017

Status: Fixed (was: Assigned)
Project Member

Comment 5 by blocker...@chrome-infra-auth.iam.gserviceaccount.com, Apr 13 2017

Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-59; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-59 label, otherwise remove Merge-TBD label. Thanks.

Comment 6 by sureshkumari@chromium.org, Apr 18 2017

Labels: TE-Verified-M59 TE-Verified-59.0.3071.9
Tested the issue on Windows-7 and Linux Ubuntu-14.04 using chrome version# 59.0.3071.9.
Observed that the fix is working as expected. Hence adding TE-Verified labels.
Please find the attached screen cast for the same.

Thanks!!
710418.mp4
904 KB View Download

Comment 7 by gov...@chromium.org, Apr 21 2017

Labels: -Merge-TBD
M59 was branched at #464641 which is higher than CL listed #3 {#464281} so no merge is needed.
►

Sign in to add a comment