New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 710392 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug

Blocked on:
issue 612542
issue 712117



Sign in to add a comment

Some WebGL conformance tests failed on Linux AMD R7 240 after GPU-GPU texture uploading enabled

Project Member Reported by qiankun....@intel.com, Apr 11 2017

Issue description

https://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20Release%20%28AMD%20R7%20240%29/builds/1943

* gpu_tests.webgl_conformance_integration_test.WebGLConformanceIntegrationTest.WebglConformance_conformance2_textures_canvas_sub_rectangle_tex_2d_r8ui_red_integer_unsigned_byte
* gpu_tests.webgl_conformance_integration_test.WebGLConformanceIntegrationTest.WebglConformance_conformance2_textures_canvas_sub_rectangle_tex_2d_rg8ui_rg_integer_unsigned_byte
* gpu_tests.webgl_conformance_integration_test.WebGLConformanceIntegrationTest.WebglConformance_conformance2_textures_canvas_sub_rectangle_tex_2d_rgb8ui_rgb_integer_unsigned_byte
* gpu_tests.webgl_conformance_integration_test.WebGLConformanceIntegrationTest.WebglConformance_conformance2_textures_canvas_sub_rectangle_tex_2d_rgba8ui_rgba_integer_unsigned_byte
* gpu_tests.webgl_conformance_integration_test.WebGLConformanceIntegrationTest.WebglConformance_conformance2_textures_canvas_sub_rectangle_tex_2d_srgb8_alpha8_rgba_unsigned_byte
* gpu_tests.webgl_conformance_integration_test.WebGLConformanceIntegrationTest.WebglConformance_conformance2_textures_canvas_sub_rectangle_tex_2d_srgb8_rgb_unsigned_byte
* gpu_tests.webgl_conformance_integration_test.WebGLConformanceIntegrationTest.WebglConformance_conformance2_textures_canvas_tex_2d_r8ui_red_integer_unsigned_byte
* gpu_tests.webgl_conformance_integration_test.WebGLConformanceIntegrationTest.WebglConformance_conformance2_textures_canvas_tex_2d_rg8ui_rg_integer_unsigned_byte
* gpu_tests.webgl_conformance_integration_test.WebGLConformanceIntegrationTest.WebglConformance_conformance2_textures_canvas_tex_2d_rgb8ui_rgb_integer_unsigned_byte
* gpu_tests.webgl_conformance_integration_test.WebGLConformanceIntegrationTest.WebglConformance_conformance2_textures_canvas_tex_2d_rgba8ui_rgba_integer_unsigned_byte
* gpu_tests.webgl_conformance_integration_test.WebGLConformanceIntegrationTest.WebglConformance_conformance2_textures_canvas_tex_2d_srgb8_alpha8_rgba_unsigned_byte
* gpu_tests.webgl_conformance_integration_test.WebGLConformanceIntegrationTest.WebglConformance_conformance2_textures_canvas_tex_2d_srgb8_rgb_unsigned_byte
* gpu_tests.webgl_conformance_integration_test.WebGLConformanceIntegrationTest.WebglConformance_conformance2_textures_image_bitmap_from_canvas_tex_2d_r8ui_red_integer_unsigned_byte
* gpu_tests.webgl_conformance_integration_test.WebGLConformanceIntegrationTest.WebglConformance_conformance2_textures_image_bitmap_from_canvas_tex_2d_rg8ui_rg_integer_unsigned_byte
* gpu_tests.webgl_conformance_integration_test.WebGLConformanceIntegrationTest.WebglConformance_conformance2_textures_image_bitmap_from_canvas_tex_2d_rgb8ui_rgb_integer_unsigned_byte
* gpu_tests.webgl_conformance_integration_test.WebGLConformanceIntegrationTest.WebglConformance_conformance2_textures_image_bitmap_from_canvas_tex_2d_rgba8ui_rgba_integer_unsigned_byte
* gpu_tests.webgl_conformance_integration_test.WebGLConformanceIntegrationTest.WebglConformance_conformance2_textures_image_bitmap_from_canvas_tex_2d_srgb8_alpha8_rgba_unsigned_byte
* gpu_tests.webgl_conformance_integration_test.WebGLConformanceIntegrationTest.WebglConformance_conformance2_textures_image_bitmap_from_canvas_tex_2d_srgb8_rgb_unsigned_byte
* gpu_tests.webgl_conformance_integration_test.WebGLConformanceIntegrationTest.WebglConformance_conformance2_textures_webgl_canvas_tex_2d_r8ui_red_integer_unsigned_byte
* gpu_tests.webgl_conformance_integration_test.WebGLConformanceIntegrationTest.WebglConformance_conformance2_textures_webgl_canvas_tex_2d_rg8ui_rg_integer_unsigned_byte
* gpu_tests.webgl_conformance_integration_test.WebGLConformanceIntegrationTest.WebglConformance_conformance2_textures_webgl_canvas_tex_2d_rgb8ui_rgb_integer_unsigned_byte
* gpu_tests.webgl_conformance_integration_test.WebGLConformanceIntegrationTest.WebglConformance_conformance2_textures_webgl_canvas_tex_2d_rgba8ui_rgba_integer_unsigned_byte
* gpu_tests.webgl_conformance_integration_test.WebGLConformanceIntegrationTest.WebglConformance_conformance2_textures_webgl_canvas_tex_2d_srgb8_alpha8_rgba_unsigned_byte
* gpu_tests.webgl_conformance_integration_test.WebGLConformanceIntegrationTest.WebglConformance_conformance2_textures_webgl_canvas_tex_2d_srgb8_rgb_unsigned_byte
 
Owner: qiankun....@intel.com
Status: Assigned (was: Untriaged)
qiankun.miao@: could you take this on, or find an appropriate owner? Thanks!
Blockedon: 712117
 Issue 712795  has been merged into this issue.
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d28c22de85528d1f87bfbf3f88dc531027b24bd

commit 9d28c22de85528d1f87bfbf3f88dc531027b24bd
Author: qiankun.miao <qiankun.miao@intel.com>
Date: Thu Apr 20 06:22:07 2017

Force cube map texture complete on Linux AMD

CopyTex{Sub}Image2D reports INVALID_OPERATION error if the destination
texture is an integer incomplete cube map texture on Linux AMD. Similarly,
TexSubImage2D reports OUT_OF_MEMORY error if the destination texture is a
srgb incomplete cube map texture on Linux AMD. This is a bug in AMD Linux
driver. This CL workarounds this bug by forcing the texture to be cube map
complete.

BUG=710392,  712117 
TEST=webgl2 conformance test
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2821913002
Cr-Commit-Position: refs/heads/master@{#465915}

[modify] https://crrev.com/9d28c22de85528d1f87bfbf3f88dc531027b24bd/gpu/command_buffer/service/gles2_cmd_decoder.cc
[modify] https://crrev.com/9d28c22de85528d1f87bfbf3f88dc531027b24bd/gpu/command_buffer/service/texture_manager.cc
[modify] https://crrev.com/9d28c22de85528d1f87bfbf3f88dc531027b24bd/gpu/command_buffer/service/texture_manager.h
[modify] https://crrev.com/9d28c22de85528d1f87bfbf3f88dc531027b24bd/gpu/config/gpu_driver_bug_list.json
[modify] https://crrev.com/9d28c22de85528d1f87bfbf3f88dc531027b24bd/gpu/config/gpu_driver_bug_workaround_type.h

These tests still fail:
WebglConformance_conformance2_textures_canvas_tex_2d_rg8ui_rg_integer_unsigned_byte
WebglConformance_conformance2_textures_canvas_tex_2d_rgb8ui_rgb_integer_unsigned_byte
WebglConformance_conformance2_textures_canvas_tex_2d_rgba8ui_rgba_integer_unsigned_byte
WebglConformance_conformance2_textures_image_data_tex_3d_srgb8_rgb_unsigned_byte
WebglConformance_conformance2_textures_webgl_canvas_tex_2d_rg8ui_rg_integer_unsigned_byte
WebglConformance_conformance2_textures_webgl_canvas_tex_2d_rgb8ui_rgb_integer_unsigned_byte
WebglConformance_conformance2_textures_webgl_canvas_tex_2d_rgba8ui_rgba_integer_unsigned_byte

https://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20Release%20%28AMD%20R7%20240%29/builds/2006
Cc: fjhenigman@chromium.org
Labels: -Pri-3 Pri-1
From https://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20Release%20%28AMD%20R7%20240%29/builds/2007 to 2036 (last one as I write this) these fail consistently:

WebglConformance_conformance2_textures_canvas_tex_2d_rg8ui_rg_integer_unsigned_byte
WebglConformance_conformance2_textures_canvas_tex_2d_rgb8ui_rgb_integer_unsigned_byte
WebglConformance_conformance2_textures_canvas_tex_2d_rgba8ui_rgba_integer_unsigned_byte
WebglConformance_conformance2_textures_webgl_canvas_tex_2d_rg8ui_rg_integer_unsigned_byte
WebglConformance_conformance2_textures_webgl_canvas_tex_2d_rgb8ui_rgb_integer_unsigned_byte
WebglConformance_conformance2_textures_webgl_canvas_tex_2d_rgba8ui_rgba_integer_unsigned_byte

these fail sporadically (though every time one of them fails):

WebglConformance_conformance2_textures_image_data_tex_3d_srgb8_alpha8_rgba_unsigned_byte
WebglConformance_conformance2_textures_image_data_tex_3d_srgb8_rgb_unsigned_byte
WebglConformance_conformance2_textures_image_tex_2d_r11f_g11f_b10f_rgb_float

and the remainder pass.
To Comment 6,
The consistent failures in Comment 6 is caused by a Linux AMD bug, see  bug 712117 . 
Per https://codereview.chromium.org/2821913002/#msg25, we could not workaround the whole bug. 
Project Member

Comment 8 by bugdroid1@chromium.org, Apr 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/040161bcf50f09b2f69c75940e351362611708fa

commit 040161bcf50f09b2f69c75940e351362611708fa
Author: fjhenigman <fjhenigman@chromium.org>
Date: Wed Apr 26 06:45:46 2017

Webgl2 textures/canvas/tex-2d suppressions.

Suppress the following on Linux AMD R7 240:
conformance2_textures_canvas_tex_2d_rg8ui_rg_integer_unsigned_byte
conformance2_textures_canvas_tex_2d_rgb8ui_rgb_integer_unsigned_byte
conformance2_textures_canvas_tex_2d_rgba8ui_rgba_integer_unsigned_byte
conformance2_textures_webgl_canvas_tex_2d_rg8ui_rg_integer_unsigned_byte
conformance2_textures_webgl_canvas_tex_2d_rgb8ui_rgb_integer_unsigned_byte
conformance2_textures_webgl_canvas_tex_2d_rgba8ui_rgba_integer_unsigned_byte

BUG=710392
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2841853003
Cr-Commit-Position: refs/heads/master@{#467255}

[modify] https://crrev.com/040161bcf50f09b2f69c75940e351362611708fa/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py

Project Member

Comment 9 by sheriffbot@chromium.org, Jun 7 2017

Labels: Hotlist-Recharge-BouncingOwner
Owner: ----
Status: Untriaged (was: Assigned)
The assigned owner "qiankun.miao@intel.com" is not able to receive e-mails, please re-triage.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 10 by kbr@chromium.org, Jun 7 2017

Cc: -qiankun....@intel.com qkmiao@chromium.org
Status: Available (was: Untriaged)

Comment 11 by kbr@chromium.org, Jun 7 2017

Labels: -Pri-1 Pri-2
Project Member

Comment 12 by sheriffbot@chromium.org, Jun 8 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 13 by kbr@chromium.org, Jun 8 2018

Cc: -qkmiao@chromium.org
Labels: -Hotlist-Recharge-Cold
Status: Available (was: Untriaged)

Sign in to add a comment