Delete mojo::Un/WrapPlatformFile and mojo::Un/WrapSharedMemoryHandle |
|
Issue descriptionWhile the documentation of WrapPlatformFile/WrapSharedMemoryHandle states that they take ownership of the passed in handles, this isn't enforced by the compiler. This can lead to double closing if users are careless, see https://codereview.chromium.org/2809673002/ for an example of such a bug. Maybe the ownership should be expressed in the type system somehow (e.g. by using ScopedPlatformHandle). |
|
►
Sign in to add a comment |
|
Comment 1 by rockot@google.com
, Nov 15Labels: -Pri-3 Pri-2
Status: Available (was: Untriaged)
Summary: Delete mojo::Un/WrapPlatformFile and mojo::Un/WrapSharedMemoryHandle (was: WrapPlatformFile/WrapSharedMemoryHandle isn't foolproof)